henry authored 2 years ago and Pier Angelo Vendrame committed 1 year ago

Temporary fix until mozilla bug 1799153 gets a patch upstream.

Dan Ballard authored 1 year ago and Pier Angelo Vendrame committed 1 year ago

Bug 1828939 - Remove Share URL menu item when MOZ_PROXY_BYPASS_PROTECTION and restore Share by Email. r=mossop

Differential Revision: https://phabricator.services.mozilla.com/D175941

Backed out 8 changesets (bug 1830884, bug 1822466) for causing regressions in the upstream wpt tests. a=backout

Backed out changeset 7f4052a38bc6 (bug 1830884)
Backed out changeset 67d5d6a5f321 (bug 1830884)
Backed out changeset 77f0334c7976 (bug 1830884)
Backed out changeset 31607d74ee69 (bug 1830884)
Backed out changeset 256239106623 (bug 1822466)
Backed out changeset d94b6d6cd713 (bug 1822466)
Backed out changeset 2c6d325cb248 (bug 1822466)
Backed out changeset b89608b3c46a (bug 1822466)

Bug 1829327 - Use scrollbar-width style instead of ui.scrollbarFadeBeginDelay to hide overlay scrollbars. r=botond,geckoview-reviewers,owlish

Differential Revision: https://phabricator.services.mozilla.com/D176745

Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390 r=gfx-reviewers,ErichDonGubler

FEATURE_HW_DECODED_VIDEO_ZERO_COPY does not work with Intel HD Graphics 530 of Driver Version: 20.19.15.4390.

Differential Revision: https://phabricator.services.mozilla.com/D177864

Differential Revision: https://phabricator.services.mozilla.com/D177379

With the preceding patch, comment nodes are also moved at deleting a block/line
boundary.  However, this causes some WPT failures.  Therefore, this adds an
option to the related methods.

Note that Chrome removes all comment nodes in moving nodes.  However, I don't
have the motivation to do that because it requires additional cost and I have
no idea to improve the compatibility in usual web apps.  So I believe that
doing it wastes the runtime performance unless we'd get a bug reports by the
difference.

Therefore, this patch does not update WPTs too.

Differential Revision: https://phabricator.services.mozilla.com/D176767

`HTMLEditUtils::CanNodeContain` does not handle comment nodes and cdata section
nodes (the latter one is available only in XHTML documents, it's treated as a
comment node in HTML documents).

When copying HTML from Word on Windows, that contains 2 comment nodes at
start of pasting body (which does not appear in clipboard viewer, so, Gecko
creates them somewhere) and that causes `HTMLEditUtils::CanNodeContain` returns
`false` for any parents.  Therefore,
`HTMLEditor::InsertNodeIntoProperAncestorWithTransaction` returns error
and the pasting fails with odd state and unexpectedly split the list item in
`HTMLWithContextInserter::InsertContents`.  Finally, undoing fails to do some
of them and causes destroying the editable nodes.

This patch makes `HTMLEditUtils::CanNodeContain` work with comment nodes
and cdata section nodes (the latter is treated as a comment node since there
is no "cdata" tag definition of `nsHTMLTag`) and
`HTMLEditor::InsertNodeIntoProperAncestorWithTransaction` just return
"not handled" result for some other types of nodes which cannot be inserted
in any elements.

Note that the result of pasting from Word is different from Chrome's result.
Chrome does not paste such comment nodes (but inserts comment nodes with
`insertHTML` command).  For now, I don't want to work on fixing this
compatibility issue since comment nodes does not cause any known troubles.
Therefore, this patch does not contain WPT updates.

Differential Revision: https://phabricator.services.mozilla.com/D176766

FetchBody does nothing with the strong reference. Both ReadableStream and FetchStreamReader have their strong references and corresponding cycle collection, so this one can go away.

Depends on D177904

Differential Revision: https://phabricator.services.mozilla.com/D178098

1. NullifyStream has been there forever since bug 1128959 probably to release the underlying source early, but that purpose is now fulfilled internally in dom/streams by ReadableStreamController::ClearAlgorithms which calls BodyStreamUnderlyingSourceAlgorithms::ReleaseObjects.
2. FetchBody currently has two source of truth for `bodyUsed` but [per the spec](https://fetch.spec.whatwg.org/#dom-body-bodyused) it should just refer to `ReadableStream::Disturbed()`. Removing `mBodyUsed` would be more complex as there are several SetBodyUsed calls here and there, so this is only the first step to reduce the use of its own field but use the ReadableStream info directly.

Differential Revision: https://phabricator.services.mozilla.com/D177904

Differential Revision: https://phabricator.services.mozilla.com/D178119

Depends on D177944

Differential Revision: https://phabricator.services.mozilla.com/D178113

Differential Revision: https://phabricator.services.mozilla.com/D177944

Differential Revision: https://phabricator.services.mozilla.com/D178112

Bug 1817330 - Inform a reasonable APZHandledResult to GeckoView even if the APZ's result is nsEventStatus_eConsumeNoDefault. r=botond,geckoview-reviewers,owlish

Note that for touch events there are two possibilities where
InputQueue::ReceiveInputEvent() returns nsEventStatus_eConsumeNoDefault, a) the
touch input block is in a state of fast fling or b) the touch input block is in
a state of internal slop.

In the case of b) the nsEventStatus_eConsumeNoDefault status will never be used
since
 1) In cases of delayed results we just use the APZHandledResult we don't refer
    the nsEventStatus at all [1]
 2) In cases of non-delayed results even if the initial touch-start event gets
    into slop, TouchBlockState::UpdateSlopState returns false [2], thus APZ
    immediately reports one of the other nsEventStatuses and any subsequent
    statuses will never be used [3]

In the case of a) nsEventStatus_eConsumeNoDefault means the event doesn't need
to be sent to content, it doesn't mean any APZC didn't scroll by the event.

Also note that there's an automated test exercising the scenario a). It was
flaky before (bug 1687842), but now it appears to be stable.

[1] https://searchfox.org/mozilla-central/rev/32c74afbb24dce4b5dd6b33be71197e615631d71/gfx/layers/apz/src/InputQueue.cpp#986
[2] https://searchfox.org/mozilla-central/rev/32c74afbb24dce4b5dd6b33be71197e615631d71/gfx/layers/apz/src/InputBlockState.cpp#774-784
[3] https://searchfox.org/mozilla-mobile/rev/9fd115db1da9958a32c2cb2943fef79c1a0cac4a/firefox-android/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/NestedGeckoView.kt#85,122-132

Differential Revision: https://phabricator.services.mozilla.com/D177456

Differential Revision: https://phabricator.services.mozilla.com/D176392

These changes were originally done in bug 1804178 but were accidentally
undone by bug 1790816.

Differential Revision: https://phabricator.services.mozilla.com/D178117

Differential Revision: https://phabricator.services.mozilla.com/D177836

Backed out changeset 2b70a6c70b27 (bug 1832700) for causing spidermonkey bustages with Unknown version CLOSED TREE

Bug 1831242 - Remove revert-llvmorg-16-init-9324-g01859da84bad.patch. r=firefox-build-system-reviewers,sergesanspaille

Now that the underlying issue has been found and fixed on our side, we
don't need to workaround the issue at the compiler level anymore.

Differential Revision: https://phabricator.services.mozilla.com/D177554

Bug 1832708 - Disable std::__throw_* wrapping on libc++ >= 14.0. r=firefox-build-system-reviewers,andi

As of libc++ 14, the functions are defined in the std namespace rather
than std::<something>, which makes them conflict with our wrapping. This
is not a problem on libstdc++ because the functions are defined in the
library itself rather than the headers.

This was the real reason behind the addition of #ifndef __wasm__ ; this
is a more generic fix for the same problem.

Differential Revision: https://phabricator.services.mozilla.com/D177841

Differential Revision: https://phabricator.services.mozilla.com/D178090

Differential Revision: https://phabricator.services.mozilla.com/D177836

Back when it was added, the use case for to pick a specific version of
Visual Studio when several were installed on the system. This originally
allowed to pick between 2015 and 2017, and since then, 2015 support was
removed. But two new versions of VS also have been released, 2019 and
2022, and they were never added.

Furthermore, the option has been accidentally broken by bug 1123821.

I think it's time to declare it unnecessary and remove it.

Differential Revision: https://phabricator.services.mozilla.com/D177834

So that they aren't imported via #[path]. This allows cargo to see them
even before building.

Differential Revision: https://phabricator.services.mozilla.com/D178105

Bug 1831234 - Prepare the repack_rust.py script for rustc 1.70. r=firefox-build-system-reviewers,andi

The configuration used to build rustc changed the ignore-git field to
omit-git-hash.

Differential Revision: https://phabricator.services.mozilla.com/D177428

Differential Revision: https://phabricator.services.mozilla.com/D178109

Differential Revision: https://phabricator.services.mozilla.com/D178106

Background tasks are potentially very short living, such that things launched asynchronously during process startup might not have finished initializing when we are asked to shutdown.

In order to mitigate this, we introduce a configurable `backgroundTaskMinRuntimeMS` (default 500ms) that guarantees that a background task will last at least that time.

Documentation will be added in bug 1833198.

Differential Revision: https://phabricator.services.mozilla.com/D177879

Utility level is often used for nonperceivable work, but operates at a higher level than a background priority. This puts our background main thread priorities on the same level as the OS uses for general offthread work, so the perceivable delay to warm up the main thread on high cpu usage is limited to a few seconds (previously indefinite).

Differential Revision: https://phabricator.services.mozilla.com/D178096

As noted in the bug, this var just made us call a GDK function that is now
deprecated, which enables a GDK invalidation debugging feature that's
unrelated to our actual paint/invalidation pipeline these days.

Differential Revision: https://phabricator.services.mozilla.com/D177835

Backed out changeset cf53463469ba (bug 1832701)
Backed out changeset 2147a1728010 (bug 1832701)

Differential Revision: https://phabricator.services.mozilla.com/D178048

Differential Revision: https://phabricator.services.mozilla.com/D178016

Backed out 4 changesets (bug 1833104, bug 1831406) for causing failures in browser_startup_mainthreadio.js CLOSED TREE

Backed out changeset 536375224eb1 (bug 1831406)
Backed out changeset 3558266c434f (bug 1831406)
Backed out changeset 0385612c48c5 (bug 1831406)
Backed out changeset 256aac2b8a71 (bug 1833104)

Differential Revision: https://phabricator.services.mozilla.com/D178051