Kershaw Chang authored 6 months ago and ma1 committed 2 months ago

Bug 1907726 - Make sure WebTransportSessionProxy::NotifyDatagramReceived is called after OnStopRequest,  a=RyanVM

The crash occurs because WebTransportSessionProxy::OnDatagramReceivedInternal is called before WebTransportSessionProxy::OnStopRequest.
When this happens, WebTransportSessionProxy::mTarget is the main thread, so a task is dispatched to the main thread. This causes WebTransportSessionProxy::NotifyDatagramReceived to be called on the main thread.

If WebTransportSessionProxy::NotifyDatagramReceived is invoked while WebTransportSessionProxy::mStopRequestCalled is true, it can lead to OnDatagramReceived being called on the main thread (instead of the socket thread), resulting in a crash.

Original Revision: https://phabricator.services.mozilla.com/D220013

Differential Revision: https://phabricator.services.mozilla.com/D221661

Differential Revision: https://phabricator.services.mozilla.com/D178219

Bug 1831635: don't try to processed deferred WebTransport CreateStreams if connection is closed/refused r=necko-reviewers,kershaw

Differential Revision: https://phabricator.services.mozilla.com/D177316

Bug 1831131: Handle WebTransport createUni/BidirectionalStream before ready r=necko-reviewers,kershaw

creating streams is allowed before a transport is ready, and should fail
with InvalidStateError if the stream goes to closed or failed.

Differential Revision: https://phabricator.services.mozilla.com/D177108

Differential Revision: https://phabricator.services.mozilla.com/D174237

Bug 1830096 - Allow to create streams before WebTransportSessionProxyState::ACTIVE, r=jesup,necko-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D176640

Backed out changeset 54cc048fd39a (bug 1830096)
Backed out changeset 7337707e8b32 (bug 1830096)

Bug 1830096 - Allow to create streams before WebTransportSessionProxyState::ACTIVE, r=jesup,necko-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D176640

Differential Revision: https://phabricator.services.mozilla.com/D173115

Backed out changeset 9fda7af76207 (bug 1816918) for causing build bustage in dom/webtransport/parent/WebTransportParent.cpp CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D173115

Differential Revision: https://phabricator.services.mozilla.com/D173115

Backed out changeset db2b968157d6 (bug 1816918) for causing xpc assertion failures in mozilla/Maybe.h CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D173115

Differential Revision: https://phabricator.services.mozilla.com/D173743

Backed out changeset 57f13fcb6953 (bug 1816918) for causing build bustages on WebTransportParent.cpp. CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D173115

The asseration failure happened because we queued "OnIncomingStreamAvailableInternal" event and call it after "OnStopRequest". Before the event got invoked, the session can be already closed, so we hit the assertion.

Differential Revision: https://phabricator.services.mozilla.com/D172667

Differential Revision: https://phabricator.services.mozilla.com/D171706

Differential Revision: https://phabricator.services.mozilla.com/D171510

Backed out changeset fc25fcf256ca (bug 1817560) for causing xpc failures in dom/webtransport/test/xpcshell/test_close.js

The changes required to fix Bug 1817560  was partially submitted via https://phabricator.services.mozilla.com/D171451.
This review submits the remaining part of the fix.

Differential Revision: https://phabricator.services.mozilla.com/D171510

Since OnSesionReady is called on the main thread and others event not, there are lots of races need to be addressed.
This patch also annotates some members with correct thread safety macros.

Differential Revision: https://phabricator.services.mozilla.com/D170224

Bug 1817129: Ensure OnSessionClosed is called in error paths for AsyncConnect r=kershaw,necko-reviewers

WebTransportSessionProxy::AsyncConnect needs to ensure the caller gets the
normal callback from AsyncConnect, or require that they not wait for it on
an error return from AsyncConnect.   Also, several error paths didn't clear
the listener and didn't change the state to 'DONE'.

Differential Revision: https://phabricator.services.mozilla.com/D170028

Backed out 14 changesets (bug 1815997, bug 1811624, bug 1814122, bug 1818074, bug 1815993, bug 1811958, bug 1814113, bug 1790678, bug 1817130, bug 1817129, bug 1814750, bug 1817521) for causing bp-hybrid build bustages related to WebTransport. CLOSED TREE

Backed out changeset 8cfdfa663856 (bug 1790678)
Backed out changeset 44f5c3b41dac (bug 1818074)
Backed out changeset debbb57f5328 (bug 1817130)
Backed out changeset 85dac52e3e4c (bug 1817521)
Backed out changeset ddb0ea4cdda2 (bug 1817129)
Backed out changeset 799ad4a11f33 (bug 1815993)
Backed out changeset fc263dcd3c5e (bug 1790678)
Backed out changeset 331d1209db0d (bug 1814113)
Backed out changeset 738d3cb6d163 (bug 1814122)
Backed out changeset 4c743c9e706a (bug 1814750)
Backed out changeset e7e0a6849e43 (bug 1811624)
Backed out changeset c8a708ab94c5 (bug 1811958)
Backed out changeset 62a3991715fb (bug 1814113)
Backed out changeset 85d446d9d20c (bug 1815997)

Bug 1817129: Ensure OnSessionClosed is called in error paths for AsyncConnect r=kershaw,necko-reviewers

WebTransportSessionProxy::AsyncConnect needs to ensure the caller gets the
normal callback from AsyncConnect, or require that they not wait for it on
an error return from AsyncConnect.   Also, several error paths didn't clear
the listener and didn't change the state to 'DONE'.

Differential Revision: https://phabricator.services.mozilla.com/D170028

Bug 1815681 - Establish webtransport session when receiving 2xx response, r=necko-reviewers,valentin

Differential Revision: https://phabricator.services.mozilla.com/D169195

Differential Revision: https://phabricator.services.mozilla.com/D169455

Differential Revision: https://phabricator.services.mozilla.com/D167794

Bug 1809753 - Part 3: Replace all callers of GetCurrentEventTarget with GetCurrentSerialEventTarget, r=mccr8,necko-reviewers,valentin

This only changes the behaviour when called with a TaskQueue or other type
using SerialEventTargetGuard on the stack. They are being switched over as the
existing GetCurrentEventTarget method is being removed, as it is somewhat
confusing, and poorly documented.

Callers which need to get the current thread even when on a threadpool or
behind a TaskQueue were switched to GetCurrentEventTarget in the previous part.

Differential Revision: https://phabricator.services.mozilla.com/D166607

Backed out 6 changesets (bug 1809752, bug 1809753) for causing perma failures in browser/components/firefoxview/tests/browser/browser_feature_callout_position.js

Backed out changeset ea05784d74c4 (bug 1809753)
Backed out changeset 7c9b20eebcc8 (bug 1809753)
Backed out changeset d0267ac2256d (bug 1809753)
Backed out changeset aa9f2971bd6f (bug 1809753)
Backed out changeset f0d9fcfaa6f8 (bug 1809752)
Backed out changeset 6d58c799cffe (bug 1809752)

Bug 1809753 - Part 3: Replace all callers of GetCurrentEventTarget with GetCurrentSerialEventTarget, r=mccr8,necko-reviewers,valentin

This only changes the behaviour when called with a TaskQueue or other type
using SerialEventTargetGuard on the stack. They are being switched over as the
existing GetCurrentEventTarget method is being removed, as it is somewhat
confusing, and poorly documented.

Callers which need to get the current thread even when on a threadpool or
behind a TaskQueue were switched to GetCurrentEventTarget in the previous part.

Differential Revision: https://phabricator.services.mozilla.com/D166607

Differential Revision: https://phabricator.services.mozilla.com/D165312

Backed out changeset a897bd615bb3 (bug 1805196) for causing webtransport related xpcshell failures. CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D165312

Differential Revision: https://phabricator.services.mozilla.com/D165682

Backed out changeset 14ce0e459a46 (bug 1805196) for causing build bustages at WebTransportParent. CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D165312

There are several races could happen in WebTransport code and this patch aims to fix them.

Differential Revision: https://phabricator.services.mozilla.com/D165619