Skip to content
Snippets Groups Projects
  1. Nov 07, 2023
  2. Oct 30, 2023
  3. Oct 19, 2023
  4. Oct 31, 2023
  5. Nov 06, 2023
  6. Nov 02, 2023
  7. Nov 01, 2023
    • James Teh's avatar
      Bug 1848991: Attach a RemoteAccessible to its parent before calling ProxyCreated. (ESR) a=RyanVM · 7e16816a
      James Teh authored
      This is what we did before the fix for bug 1779578.
      Failure to do this meant that RemoteAccessible::IsLink() returned false even for a child of a HyperText Accessible, which meant the ATK object was created without the HyperLink interface.
      This change requires that we move the handling of pending OOP child docs, since we can't add a child document until ProxyCreated has been called on the OuterDoc.
      
      Original Revision: https://phabricator.services.mozilla.com/D186423
      
      Depends on D192440
      
      Differential Revision: https://phabricator.services.mozilla.com/D192441
      7e16816a
    • James Teh's avatar
      Bug 1779578 part 2: Split serialization of a11y subtrees across multiple IPDL... · 284e8a92
      James Teh authored
      Bug 1779578 part 2: Split serialization of a11y subtrees across multiple IPDL calls if we are likely to exceed the IPDL maximum message size. (ESR)  a=RyanVM
      
      In the content process, we simply split into multiple calls when the number of Accessibles exceeds our maximum.
      The maximum is calculated to allow for every Accessible to consume 2 KB in the IPDL message.
      Currently, this means we split every 131072 Accessibles.
      Of course, we could still exceed this IPDL message size if one or more  Accessibles consumed a lot more than this; e.g. many labels longer than 2 KB.
      However, this seems unlikely in the real world.
      If this turns out to be a problem, we'll need to count the actual size of the serialized data for each Accessible.
      For example, we could use AccAttributes::SizeOfExcludingThis, though that isn't exactly the serialized size.
      I worry though that such data structure traversal could get expensive at scale.
      
      In the parent process, we defer attaching the root of the new subtree to its parent until the final call.
      This is achieved by saving the root during the first call and using that to attach and fire events in the final call.
      
      Original Revision: https://phabricator.services.mozilla.com/D184367
      
      Depends on D192439
      
      Differential Revision: https://phabricator.services.mozilla.com/D192440
      284e8a92
    • James Teh's avatar
      Bug 1779578 part 1: When serializing a11y subtrees, include parent id and... · 8ca15e78
      James Teh authored
      Bug 1779578 part 1: When serializing a11y subtrees, include parent id and index in parent for each Accessible. (ESR)  a=RyanVM
      
      When we serialize a subtree, we put it into a flat list.
      Previously, we included the child count for each Accessible so that we knew how many Accessibels to consume as children when de-serializing.
      We also de-serialized recursively.
      This made it very difficult to split serialization across IPDL calls, since we would always end up splitting in the middle of some Accessible's children.
      Instead, we now no longer include the child count, but we do include the parent id and the index of the child in that parent.
      This means that each Accessible can be de-serialized independently and iteratively, making it possible to split wherever we need to.
      RemoteAccessible creation has also been separated from attachment of the child to its parent, since we will need this when splitting.
      
      Original Revision: https://phabricator.services.mozilla.com/D184366
      
      Differential Revision: https://phabricator.services.mozilla.com/D192439
      8ca15e78
  8. Oct 23, 2023
    • Jonathan Kew's avatar
      Bug 1854090 - Omit psnames of fonts with family-name *.tmp from src:local()... · 338e892a
      Jonathan Kew authored
      Bug 1854090 - Omit psnames of fonts with family-name *.tmp from src:local() lookups on Windows. r=jwatt, a=dsmith
      
      This is a sad hack, but aims to work around the issue that some
      PDF-related software (Acrobat is suspected but not currently confirmed)
      is potentially polluting the global font collection with re-encoded
      subsets of standard fonts like Arial, but does not munge the psname;
      these can then be returned by src:local(...) lookups, which results in
      garbled or missing text.
      
      In principle, if such fonts are "installed", Firefox is not wrong to use
      them; it's just a badly-configured system. But given that it seems to be
      caused by some PDF-handling software, without the user's knowledge, it
      seems worth trying to avoid the problem. Simply skipping the psname of
      any font with family-name *.tmp is highly unlikely to adversely affect
      any real-world content.
      
      Differential Revision: https://phabricator.services.mozilla.com/D191639
      338e892a
  9. Oct 24, 2023
  10. Oct 31, 2023
  11. Oct 24, 2023
  12. Oct 27, 2023
  13. Oct 25, 2023
  14. Oct 02, 2023
  15. Oct 23, 2023
  16. Oct 25, 2023
  17. Oct 30, 2023
  18. Oct 25, 2023
  19. Oct 24, 2023
  20. Oct 26, 2023
  21. Oct 28, 2023
  22. Oct 26, 2023
  23. Oct 09, 2023
  24. Oct 24, 2023
    • Mark Banner's avatar
      Bug 1860531 - Add new queryParamNames option to search-telemetry-v2 schema for... · a0dc36c7
      Mark Banner authored
      Bug 1860531 - Add new queryParamNames option to search-telemetry-v2 schema for specifying multiple query parameter names. r=search-reviewers,jteow a=RyanVM
      
      This is a new option that allows specifying multiple query parameter names, so that we can support
      some search engines on mobile, where they use a different parameter name to desktop.
      
      A future changeset will make 'queryParamNames' a required parameter.
      a0dc36c7
  25. Sep 25, 2023
  26. Aug 04, 2023
  27. Oct 18, 2023
  28. Oct 25, 2023
  29. Oct 26, 2023
Loading