Bug 1747756 - Move Windows system libraries from LIBS to moz.build. r=firefox-build-system-reviewers,mhentges

While mingw builds don't require user32 and advapi32 explicitly, it doesn't
hurt for them to be there (and they're required for clang-cl build).
Likewise, while clang-builds don't require uuid and userenv explicitly
because they're pulled in via #pragmas in the source code, mingw doesn't
support those #pragmas and needs them explicitly, which doesn't hurt the
clang-cl builds.

Differential Revision: https://phabricator.services.mozilla.com/D134737

Bug 1747756 - Move Windows system libraries from LIBS to moz.build. r=firefox-build-system-reviewers,mhentges

While mingw builds don't require user32 and advapi32 explicitly, it doesn't
hurt for them to be there (and they're required for clang-cl build).
Likewise, while clang-builds don't require uuid and userenv explicitly
because they're pulled in via #pragmas in the source code, mingw doesn't
support those #pragmas and needs them explicitly, which doesn't hurt the
clang-cl builds.

Differential Revision: https://phabricator.services.mozilla.com/D134737

For a unified it is possible to include FdPrintf.cpp before FdPrintf.h which
creates a compilation warning for FdPrintf's attributes.  FdPrintf.cpp
should include FdPrintf.h so that the declaration always precedes the
definition.

Depends on D132913

Differential Revision: https://phabricator.services.mozilla.com/D132914

Fix the reported error in Bug 1743713 plus a linker error.

Differential Revision: https://phabricator.services.mozilla.com/D132913

-Wshadow warnings are not enabled globally, so these -Wno-shadow suppressions have no effect. I had intended to enable -Wshadow globally along with these suppressions in some directories (in bug 1272513), but that was blocked by other issues.

There are too many -Wshadow warnings (now over 2000) to realistically fix them all. We should remove all these unnecessary -Wno-shadow flags cluttering many moz.build files.

Differential Revision: https://phabricator.services.mozilla.com/D132289

Differential Revision: https://phabricator.services.mozilla.com/D132006

Differential Revision: https://phabricator.services.mozilla.com/D28516

Differential Revision: https://phabricator.services.mozilla.com/D131576

Backed out changeset 85fdbf7e368a (bug 1735482) for causing OS X build bustages on mozjemalloc.cpp. CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D131576

Differential Revision: https://phabricator.services.mozilla.com/D131197

Differential Revision: https://phabricator.services.mozilla.com/D129807

Differential Revision: https://phabricator.services.mozilla.com/D129806

Differential Revision: https://phabricator.services.mozilla.com/D131576

Bug 1736968 - Change MOZ_CRASH() to MOZ_ASSUME_UNREACHABLE_MARKER() for abort()'s ARM noreturn case. r=glandium

This MOZ_CRASH() is redundant after calling noreturn function mozalloc_abort. The MOZ_ASSUME_UNREACHABLE_MARKER() annotation makes ARM's "function declared 'noreturn' should not return" warnings go away.

Differential Revision: https://phabricator.services.mozilla.com/D129115

Bug 1736968 - Pass mozalloc_abort() crash reason to MOZ_CRASH() to distinguish mozalloc_abort() and bare MOZ_CRASH() crashes. r=glandium

Differential Revision: https://phabricator.services.mozilla.com/D129114

Differential Revision: https://phabricator.services.mozilla.com/D129228

Backed out changeset 27b73fdbb4a9 (bug 1737199) for causing bustages on memory/replace/logalloc/replay/Replay.cpp. CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D129228

Differential Revision: https://phabricator.services.mozilla.com/D128983

jemalloc_stats takes an array for its second argument.  It expects this
array to have enough space for all the bins, previously the maximum was set
as a magic number.  To make it dependent on the configured bins this patch
replaces the compile-time constant with a function.

Differential Revision: https://phabricator.services.mozilla.com/D127761

Differential Revision: https://phabricator.services.mozilla.com/D128448

Differential Revision: https://phabricator.services.mozilla.com/D92729

Differential Revision: https://phabricator.services.mozilla.com/D92729

Differential Revision: https://phabricator.services.mozilla.com/D126310

dom/base/EventSource.cpp:59:22: error: unused variable 'gEventSourceLog' [-Werror,-Wunused-variable]
static LazyLogModule gEventSourceLog("EventSource");
                     ^
dom/xul/nsXULCommandDispatcher.cpp:35:22: error: unused variable 'gCommandLog' [-Werror,-Wunused-variable]
static LazyLogModule gCommandLog("nsXULCommandDispatcher");
                     ^
layout/generic/ScrollAnchorContainer.cpp:23:31: error: unused variable 'sAnchorLog' [-Werror,-Wunused-variable]
static mozilla::LazyLogModule sAnchorLog("scrollanchor");
                              ^
memory/replace/phc/PHC.cpp:308:15: error: unused variable 'kAllocJunk' [-Werror,-Wunused-const-variable]
const uint8_t kAllocJunk = 0xe4;
              ^

Differential Revision: https://phabricator.services.mozilla.com/D126866

This also tightens the check for PHC-type crashes in the exception handler
so that we don't accidentally try to interpret unrelated crash types as
potential PHC ones.

Differential Revision: https://phabricator.services.mozilla.com/D126365

This has the side-effect of adding the missing arm64 mac support for PHC.

Differential Revision: https://phabricator.services.mozilla.com/D125139

It allows to more easily test different page sizes.

Differential Revision: https://phabricator.services.mozilla.com/D124015

Bug 1725145 - Preparation for the hybrid build env. r=necko-reviewers,firefox-build-system-reviewers,valentin,glandium

Automatically generated path that adds flag `REQUIRES_UNIFIED_BUILD = True` to `moz.build`
when the module governed by the build config file is not buildable outside on the unified environment.

This needs to be done in order to have a hybrid build system that adds the possibility of combing
unified build components with ones that are built outside of the unified eco system.

Differential Revision: https://phabricator.services.mozilla.com/D122345

The codeql initialization process causes a loop in allocator
initialization that results in the inability to issue open()
calls due to function interception having begun set-up but
not completing it.  (More details in bug.)

Differential Revision: https://phabricator.services.mozilla.com/D120521

"print" had no params so it wasn't doing anything, causing there
to be less newlines than needed.

The default stack frame width is a bit narrow, so I increased it.

There are a few new uninteresting functions showing up, so I've
added them to the allocator list.

Differential Revision: https://phabricator.services.mozilla.com/D118381

Differential Revision: https://phabricator.services.mozilla.com/D116339

isspace requires data in libc to be initialised.  If we're parsing
/proc/smaps before libc has initialised we need to provide our own
implementation.

Differential Revision: https://phabricator.services.mozilla.com/D116338

Depends on D109729

Differential Revision: https://phabricator.services.mozilla.com/D109731

Backed out changeset 49f8a4acd649 (bug 1712674) for stack walking crashes on older Windows versions (bug 1715633).

CLOSED TREE

Bug 1715553 - Disable logalloc-replay check on code-coverage builds. r=firefox-build-system-reviewers,nalexander

It was already disabled for fuzzed code-coverage in bug 1695331. My
guess is that fuzzed code-coverage tripped on the extra allocations
due to the code-coverage runtime, but the code-coverage builds didn't
trip it because they also triggered an exception, which further
triggered a bug in the code with python3 (and somehow the fuzzed ccov
builds didn't trigger that). That bug effectively masked the failure.

Differential Revision: https://phabricator.services.mozilla.com/D117383

BP may contain the stack address where the caller's BP was pushed after the function call, in which case it's possible to carefully unwind from it.

This can get past JIT code, so there is no need to give up in this case.

mozglue was already linked with ntdll, but now that we use it directly (for `NtQueryInformationThread`), ntdll needed to be added to some other users of MozStackWalkThread.

Differential Revision: https://phabricator.services.mozilla.com/D115962