- Jan 20, 2022
-
-
Nika Layzell authored
Bug 1749497 - Remove failing beta-only StringStream test, r=xpcom-reviewers,mccr8 a=test-only DONTBUILD The behaviour which this test was intended to test was only used in release builds, due to the diagnostic assertion in other builds. The new equivalent of this assertion has been upgraded to a release assertion, so the test should no longer be required. Differential Revision: https://phabricator.services.mozilla.com/D136297
-
- Jan 17, 2022
-
-
Paul Zuehlcke authored
Depends on D128630 Differential Revision: https://phabricator.services.mozilla.com/D128631
-
- Jan 09, 2022
-
-
criss authored
Backed out changeset e59035c65af3 (bug 371900) Backed out changeset 6434bce9c7d4 (bug 371900)
-
- Jan 08, 2022
-
-
Neil Deakin authored
Bug 371900, always fire a command event on key elements except for those that are marked not to, r=masayuki The edit-related commands are special because they are handled by ShortcutKeyDefinitions.cpp yet we have duplicate keys because we want the menu disabled state to update properly, so we don't fire command events on those. Differential Revision: https://phabricator.services.mozilla.com/D135157
-
- Jan 07, 2022
-
-
Nika Layzell authored
Differential Revision: https://phabricator.services.mozilla.com/D135166
-
Nika Layzell authored
Previously all xpidl constants were specified as `i64` which means they require casts before being passed to any xpcom methods. The lack of typing was not an issue in c++ due to implicit casts from enums to integer types, but using the correct type is much more valuable in Rust. Differential Revision: https://phabricator.services.mozilla.com/D135165
-
Nika Layzell authored
The constants must fit within an int32_t or uint32_t as that is required by the JS backend with xpt types holding a `uint32_t` and signed bit. Differential Revision: https://phabricator.services.mozilla.com/D135164
-
Nika Layzell authored
This change aims to make the way that the nsStringInputStream owns the backing data buffer more flexible. This has a few impacts, including allowing arbitrarily large payload sizes on 64-bit platforms, not requiring as complex checks around borrowed string buffers or nsTArray data storage, and supporting custom data ownership schemes such as those used by blobs. The new system uses a separate refcounted object internally to provide the contiguous backing buffer, with the nsStringInputStream wrapping it and providing the `nsIInputStream` interface and cursor. This also avoids issues around the buffer being mutated during reads, as mutating the `nsIInputStream` no longer mutates the actual data storage object. Differential Revision: https://phabricator.services.mozilla.com/D135162
-
- Jan 05, 2022
-
-
Nika Layzell authored
Differential Revision: https://phabricator.services.mozilla.com/D135084
-
Andreas Pehrson authored
The Runnable markers in the profilers are handy, but miss many types of runnables. This includes most of those that wrap another runnable and run that at a (possibly) later time. AbstractThread, TaskDispatcher and TaskQueue does this for e.g. tail dispatched tasks. TaskQueueWrapper does this when wrapping webrtc tasks (and Mozilla Runnables) to be run in a Mozilla TaskQueue with some overhead on the stack. DelayedRunnable wraps a runnable to be run after a timeout. It would perhaps be better in many cases to ignore the intermediate runnables, but I haven't seen a straight forward way to achieve this. More detailed data could be added on a case by case basis, for instance the delay for a DelayedRunnable (incl. actual vs. target delay) or the scope of a task in which a tail-dispatched runnable was dispatched. But this is also true for the status quo (for instance the time from dispatch to run) so I leave these ideas as future work. Differential Revision: https://phabricator.services.mozilla.com/D135027
-
Emilio Cobos Álvarez authored
There's no reason for that function to live in the GIOService interface. Differential Revision: https://phabricator.services.mozilla.com/D135121
-
Butkovits Atila authored
Backed out 7 changesets (bug 1746361, bug 1748280, bug 1746347) for causing failures at browser_interaction-between-interfaces.js. CLOSED TREE Backed out changeset eccba94506f0 (bug 1748280) Backed out changeset baf39ae53772 (bug 1748280) Backed out changeset 775843562f7e (bug 1748280) Backed out changeset 0987c68e9683 (bug 1748280) Backed out changeset 58dd008520da (bug 1746361) Backed out changeset 6f9e800877a6 (bug 1746347) Backed out changeset f78e794a9c2f (bug 1746347)
-
Andreas Pehrson authored
The Runnable markers in the profilers are handy, but miss many types of runnables. This includes most of those that wrap another runnable and run that at a (possibly) later time. AbstractThread, TaskDispatcher and TaskQueue does this for e.g. tail dispatched tasks. TaskQueueWrapper does this when wrapping webrtc tasks (and Mozilla Runnables) to be run in a Mozilla TaskQueue with some overhead on the stack. DelayedRunnable wraps a runnable to be run after a timeout. It would perhaps be better in many cases to ignore the intermediate runnables, but I haven't seen a straight forward way to achieve this. More detailed data could be added on a case by case basis, for instance the delay for a DelayedRunnable (incl. actual vs. target delay) or the scope of a task in which a tail-dispatched runnable was dispatched. But this is also true for the status quo (for instance the time from dispatch to run) so I leave these ideas as future work. Differential Revision: https://phabricator.services.mozilla.com/D135027
-
Chris Peterson authored
Calling NSS_IsInitialized() off the main thread caused intermittent tsan failures because NSS_IsInitialized() reads global variable nssIsInitted without acquiring the nssInitLock lock. During Firefox startup, about 1000 nsIDs are generated, but only about 10 are generated off the main thread, so this change has very little impact on how often nsID::GenerateUUID() will use NSS's RNG. Of the nsIDs generated on the main thread during startup, about 600 are generated before NSS is initialized (so they use MFBT's RNG) and 400 are generated after NSS is initialized. After Firefox reaches a steady state, loading a light web page like google.com generates about 300 nsIDs and a heavy web page like cnn.com generates about 2000 nsIDs. All these nsIDs are generated on the main thread using NSS's RNG. Differential Revision: https://phabricator.services.mozilla.com/D134233
-
- Jan 04, 2022
-
-
Randell Jesup authored
Differential Revision: https://phabricator.services.mozilla.com/D134062
-
Iulian Moraru authored
-
Chris Peterson authored
Calling NSS_IsInitialized() off the main thread caused intermittent tsan failures because NSS_IsInitialized() reads global variable nssIsInitted without acquiring the nssInitLock lock. During Firefox startup, about 1000 nsIDs are generated, but only about 10 are generated off the main thread, so this change has very little impact on how often nsID::GenerateUUID() will use NSS's RNG. Of the nsIDs generated on the main thread during startup, about 600 are generated before NSS is initialized (so they use MFBT's RNG) and 400 are generated after NSS is initialized. After Firefox reaches a steady state, loading a light web page like google.com generates about 300 nsIDs and a heavy web page like cnn.com generates about 2000 nsIDs. All these nsIDs are generated on the main thread using NSS's RNG. Differential Revision: https://phabricator.services.mozilla.com/D134233
-
- Dec 31, 2021
-
-
Andreea Pavel authored
Bug 1422219 - disable ThreadUtils.IdleRunnableMethod due to frequent failures r=intermittent-reviewers,jmaher Differential Revision: https://phabricator.services.mozilla.com/D134762
-
- Dec 30, 2021
-
-
Mike Hommey authored
Bug 1747756 - Move Windows system libraries from LIBS to moz.build. r=firefox-build-system-reviewers,mhentges While mingw builds don't require user32 and advapi32 explicitly, it doesn't hurt for them to be there (and they're required for clang-cl build). Likewise, while clang-builds don't require uuid and userenv explicitly because they're pulled in via #pragmas in the source code, mingw doesn't support those #pragmas and needs them explicitly, which doesn't hurt the clang-cl builds. Differential Revision: https://phabricator.services.mozilla.com/D134737
-
- Dec 29, 2021
-
-
Iulian Moraru authored
-
Mike Hommey authored
Bug 1747756 - Move Windows system libraries from LIBS to moz.build. r=firefox-build-system-reviewers,mhentges While mingw builds don't require user32 and advapi32 explicitly, it doesn't hurt for them to be there (and they're required for clang-cl build). Likewise, while clang-builds don't require uuid and userenv explicitly because they're pulled in via #pragmas in the source code, mingw doesn't support those #pragmas and needs them explicitly, which doesn't hurt the clang-cl builds. Differential Revision: https://phabricator.services.mozilla.com/D134737
-
- Dec 28, 2021
-
-
Eitan Isaacson authored
The goal of this event is for doing hit testing in content and emit an accessibility event with the result for Android's explore by touch. This event allows us to use APZ's ability to target the correct content doc. Differential Revision: https://phabricator.services.mozilla.com/D132840
-
- Dec 25, 2021
-
-
Bobby Holley authored
We were double-allocating in TransferBuffer, but that was canceling out the fact that we were only half-copying. Differential Revision: https://phabricator.services.mozilla.com/D134669
-
Barret Rennie authored
This patch adds support for setting, getting, and reading extended filesystem attributes on macOS. Differential Revision: https://phabricator.services.mozilla.com/D133836
-
- Dec 24, 2021
-
-
Butkovits Atila authored
Backed out 2 changesets (bug 1736331) for causing failures at test_ioutils_mac_xattr.html. CLOSED TREE Backed out changeset 3d627a038faa (bug 1736331) Backed out changeset b0df890ed09e (bug 1736331)
-
- Dec 23, 2021
-
-
Barret Rennie authored
This patch adds support for setting, getting, and reading extended filesystem attributes on macOS. Differential Revision: https://phabricator.services.mozilla.com/D133836
-
- Dec 25, 2021
-
-
Bobby Holley authored
We were double-allocating in TransferBuffer, but that was canceling out the fact that we were only half-copying. Differential Revision: https://phabricator.services.mozilla.com/D134669
-
- Dec 23, 2021
-
-
Mike Hommey authored
Bug 1747165 - Replace TK_FLAGS/TK_LIBS with MOZ_GTK3_FLAGS/MOZ_GTK3_LIBS. r=firefox-build-system-reviewers,andi Differential Revision: https://phabricator.services.mozilla.com/D134464
-
Cristian Tuns authored
Backed out changeset 4b1ab0915c94 (bug 1747165) Backed out changeset 96043d814772 (bug 1747165)
-
Toshihito Kikuchi authored
While processing third-party module loading events, the process may delayload shlwapi.dll. This could be a problem if the process is sandboxed and the access to local files is restricted. Before enabling the third-party modules ping in socket process, this patch avoids such delayloading. The first path is `ParamTraits<mozilla::ModuleRecord>::Read` calls `NS_NewLocalFile` that calls `PathGetDriveNumberW`. This API is simple enough that we define our own version. The second path is the ctor of `ProcessedModuleLoadEvent` that is called from `UntrustedModulesProcessor::CompleteProcessing` calls `PreparePathForTelemetry` that calls `PathFindFileNameW` and `PathCanonicalizeW`. For this path, instead of sanitizing a requested name in `ProcessedModuleLoadEvent`'s ctor, we sanitize it when transferring it to the main process. Differential Revision: https://phabricator.services.mozilla.com/D134492
-
- Dec 22, 2021
-
-
Mike Hommey authored
Bug 1747165 - Replace TK_FLAGS/TK_LIBS with MOZ_GTK3_FLAGS/MOZ_GTK3_LIBS. r=firefox-build-system-reviewers,andi Differential Revision: https://phabricator.services.mozilla.com/D134464
-
Mike Hommey authored
They were superseded by AppConstants.{RELEASE_OR_BETA,MOZ_OFFICIAL_BRANDING}. Differential Revision: https://phabricator.services.mozilla.com/D134470
-
alwu authored
Differential Revision: https://phabricator.services.mozilla.com/D134520
-
Sandor Molnar authored
Backed out changeset 5745c2669e88 (bug 1736331) Backed out changeset 0a34c502e65f (bug 1736331)
-
Barret Rennie authored
This patch adds support for setting, getting, and reading extended filesystem attributes on macOS. Differential Revision: https://phabricator.services.mozilla.com/D133836
-
Steve Fink authored
Bug 1672121 - Stop sGCRunner GC slice if the IdleTaskRunnerTask gets a RequestInterrupt() call r=smaug Differential Revision: https://phabricator.services.mozilla.com/D109631
-
Csoregi Natalia authored
Backed out changeset 293085bdd5a1 (bug 1736331) Backed out changeset 275621f46891 (bug 1736331)
-
Barret Rennie authored
This patch adds support for setting, getting, and reading extended filesystem attributes on macOS. Differential Revision: https://phabricator.services.mozilla.com/D133836
-
Mike Hommey authored
And remove TK_CFLAGS when applied to mac only. Differential Revision: https://phabricator.services.mozilla.com/D134460
-
- Dec 21, 2021
-
-
Mike Hommey authored
Differential Revision: https://phabricator.services.mozilla.com/D134443
-