Skip to content
Snippets Groups Projects
  1. Sep 20, 2021
  2. Jun 09, 2021
  3. Mar 24, 2021
  4. Mar 03, 2021
    • James Graham's avatar
      Bug 1695263 - Vendor in a copy of wptserve that's still Python 2 compatible,... · 78145858
      James Graham authored
      Bug 1695263 - Vendor in a copy of wptserve that's still Python 2 compatible, r=marionette-reviewers,whimboo
      
      Upstream wptserve just switched to Python 3 only. That's fine for
      web-platform-tests, but it turns out that some marionette harness
      tests are also using wptserve and are still on Python 2.
      
      Since fixing marionette harness turns out to be non-trivial and this
      blocks other wpt work, this patch does the following:
      
      * Temporarily vendors the last wptserve revision that works with
        Python 2 in to testing/web-platform/mozilla/tests/tools/wptserve_py2
      
      * Configures the mach virtualenv to use that copy for Python 2 modules
        only.
      
      * Configures the test packaging system to also put that copy in the
        common tests zip. Requirements files are updated to use either the
        Python 2 version or the Pyhton 3 version as required.
      
      Differential Revision: https://phabricator.services.mozilla.com/D106764
      78145858
  5. Jan 21, 2021
  6. Sep 29, 2020
  7. Oct 29, 2020
    • Ricky Stewart's avatar
      Bug 1673700 - Don't use double quotes around strings in definition of... · fbe2b42f
      Ricky Stewart authored
      Bug 1673700 - Don't use double quotes around strings in definition of `fork_interpose` r=firefox-build-system-reviewers,glandium
      
      The definition of `patch_main()` has behavior that kicks in only on Windows and for Python 2. Unfortunately, not all of our `mach` commands have been migrated to Python 3, so this still matters.
      
      Bug 1654103 replaced the single-quoted strings in this function with double-quoted strings. This should be fine, except that we call into `multiprocessing.forking.main()` with some monkey-patching that is meant to fix a Windows-specific bug (see bug 1316140). We don't do any clever serialization or anything here and we end up just passing that source to `multiprocessing.forking.main()` which aggregates that source code [dumbly](https://github.com/python/cpython/blob/2.7/Lib/multiprocessing/forking.py#L259), wrapping everything in double-quotes again and passing it to `_subprocess.CreateProcess()`, which ends up failing if the source contains strings formatted with double quotes.
      
      We could revert bug 1654103 and exempt this file from linting, but that is overkill given that this file otherwise contains useful stuff. Instead we move everything to another file, exempt that file from linting, and update `util.py` accordingly.
      
      Differential Revision: https://phabricator.services.mozilla.com/D94909
      fbe2b42f
  8. Oct 21, 2020
  9. Jul 22, 2020
  10. Jul 21, 2020
  11. Jun 20, 2020
  12. Aug 31, 2020
  13. Aug 30, 2020
  14. Jun 16, 2020
    • Steve Fink's avatar
      Bug 1642121 - Remove directory dependence of GDB init files. r=nalexander · 14bc264f
      Steve Fink authored
      I wrote this patch to address two problems:
      
        1. if I do `mach run` from a directory other than $topsrcdir, $objdir, or
           $objdir/dist/bin, then .gdbinit will not be loaded.
        2. Debugging the firefox binary will never load the JS prettyprinters in any
           case.
      
      I believe this patch fixes other problems as well, such as .gdbinit_python not being found, and the gdbpp pretty-printers not getting loaded in various situations.
      
      The main changes of this patch are:
      
        1. Move .gdbinit into build/ (and $objdir/build/) to delay it from getting
           loaded until the search path is configured.
        2. Move libxul.so-gdb.py into the correct directory.
        3. Use either libxul.so-gdb.py or js-gdb.py to configure the correct
           search path then load .gdbinit, and have .gdbinit load all of the
           pretty-printers (Gecko and JS).
        4. Use a single preprocessed file to configure the source directory. Use
           relative paths within the objdir for everything else.
      
      Differential Revision: https://phabricator.services.mozilla.com/D77589
      14bc264f
  15. Jun 15, 2020
    • Noemi Erli's avatar
    • Steve Fink's avatar
      Bug 1642121 - Remove directory dependence of GDB init files. r=nalexander · 7fc47d90
      Steve Fink authored
      I wrote this patch to address two problems:
      
        1. if I do `mach run` from a directory other than $topsrcdir, $objdir, or
           $objdir/dist/bin, then .gdbinit will not be loaded.
        2. Debugging the firefox binary will never load the JS prettyprinters in any
           case.
      
      I believe this patch fixes other problems as well, such as .gdbinit_python not being found, and the gdbpp pretty-printers not getting loaded in various situations.
      
      The main changes of this patch are:
      
        1. Move .gdbinit into build/ (and $objdir/build/) to delay it from getting
           loaded until the search path is configured.
        2. Move libxul.so-gdb.py into the correct directory.
        3. Use either libxul.so-gdb.py or js-gdb.py to configure the correct
           search path then load .gdbinit, and have .gdbinit load all of the
           pretty-printers (Gecko and JS).
        4. Use a single preprocessed file to configure the source directory. Use
           relative paths within the objdir for everything else.
      
      Differential Revision: https://phabricator.services.mozilla.com/D77589
      7fc47d90
  16. Jun 12, 2020
  17. Jun 08, 2020
  18. Jul 08, 2020
  19. May 22, 2020
  20. Apr 16, 2020
  21. Mar 30, 2020
  22. Mar 22, 2020
  23. Mar 18, 2020
  24. Mar 17, 2020
  25. Feb 23, 2020
  26. Jan 23, 2020
  27. Dec 19, 2019
    • Razvan Maries's avatar
      Backed out changeset 69687a23245e (bug 1603804) for Lint failure. CLOSED TREE · 4a6468a6
      Razvan Maries authored
      --HG--
      rename : python/lldbutils/README.txt => third_party/python/lldbutils/README.txt
      rename : python/lldbutils/lldbutils/__init__.py => third_party/python/lldbutils/lldbutils/__init__.py
      rename : python/lldbutils/lldbutils/content.py => third_party/python/lldbutils/lldbutils/content.py
      rename : python/lldbutils/lldbutils/general.py => third_party/python/lldbutils/lldbutils/general.py
      rename : python/lldbutils/lldbutils/gfx.py => third_party/python/lldbutils/lldbutils/gfx.py
      rename : python/lldbutils/lldbutils/layout.py => third_party/python/lldbutils/lldbutils/layout.py
      rename : python/lldbutils/lldbutils/utils.py => third_party/python/lldbutils/lldbutils/utils.py
      4a6468a6
    • Jonathan Watt's avatar
      Bug 1603804. Move third_party/python/lldbutils to python/lldbutils. r=ahal · 8e978a5e
      Jonathan Watt authored
      This undoes the mistaken move of this directory into third_party that happened
      as part of bug 1346025.
      
      The .flake8 changes are required because lldbutils used to be excluded from
      linting by virtue of being inside third_party, but would otherwise be subject
      to it after this move. Fixing the existing lint errors will happen in:
      
        - https://bugzilla.mozilla.org/show_bug.cgi?id=1605144
        - https://bugzilla.mozilla.org/show_bug.cgi?id=1605145
      
      Differential Revision: https://phabricator.services.mozilla.com/D57141
      
      --HG--
      rename : third_party/python/lldbutils/README.txt => python/lldbutils/README.txt
      rename : third_party/python/lldbutils/lldbutils/__init__.py => python/lldbutils/lldbutils/__init__.py
      rename : third_party/python/lldbutils/lldbutils/content.py => python/lldbutils/lldbutils/content.py
      rename : third_party/python/lldbutils/lldbutils/general.py => python/lldbutils/lldbutils/general.py
      rename : third_party/python/lldbutils/lldbutils/gfx.py => python/lldbutils/lldbutils/gfx.py
      rename : third_party/python/lldbutils/lldbutils/layout.py => python/lldbutils/lldbutils/layout.py
      rename : third_party/python/lldbutils/lldbutils/utils.py => python/lldbutils/lldbutils/utils.py
      extra : moz-landing-system : lando
      8e978a5e
  28. Dec 13, 2019
  29. Nov 26, 2019
  30. Nov 08, 2019
  31. Oct 19, 2019
  32. Oct 18, 2019
  33. Oct 14, 2019
Loading