- Jun 05, 2023
-
-
Timothy Nikkel authored
Differential Revision: https://phabricator.services.mozilla.com/D179909
-
- Jun 03, 2023
-
-
Stanca Serban authored
Backed out changeset 7bc8c25b2935 (bug 1833244) Backed out changeset 4576af83a4ec (bug 1833244) Backed out changeset 90a5bbba7b9c (bug 1833244)
-
Jonathan Watt authored
OS print drivers/devices know nothing about page dimensions unless we tell them. Previously, the physical page dimensions (including orientation) have always been the same, so communicating their dimensions once at the start of a print has been enough. In preparation for supporting different "physical" page dimensions (in the immediate future only different page orientations) when we save to PDF, we need to have the infrastructure to pass dimensions through on a page-by-page basis. This patch adds that. None of the PrintTarget subclasses do anything with this extra information yet, but in a follow-up patch PrintTargetPDF will use this information to create PDFs with mixed page orientations. Differential Revision: https://phabricator.services.mozilla.com/D179423
-
- Jun 02, 2023
-
-
Nicholas Rishel authored
Differential Revision: https://phabricator.services.mozilla.com/D178745
-
Edgar Chen authored
Calling it in destructor doesn't work as expected at all, since it's a virtual function. Furthermore, it doesn't make sense to clear clipboard data every time Firefox is closed. Differential Revision: https://phabricator.services.mozilla.com/D178697
-
- Jun 01, 2023
-
-
Kershaw Chang authored
Bug 1543990 - Simplify nsISpeculativeConnect API, r=necko-reviewers,geckoview-reviewers,search-reviewers,valentin,m_kato Differential Revision: https://phabricator.services.mozilla.com/D179066
-
Emilio Cobos Álvarez authored
Since the headless work (bug 1129492 and co) we realistically have no way of rendering native scrollbars in any meaningful way. Remove dead code that used to support using a different GTK theme on content. Differential Revision: https://phabricator.services.mozilla.com/D179616
-
Edgar Chen authored
This also makes SelectionCache type supports clipboard owner. Differential Revision: https://phabricator.services.mozilla.com/D168006
-
Edgar Chen authored
Bug 1812078 - Part 1: Have separated clipboard caches for each clipbaord type to track clipboard owner; r=mstange Differential Revision: https://phabricator.services.mozilla.com/D167997
-
- May 31, 2023
-
-
Emilio Cobos Álvarez authored
It's not clear to me why specializing nsCOMPtr<nsISupports> is particularly useful, and this removes a lot of code, bringing us closer to unifying nsCOMPtr and RefPtr. The changes in other places are needed because we used to allow nsCOMPtr<nsISupports> to implicitly coerce to nsISupports even for rvalue references. 0:47.88 /home/emilio/src/moz/gecko-4/netwerk/protocol/http/nsHttpActivityDistributor.cpp:121:11: error: conversion function from 'nsCOMPtr<nsISupports>' to 'nsISupports *' invokes a deleted function 0:47.88 nsCOMPtr<nsISupports>(do_QueryObject(channel)), aActivityType, 0:47.88 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 0:47.88 /home/emilio/src/moz/gecko-4/obj-debug/dist/include/nsCOMPtr.h:764:3: note: 'operator nsISupports *' has been explicitly marked deleted here 0:47.88 operator T*() const&& = delete; 0:47.88 ^ 0:47.88 /home/emilio/src/moz/gecko-4/netwerk/protocol/http/nsHttpActivityDistributor.cpp:29:57: note: passing argument to parameter 'aHttpChannel' here 0:47.88 nsHttpActivityDistributor::ObserveActivity(nsISupports* aHttpChannel, 0:47.88 ^ Which is not allowed for a good reason, generally. Differential Revision: https://phabricator.services.mozilla.com/D179124
-
Edgar Chen authored
Differential Revision: https://phabricator.services.mozilla.com/D179188
-
Edgar Chen authored
Differential Revision: https://phabricator.services.mozilla.com/D179187
-
Iulian Moraru authored
Backed out changeset 9fce1abd1c50 (bug 1833244) for causing build bustages on nsDeviceContextAndroid.h. CLOSED TREE
-
Jonathan Watt authored
OS print drivers/devices know nothing about page dimensions unless we tell them. Previously, the physical page dimensions (including orientation) have always been the same, so communicating their dimensions once at the start of a print has been enough. In preparation for supporting different "physical" page dimensions (in the immediate future only different page orientations) when we save to PDF, we need to have the infrastructure to pass dimensions through on a page-by-page basis. This patch adds that. None of the PrintTarget subclasses do anything with this extra information yet, but in a follow-up patch PrintTargetPDF will use this information to create PDFs with mixed page orientations. Depends on D179395 Differential Revision: https://phabricator.services.mozilla.com/D179423
-
stransky authored
Differential Revision: https://phabricator.services.mozilla.com/D179529
-
David Turner authored
Add separate options to control whether we build VA-API and/or V4L2 hardware video decode. These options default to enabled on the platforms where these decoders are used. The downstream MOZ_WAYLAND_USE_HWDECODE build option is used within the FFmpeg platform and is only set when building against a supported version of the FFmpeg libraries (i.e. not for ffmpeg57). Differential Revision: https://phabricator.services.mozilla.com/D178945
-
- May 30, 2023
-
-
Mike Hommey authored
Bug 1834945 - Include chromium-config.mozbuild in widget/uikit, to get ipdl headers. r=firefox-build-system-reviewers,nalexander Same as other widgets. Differential Revision: https://phabricator.services.mozilla.com/D179028
-
Ray Kraesig authored
Bug 1704954 disabled DirectComposition for users with NVIDIA graphics hardware and mixed monitor refresh rates on Windows 10 and 11, as a mitigation for bug 1638709. However, that bug is almost -- perhaps entirely -- unknown on Windows 11 (q.v. for details), and the fallback path it uses has been shown to cause issues there (bug 1763981). Restrict the mitigation to only occur on Windows 10, where bug 1638709 is exhibited, but where no issues with the fallback path are known. This also effectively reverts bug 1816001, which it obviates. Differential Revision: https://phabricator.services.mozilla.com/D178848
-
Brad Werth authored
Differential Revision: https://phabricator.services.mozilla.com/D179155
-
Emilio Cobos Álvarez authored
And attach it to the maximized headerbar, not to the regular one. Breeze styles the button with background-image rather than icon-source. Differential Revision: https://phabricator.services.mozilla.com/D179389
-
Emilio Cobos Álvarez authored
To be used by session restore. Differential Revision: https://phabricator.services.mozilla.com/D179110
-
- May 26, 2023
-
-
stransky authored
Differential Revision: https://phabricator.services.mozilla.com/D178760
-
stransky authored
Differential Revision: https://phabricator.services.mozilla.com/D178767
-
Martin Stransky authored
If we set resize cursor on widget level keep it locked and prevent layout to switch it back to default (by synthetic mouse events for instance) until resize is finished. Differential Revision: https://phabricator.services.mozilla.com/D179049
-
Masayuki Nakano authored
It creates no range `Selection` if `mSelection` has not been emplaced. However, we don't want `Selection` in the case because `mText` may be nothing and that violates the dependency. Therefore, it should stop creating `Selection` in the case. Note that first character rect will be cached later even if there is no `Selection`. However, this should not occur in usual case because `focus` notification should've already initialized `mText` and `mSelection`. Differential Revision: https://phabricator.services.mozilla.com/D178731
-
Masayuki Nakano authored
Currently, `PuppetWidget` calls `ContentCacheInChild::CacheSelection` directly. However, `mText` can be `Nothing` or `mText` can be outdated, but `mSelection` becomes the latest one. Therefore, we may notify the parent process with invalid data combination. The callers in `PuppetWidget` are: 1. `NotifyIMEOfCompositionUpdate` 2. `NotifyIMEOfPositionChange` I think that the former does not need to cache anything here because `IMEContentObserver` should've updated the text/selection changes. However, stopping caching everything at this point is risky. In the most cases, outdated data appears as odd IME UI position. Therefore, let's keep updating only caret and text rectangles. The latter is reported with new crash reports which is crashed by a `MOZ_DIAGNOSTIC_ASSERT` failure added by the previous patch. In the case, if `mText` and `mSelection` has not been cached, we don't need to notify the parent process with them because they will be sent later. And also even if they are not available, it may be useful that the character rectangles not related to `Selection` (e.g., the first character rect). Therefore, let's keep caching same things as the former case. Therefore, this patch makes `CacheSelection` a private method and add `CacheCaretAndTextRects` for them. Differential Revision: https://phabricator.services.mozilla.com/D178145
-
Masayuki Nakano authored
There are some crash reports crashed in TSF module which may be caused by passing invalid selection range (e.g., out of bounds of text). However, the cache is created in the child process and that causes the invalid cache creation does not appear in the crash reports. Therefore, let's try to crash as soon as possible if `ContentCache` has invalid data. Note that this does not detect all of the invalid cases because it's hard to (re-)understand the edge cases. Therefore, this tries to detect the cases checked in `ContentCacheInParent::HandleQueryContentEvent` (*1) and some other obvious odd cases. 1. https://searchfox.org/mozilla-central/rev/0ffaecaa075887ab07bf4c607c61ea2faa81b172/widget/ContentCache.cpp#776-778 Differential Revision: https://phabricator.services.mozilla.com/D176747
-
- May 25, 2023
-
-
Brad Werth authored
Bug 1407461 Part 2: Allow hardware acceleration for Windows drivers with mismatched DLL and registry versions in all channels. r=gfx-reviewers,jrmuizel The presence of "DriverVersionMismatch" does not seem to be an outlying indicator in crash reports for Intel 965 Express hardware. This patch allows hardware WebRender in all channels for that hardware, and we'll deal with individual driver bugs as they appear. Differential Revision: https://phabricator.services.mozilla.com/D179147
-
Mike Hommey authored
Bug 1833998 - Switch Firefox builds to macOS 13.3 SDK. r=firefox-build-system-reviewers,sergesanspaille Differential Revision: https://phabricator.services.mozilla.com/D178500
-
- May 24, 2023
-
-
Sandor Molnar authored
-
Sean Feng authored
Bug 1817723 - Allow HTMLEditor can receive events when the focus is switched between elements in the same shadow tree. r=masayuki The EditorEventListener for HTMLEditor is registered on document, which is problematic because it can't receive events when the focus is switched between elements in the same shadow tree due to shadow dom encapsulation. We fix this by moving the EditorEventListener to nsWindowRoot so the events can always be received. Differential Revision: https://phabricator.services.mozilla.com/D178215
-
Emilio Cobos Álvarez authored
Bug 1833403 - Simplify some appearance code. r=stransky,mac-reviewers,handyman,devtools-reviewers,mstange I was looking into simplifying our scrollbar styles: * StyleAppearance::Resizer is not used in content, and some of the values were only for <xul:window> which are not supported anymore. * Statusbarpanel and Resizerpanel aren't used. Statusbar is only used once on macOS so we only need to keep it there. Differential Revision: https://phabricator.services.mozilla.com/D178374
-
Edgar Chen authored
Differential Revision: https://phabricator.services.mozilla.com/D173009
-
Sandor Molnar authored
Backed out changeset e8b6a5dbf398 (bug 1817723) for causing mochitest failures in editor/libeditor/EditorEventListener.cpp CLOSED TREE
-
- May 23, 2023
-
-
Sean Feng authored
Bug 1817723 - Allow HTMLEditor can receive events when the focus is switched between elements in the same shadow tree. r=masayuki The EditorEventListener for HTMLEditor is registered on document, which is problematic because it can't receive events when the focus is switched between elements in the same shadow tree due to shadow dom encapsulation. We fix this by moving the EditorEventListener to nsWindowRoot so the events can always be received. Differential Revision: https://phabricator.services.mozilla.com/D178215
-
Iulian Moraru authored
Backed out changeset f020820671c4 (bug 1833403) for causing reftest failures on resizer-bottomend.xhtml. CLOSED TREE
-
Emilio Cobos Álvarez authored
Bug 1833403 - Simplify some appearance code. r=stransky,mac-reviewers,handyman,devtools-reviewers,mstange I was looking into simplifying our scrollbar styles: * StyleAppearance::Resizer is not used in content, and some of the values were only for <xul:window> which are not supported anymore. * Statusbarpanel and Resizerpanel aren't used. Statusbar is only used once on macOS so we only need to keep it there. Differential Revision: https://phabricator.services.mozilla.com/D178374
-
Emilio Cobos Álvarez authored
Differential Revision: https://phabricator.services.mozilla.com/D178545
-
- May 22, 2023
-
-
Norisz Fay authored
Backed out changeset e2d6154400a7 (bug 1833403) for causing reftest failures on resizer-bottomend.xhtml
-
Butkovits Atila authored
Backed out changeset ff1720f8fc34 (bug 1834042) for causing Android bustages at nsWindow.h. CLOSED TREE
-