Pier Angelo Vendrame authored 1 year ago and ma1 committed 2 months ago

Windows has a system to set font aliases through the registry.
This allows some customization that could be used as a fingerprinting
vector.
Moreover, this mechanism is used by Windows itself, and different SKUs
might have different default FontSubstitutes.

Pier Angelo Vendrame authored 2 years ago and ma1 committed 2 months ago

The mechanism to choose the UI font does not play well with our
fontconfig configuration. As a result, the final criterion to choose
the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use
it also for the UI. FontConfig will fall back to some other font for
scripts Arimo does not cover as expected (we tested with Japanese).

Jonathan Kew authored 10 months ago and ma1 committed 2 months ago

Original Revision: https://phabricator.services.mozilla.com/D208983

Differential Revision: https://phabricator.services.mozilla.com/D209209

Jonathan Kew authored 11 months ago and ma1 committed 2 months ago

Bug 1890204 - Ensure font entry's unitsPerEm and font extents are initialized when gfxFont is created. r=gfx-reviewers,lsalzman

This means that by the time we potentially call GetFontExtents() when drawing,
the extents fields are guaranteed to have been been initialized, and there's no
risk of the (read-only) access here racing with setting them in UnitsPerEm().

Differential Revision: https://phabricator.services.mozilla.com/D206920

Jonathan Kew authored 11 months ago and ma1 committed 2 months ago

Differential Revision: https://phabricator.services.mozilla.com/D206633

Tom Ritter authored 1 year ago and ma1 committed 2 months ago

Differential Revision: https://phabricator.services.mozilla.com/D204571

Bob Owen authored 1 year ago and ma1 committed 2 months ago

This also specializes ElementStreamFormat for bool.

Differential Revision: https://phabricator.services.mozilla.com/D187794

Pier Angelo Vendrame authored 10 months ago and ma1 committed 2 months ago

System fonts can leak any user customization of system fonts, or user's
locale (e.g., en-US and ja Windows have different system fonts).
Also, Linux distributions/desktop environments set default fonts in
different ways.

Customization can be detected either with font metrics, the font allowed
list is not enabled or the font is included in it, or with
getComputedStyle, that leaks the name of the font that Firefox tries to
apply.

This patch try to prevent these leaks by using a generic "sans-serif"
for all system fonts, except on macOS, where it uses "-apple-system",
and on Android, where these fonts always use Roboto.

Differential Revision: https://phabricator.services.mozilla.com/D163576

Bug 1923741 - Add telemetry to measure how many users have read only system temporary folders. a=RyanVM

Original Revision: https://phabricator.services.mozilla.com/D225139

Differential Revision: https://phabricator.services.mozilla.com/D225730

Microsoft TTD has a CPU emulation bug that makes Firefox crash when ran
under TTD. This patch mitigates the issue.

Original Revision: https://phabricator.services.mozilla.com/D220829

Differential Revision: https://phabricator.services.mozilla.com/D221937

Original Revision: https://phabricator.services.mozilla.com/D218019

Differential Revision: https://phabricator.services.mozilla.com/D218214

A change in the latest version of binutils broke building pixman for arm.

The binutils change:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=226749d5a6ff0d5c607d6428d6c81e1e7e7a994b

This change was committed upstream in
https://gitlab.freedesktop.org/pixman/pixman/-/commit/865e6ce00bb79a6b925ed4c2c436e1533e4472aa
and will be in the next release.

Original Revision: https://phabricator.services.mozilla.com/D217517

Differential Revision: https://phabricator.services.mozilla.com/D217541

Differential Revision: https://phabricator.services.mozilla.com/D215368

Bug 1888340 - [angle] Cherry-pick to "Add GLSL variable byte size limits to ShBuiltInResources." r=lsalzman a=RyanVM

Differential Revision: https://phabricator.services.mozilla.com/D215451

When we reset the dirty rect to PictureRect::zero() on a Tile, we must
also mark the Tile as valid. This prevents the propagation of zero-area
rectangles which can otherwise ultimately cause BeginDraw failures.

Differential Revision: https://phabricator.services.mozilla.com/D209340

Before setting or reading from the variable indicating a scrolling axis
is locked, acquire a lock.

Original Revision: https://phabricator.services.mozilla.com/D210965

Differential Revision: https://phabricator.services.mozilla.com/D213973

We only need this on ARM32 because the ARM64 intrinsics are stable.

stdarch_arm_neon_intrinsics was split out from stdsimd here:
https://github.com/rust-lang/stdarch/pull/1486

Differential Revision: https://phabricator.services.mozilla.com/D203039

Original Revision: https://phabricator.services.mozilla.com/D208657

Differential Revision: https://phabricator.services.mozilla.com/D208837

Original Revision: https://phabricator.services.mozilla.com/D208556

Differential Revision: https://phabricator.services.mozilla.com/D208836

Original Revision: https://phabricator.services.mozilla.com/D203973

Differential Revision: https://phabricator.services.mozilla.com/D206555

Differential Revision: https://phabricator.services.mozilla.com/D205993

Original Revision: https://phabricator.services.mozilla.com/D204918

Differential Revision: https://phabricator.services.mozilla.com/D206179

Bug 1874489 - patch 2 - Avoid potential arithmetic overflow during Buffer read operations.  a=RyanVM

Original Revision: https://phabricator.services.mozilla.com/D204917

Differential Revision: https://phabricator.services.mozilla.com/D206178

This is just https://github.com/khaledhosny/ots/pull/277 from upstream, not really part
of this issue but touching the same code, so simplest to include it here.

Original Revision: https://phabricator.services.mozilla.com/D204916

Differential Revision: https://phabricator.services.mozilla.com/D206096

So as to not change load timing from stylo threads.

Differential Revision: https://phabricator.services.mozilla.com/D203927

Bug 1879825 - Make Family::FindIndex fallible and safely handle failures. r=gfx-reviewers,lsalzman, a=dsmith

Differential Revision: https://phabricator.services.mozilla.com/D201819

Bug 1855686 - [bug 1877341 on esr115] Reset GLContext TLS current-context caching when calling library MakeCurrent symbols.  a=RyanVM

Original Revision: https://phabricator.services.mozilla.com/D200866

Differential Revision: https://phabricator.services.mozilla.com/D201001

Differential Revision: https://phabricator.services.mozilla.com/D199380

The DirectWrite "bold simulation" has poor results with some fonts;
we already disable it by default for webfonts, to avoid rendering
issues.

As it also works poorly with some of the component layers in Segoe UI
Emoji, let's disable it for COLR fonts as well.

Bug 1878182 - Instantiate Cairo scaled font for ScaledFontBase::GetPathForGlyphs. r=jfkthameApproved for 123 beta 8, thanks. a=pascalc

This bug likely dates back to bug 1584268, which makes it so that Cairo scaled fonts must be
instantiated on demand for their first use. It seems like some StrokeGlyphs machinery got
overlooked and somehow never caused a problem till now.

Differential Revision: https://phabricator.services.mozilla.com/D200472

Differential Revision: https://phabricator.services.mozilla.com/D200784

Original Revision: https://phabricator.services.mozilla.com/D199035

Differential Revision: https://phabricator.services.mozilla.com/D199374

Differential Revision: https://phabricator.services.mozilla.com/D198163

Differential Revision: https://phabricator.services.mozilla.com/D198046

Differential Revision: https://phabricator.services.mozilla.com/D198114

Original Revision: https://phabricator.services.mozilla.com/D192039

Differential Revision: https://phabricator.services.mozilla.com/D195330

Original Revision: https://phabricator.services.mozilla.com/D194368

Differential Revision: https://phabricator.services.mozilla.com/D194434

Bug 1721612 - Fix AdjustAdvancesForSyntheticBold to reliably handle negative adjustments. r=gfx-reviewers,lsalzman a=RyanVM

This method (as its name suggests) was originally created to handle synthetic-bold,
which only ever increases the advance, and so its use of an unsigned value for the
adjustment worked ok.

But when applying tracking, the adjustment may be negative, and assigning this to
a uint32_t value takes us into undefined-behavior territory. It seems this worked
"as expected" on x86_64 (using modulo arithmetic), but on arm64 the value just
clamped to zero, and the intended negative tracking doesn't get applied.

Making it an int32_t results in consistent behavior across both architectures.

Differential Revision: https://phabricator.services.mozilla.com/D193288