Pier Angelo Vendrame authored 1 year ago and ma1 committed 2 months ago

Firefox strings use { -brand-product-name }.
As a result, it seems that the fork is recommending extensions, whereas
AMO curators are doing that.
So, we replace the strings with custom ones that clarify that Mozilla is
recommending them.

We assign the strings with JS because our translation backend does not
support Fluent attributes, yet, but once it does, we should switch to
them, instead.

Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033

Allows moz-support-link to have data-l10n-name assigned to it via
Fluent file without overwriting the data-l10n-name attribute.

Differential Revision: https://phabricator.services.mozilla.com/D183418

Bug 1814424 - Use moz-support-link for the helpButton link in preferences.xhtml r=tgiles,settings-reviewers,Gijs, a=dsmith

Differential Revision: https://phabricator.services.mozilla.com/D179849

Differential Revision: https://phabricator.services.mozilla.com/D173620

Backed out changeset 8640c4a18d9e (bug 1814261)
Backed out changeset c00c8fc88dbd (bug 1814261)

Differential Revision: https://phabricator.services.mozilla.com/D173620

Backed out changeset fb7b697636ae (bug 1814266)
Backed out changeset 7e5ac07b53d9 (bug 1814266)

Bug 1814266 - Use moz-support-link for the "identify-popup-custom-root-learn-more" label. r=tgiles,flod

Differential Revision: https://phabricator.services.mozilla.com/D173701

The moz-support-link was initially designed for in-content use.
Since there are places where this component can be used in chrome, we
need to add the ability for this widget to open links when used in the
chrome.

Differential Revision: https://phabricator.services.mozilla.com/D170253

Bug 1812098 - Fix ESLint raised issues with no-shadow of builtinGlobals in toolkit .mjs files. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D169462

Differential Revision: https://phabricator.services.mozilla.com/D171549

This is still far from perfect given the limitations of the Storybook web components package, but I figured this was worth putting up since it's still an improvement over the current state of our args tables (I think).

I'm mostly leaving the default generated `custom-elements-manifest.json` alone save for filtering some internal properties we don't want documented since they shouldn't really be accessed directly. If it seems too strange to just have the `aria-label` attr documented we could possibly remove `attributes` from the docs for now (this happens because it's the only attr where the name is different from the property name).

Open to feedback/thoughts on if this is useful or too wonky for now given the weirdness around how Storybook creates naming collisions.

Differential Revision: https://phabricator.services.mozilla.com/D162599

This adds the <moz-support-link> custom element as well as stories and
tests for this reusable component. The purpose of this component is to
replace individual implementations of the "Learn more" links present
in Firefox, specifically in about:preferences and about:addons.

See Bug 1801927 for an instance of using this component to refactor
the "Learn more" links in about:preferences#general.

Differential Revision: https://phabricator.services.mozilla.com/D164131