Skip to content
Snippets Groups Projects
  1. Apr 20, 2023
  2. Jan 26, 2023
  3. Oct 26, 2020
    • Ricky Stewart's avatar
      Bug 1654103: Standardize on Black for Python code in `mozilla-central`. · 02a7b4eb
      Ricky Stewart authored
      Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
      
      To produce this patch I did all of the following:
      
      1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
      
      2. Run ./mach lint --linter black --fix
      
      3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
      
      4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
      
      5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
      
      # ignore-this-changeset
      
      Differential Revision: https://phabricator.services.mozilla.com/D94045
      02a7b4eb
  4. Oct 24, 2020
    • Bogdan Tara's avatar
      Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for... · da1098d4
      Bogdan Tara authored
      Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
      
      Backed out changeset ff3fb0b4a512 (bug 1672023)
      Backed out changeset e7834b600201 (bug 1654103)
      Backed out changeset 807893ca8069 (bug 1518999)
      Backed out changeset 13e6b92440e9 (bug 1518999)
      Backed out changeset 8b2ac5a6c98a (bug 1518999)
      Backed out changeset 575748295752 (bug 1518999)
      Backed out changeset 65f07ce7b39b (bug 1518999)
      Backed out changeset 4bb80556158d (bug 1518999)
      Backed out changeset 8ac8461d7bd7 (bug 1518999)
      Backed out changeset e8ba13ee17f5 (bug 1518999)
      da1098d4
  5. Oct 23, 2020
    • Ricky Stewart's avatar
      Bug 1654103: Standardize on Black for Python code in `mozilla-central`.... · c0cea3b0
      Ricky Stewart authored
      Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
      
      Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
      
      To produce this patch I did all of the following:
      
      1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
      
      2. Run ./mach lint --linter black --fix
      
      3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
      
      4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
      
      5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
      
      # ignore-this-changeset
      
      Differential Revision: https://phabricator.services.mozilla.com/D94045
      c0cea3b0
  6. Oct 22, 2020
  7. Oct 21, 2020
    • Ricky Stewart's avatar
      Bug 1654103: Standardize on Black for Python code in `mozilla-central`.... · 50762dac
      Ricky Stewart authored
      Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
      
      Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
      
      To produce this patch I did all of the following:
      
      1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
      
      2. Run ./mach lint --linter black --fix
      
      3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
      
      4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
      
      # ignore-this-changeset
      
      Differential Revision: https://phabricator.services.mozilla.com/D94045
      50762dac
  8. Jun 26, 2020
  9. Jun 24, 2020
  10. Jun 23, 2020
  11. Jun 01, 2020
  12. Mar 12, 2020
    • Ricky Stewart's avatar
      Bug 1619460 - ensure subsequent runs of `./mach build-backend` under Python 3... · 13aa77e4
      Ricky Stewart authored
      Bug 1619460 - ensure subsequent runs of `./mach build-backend` under Python 3 produce consistent results r=dmajor
      
      Dictionary iteration under Python 3 is in an inherently unpredictable order, and while we try to keep DEFINES ordered through the use of OrderedDicts, if at any point we populate DEFINES directly or indirectly while iterating through the contents of a non-ordered dictionary, the order of the DEFINES (and therefore the contents of the output Makefile) will be nondeterministic as well. This patch makes a number of changes to ensure that we only ever populate DEFINES in a deterministic fashion. (Note that in Python 3.7 and later, the built-in dict class actually has deterministic ordering, so these changes are technically only necessary until our minimum Python version becomes 3.7.)
      
      Differential Revision: https://phabricator.services.mozilla.com/D66089
      
      --HG--
      extra : moz-landing-system : lando
      13aa77e4
    • Narcis Beleuzu's avatar
      Backed out changeset 1f0cfca78242 (bug 1619460) perf regression in automation,... · 4437350f
      Narcis Beleuzu authored
      Backed out changeset 1f0cfca78242 (bug 1619460) perf regression in automation, req by rstewart. CLOSED TREE
      
      --HG--
      extra : rebase_source : ef3f1ce03bc9fdedb81d33ede68f9925f447ba32
      4437350f
  13. Mar 09, 2020
    • Ricky Stewart's avatar
      Bug 1619460 - ensure subsequent runs of `./mach build-backend` under Python 3... · 5a390340
      Ricky Stewart authored
      Bug 1619460 - ensure subsequent runs of `./mach build-backend` under Python 3 produce consistent results r=dmajor
      
      Dictionary iteration under Python 3 is in an inherently unpredictable order, and while we try to keep DEFINES ordered through the use of OrderedDicts, if at any point we populate DEFINES directly or indirectly while iterating through the contents of a non-ordered dictionary, the order of the DEFINES (and therefore the contents of the output Makefile) will be nondeterministic as well. This patch makes a number of changes to ensure that we only ever populate DEFINES in a deterministic fashion. (Note that in Python 3.7 and later, the built-in dict class actually has deterministic ordering, so these changes are technically only necessary until our minimum Python version becomes 3.7.)
      
      Differential Revision: https://phabricator.services.mozilla.com/D66089
      
      --HG--
      extra : moz-landing-system : lando
      5a390340
  14. Feb 21, 2020
  15. Feb 20, 2020
  16. Feb 14, 2020
    • Mike Shal's avatar
      Bug 1611326 - Default to py3_action, and add a py2 attribute to... · d8e4653d
      Mike Shal authored
      Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
      
      GENERATED_FILES now defaults to python3 unless py2=True is specified as
      an argument. All existing GENERATED_FILES scripts and GeneratedFile
      templates have the py2=True attribute added, so this patch should
      effectively be a no-op.
      
      Going forward, individual scripts can be converted to python3 and their
      corresponding py2=True attribute can be deleted. In effect, this patch
      will be backed out in pieces until all scripts run in python3, at which
      point the py2 attribute itself can be removed.
      
      Differential Revision: https://phabricator.services.mozilla.com/D60919
      
      --HG--
      extra : moz-landing-system : lando
      d8e4653d
    • Cosmin Sabou's avatar
      Backed out 2 changesets (bug 1613263, bug 1611326) for presummably causing... · ff39f920
      Cosmin Sabou authored
      Backed out 2 changesets (bug 1613263, bug 1611326) for presummably causing l10n langpack bustages. a=backout
      
      Backed out changeset 77e54e76848a (bug 1611326)
      Backed out changeset 36ba18ac3a68 (bug 1613263)
      ff39f920
  17. Feb 13, 2020
    • Mike Shal's avatar
      Bug 1611326 - Default to py3_action, and add a py2 attribute to... · ad0c283a
      Mike Shal authored
      Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
      
      GENERATED_FILES now defaults to python3 unless py2=True is specified as
      an argument. All existing GENERATED_FILES scripts and GeneratedFile
      templates have the py2=True attribute added, so this patch should
      effectively be a no-op.
      
      Going forward, individual scripts can be converted to python3 and their
      corresponding py2=True attribute can be deleted. In effect, this patch
      will be backed out in pieces until all scripts run in python3, at which
      point the py2 attribute itself can be removed.
      
      Differential Revision: https://phabricator.services.mozilla.com/D60919
      
      --HG--
      extra : moz-landing-system : lando
      ad0c283a
    • Brindusan Cristian's avatar
      Backed out changeset 7fefed11f117 (bug 1611326) for build bustages at... · e2fb6b83
      Brindusan Cristian authored
      Backed out changeset 7fefed11f117 (bug 1611326) for build bustages at update-1.xpi.stub. CLOSED TREE
      e2fb6b83
    • Mike Shal's avatar
      Bug 1611326 - Default to py3_action, and add a py2 attribute to... · e6464dd4
      Mike Shal authored
      Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
      
      GENERATED_FILES now defaults to python3 unless py2=True is specified as
      an argument. All existing GENERATED_FILES scripts and GeneratedFile
      templates have the py2=True attribute added, so this patch should
      effectively be a no-op.
      
      Going forward, individual scripts can be converted to python3 and their
      corresponding py2=True attribute can be deleted. In effect, this patch
      will be backed out in pieces until all scripts run in python3, at which
      point the py2 attribute itself can be removed.
      
      Differential Revision: https://phabricator.services.mozilla.com/D60919
      
      --HG--
      extra : moz-landing-system : lando
      e6464dd4
  18. Dec 12, 2019
  19. Oct 07, 2019
  20. Feb 14, 2019
    • Mike Hommey's avatar
      Bug 1512504 - Remove support for MSVC. r=froydnj · ef3ad686
      Mike Hommey authored
      Consequently, this removes:
      - MOZ_LIBPRIO, which is now always enabled.
      - non_msvc_compiler, which is now always true.
      - The cl.py wrapper, since it's not used anymore.
      - CL_INCLUDES_PREFIX, which was only used for the cl.py wrapper.
      - NONASCII, which was only there to ensure CL_INCLUDES_PREFIX still
        worked in non-ASCII cases.
      
      This however keeps a large part of detecting and configuring for MSVC,
      because we still do need it for at least headers, libraries, and midl.
      
      Depends on D19614
      
      Differential Revision: https://phabricator.services.mozilla.com/D19615
      
      --HG--
      extra : moz-landing-system : lando
      ef3ad686
  21. Nov 28, 2018
    • arthur.iakab's avatar
      Backed out 13 changesets (bug 1500948, bug 1509362, bug 1509591, bug 1448426,... · af07f9b9
      arthur.iakab authored
      Backed out 13 changesets (bug 1500948, bug 1509362, bug 1509591, bug 1448426, bug 1500949, bug 1487249, bug 1509930, bug 1500950, bug 1500944) for causing crashes and assertion failures on PBackgroundParent.cpp:696 CLOSED TREE
      
      Backed out changeset c3fe435e473a (bug 1509362)
      Backed out changeset 6494840edc17 (bug 1509591)
      Backed out changeset 123b5d5a3637 (bug 1509591)
      Backed out changeset bce195f98895 (bug 1509930)
      Backed out changeset 66db13126408 (bug 1500950)
      Backed out changeset 3b5fffae2d2b (bug 1500949)
      Backed out changeset 71c3b3677db8 (bug 1500948)
      Backed out changeset 784b3b56e2ab (bug 1500944)
      Backed out changeset 0bad27401ddb (bug 1500944)
      Backed out changeset e0f95dd96d54 (bug 1448426)
      Backed out changeset c60fa11538db (bug 1487249)
      Backed out changeset 0190d4ffa54f (bug 1487249)
      Backed out changeset 3cd10aba9130 (bug 1487249)
      af07f9b9
  22. Nov 27, 2018
    • Nika Layzell's avatar
      Bug 1448426 - Wrap windows.h to avoid problematic define statements, r=froydnj,glandium · 9f648dce
      Nika Layzell authored
      By default, windows.h exposes a large number of problematic define statements
      which are UpperCamelCase, such as a define from `CreateWindow` to
      `CreateWindow{A,W}`.
      
      As many of these names are generic (e.g. CreateFile, CreateWindow), they can
      mess up Gecko code that may legitimately have its own methods with the same
      names.
      
      The header also defines some traditional SCREAMING_SNAKE_CASE defines which
      can mess up our code by conflicting with local values.
      
      This patch adds a simple code generator which generates wrappers for these
      defines, and uses them to wrap the windows.h wrapper using the `stl_wrappers`
      mechanism, allowing us to use windows.h in more places.
      
      Differential Revision: https://phabricator.services.mozilla.com/D10932
      9f648dce
  23. Nov 22, 2018
    • arthur.iakab's avatar
      Backed out 9 changesets (bug 1500948, bug 1500949, bug 1448426, bug 1487249,... · 14322dd0
      arthur.iakab authored
      Backed out 9 changesets (bug 1500948, bug 1500949, bug 1448426, bug 1487249, bug 1500950, bug 1500944) for causing talos crashes on  ts_paint | application crashed [@ MOZ_CrashOOL(char const*, int, char const*)]
      
      Backed out changeset 429776feea6b (bug 1500950)
      Backed out changeset a300e9ae7a01 (bug 1500949)
      Backed out changeset fed1a518579a (bug 1500948)
      Backed out changeset a71376319ad7 (bug 1500944)
      Backed out changeset 9c5c35cb10aa (bug 1500944)
      Backed out changeset b6c97b4db60a (bug 1448426)
      Backed out changeset 160a1dbe0be5 (bug 1487249)
      Backed out changeset 8caf55928df2 (bug 1487249)
      Backed out changeset 176131b18cb4 (bug 1487249)
      14322dd0
    • Nika Layzell's avatar
      Bug 1448426 - Wrap windows.h to avoid problematic define statements, r=froydnj,glandium · b6ea50e3
      Nika Layzell authored
      By default, windows.h exposes a large number of problematic define statements
      which are UpperCamelCase, such as a define from `CreateWindow` to
      `CreateWindow{A,W}`.
      
      As many of these names are generic (e.g. CreateFile, CreateWindow), they can
      mess up Gecko code that may legitimately have its own methods with the same
      names.
      
      The header also defines some traditional SCREAMING_SNAKE_CASE defines which
      can mess up our code by conflicting with local values.
      
      This patch adds a simple code generator which generates wrappers for these
      defines, and uses them to wrap the windows.h wrapper using the `stl_wrappers`
      mechanism, allowing us to use windows.h in more places.
      
      Differential Revision: https://phabricator.services.mozilla.com/D10932
      b6ea50e3
  24. Nov 28, 2018
    • Nika Layzell's avatar
      Bug 1448426 - Wrap windows.h to avoid problematic define statements, r=froydnj,glandium · 568787b9
      Nika Layzell authored
      By default, windows.h exposes a large number of problematic define statements
      which are UpperCamelCase, such as a define from `CreateWindow` to
      `CreateWindow{A,W}`.
      
      As many of these names are generic (e.g. CreateFile, CreateWindow), they can
      mess up Gecko code that may legitimately have its own methods with the same
      names.
      
      The header also defines some traditional SCREAMING_SNAKE_CASE defines which
      can mess up our code by conflicting with local values.
      
      This patch adds a simple code generator which generates wrappers for these
      defines, and uses them to wrap the windows.h wrapper using the `stl_wrappers`
      mechanism, allowing us to use windows.h in more places.
      
      Differential Revision: https://phabricator.services.mozilla.com/D10932
      568787b9
  25. Sep 07, 2018
Loading