- Apr 20, 2023
-
-
Mike Hommey authored
Bug 1828577 - Properly set *-stl-wrapper.template.h as an input to the make-stl-wrappers script. r=firefox-build-system-reviewers,ahochheiden Differential Revision: https://phabricator.services.mozilla.com/D175734
-
- Jan 26, 2023
-
-
Mike Hommey authored
Differential Revision: https://phabricator.services.mozilla.com/D167879
-
Stanca Serban authored
-
Mike Hommey authored
Differential Revision: https://phabricator.services.mozilla.com/D167879
-
- Oct 26, 2020
-
-
Ricky Stewart authored
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly. To produce this patch I did all of the following: 1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions. 2. Run ./mach lint --linter black --fix 3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks. 4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat. 5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023). # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D94045
-
- Oct 24, 2020
-
-
Bogdan Tara authored
Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE Backed out changeset ff3fb0b4a512 (bug 1672023) Backed out changeset e7834b600201 (bug 1654103) Backed out changeset 807893ca8069 (bug 1518999) Backed out changeset 13e6b92440e9 (bug 1518999) Backed out changeset 8b2ac5a6c98a (bug 1518999) Backed out changeset 575748295752 (bug 1518999) Backed out changeset 65f07ce7b39b (bug 1518999) Backed out changeset 4bb80556158d (bug 1518999) Backed out changeset 8ac8461d7bd7 (bug 1518999) Backed out changeset e8ba13ee17f5 (bug 1518999)
-
- Oct 23, 2020
-
-
Ricky Stewart authored
Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly. To produce this patch I did all of the following: 1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions. 2. Run ./mach lint --linter black --fix 3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks. 4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat. 5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023). # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D94045
-
- Oct 22, 2020
-
-
Dorel Luca authored
-
- Oct 21, 2020
-
-
Ricky Stewart authored
Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly. To produce this patch I did all of the following: 1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions. 2. Run ./mach lint --linter black --fix 3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks. 4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023). # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D94045
-
- Jun 26, 2020
-
-
Emilio Cobos Álvarez authored
Differential Revision: https://phabricator.services.mozilla.com/D80360
-
- Jun 24, 2020
-
-
Mike Hommey authored
Bug 1645986 - Avoid relative paths in GeneratedFile targets. r=firefox-build-system-reviewers,rstewart Differential Revision: https://phabricator.services.mozilla.com/D80605
-
Dorel Luca authored
Backed out changeset 602ea804234f (bug 1645986) Backed out changeset c43f9360b0a5 (bug 1645986) Backed out changeset fe1142397e72 (bug 1645986) Backed out changeset faf6de9409f9 (bug 1645986)
-
Mike Hommey authored
Bug 1645986 - Avoid relative paths in GeneratedFile targets. r=firefox-build-system-reviewers,rstewart Differential Revision: https://phabricator.services.mozilla.com/D80605
-
Dorel Luca authored
Backed out changeset ac871b2f34dc (bug 1645986) Backed out changeset 07b14b6a0b91 (bug 1645986) Backed out changeset fdd319bdbfa7 (bug 1645986) Backed out changeset ce213e6bbc1f (bug 1645986)
-
- Jun 23, 2020
-
-
Mike Hommey authored
Bug 1645986 - Avoid relative paths in GeneratedFile targets. r=firefox-build-system-reviewers,rstewart Differential Revision: https://phabricator.services.mozilla.com/D80605
-
- Jun 01, 2020
-
-
Ricky Stewart authored
Bug 1641693 - Replace a bunch of uses of `GENERATED_FILES` with the `GeneratedFile` template r=necko-reviewers,geckoview-reviewers,aklotz,dragana,froydnj Also update documentation to suggest using the `GeneratedFile` template rather than directly referencing `GENERATED_FILES` where possible. Differential Revision: https://phabricator.services.mozilla.com/D77496
-
- Mar 12, 2020
-
-
Ricky Stewart authored
Bug 1619460 - ensure subsequent runs of `./mach build-backend` under Python 3 produce consistent results r=dmajor Dictionary iteration under Python 3 is in an inherently unpredictable order, and while we try to keep DEFINES ordered through the use of OrderedDicts, if at any point we populate DEFINES directly or indirectly while iterating through the contents of a non-ordered dictionary, the order of the DEFINES (and therefore the contents of the output Makefile) will be nondeterministic as well. This patch makes a number of changes to ensure that we only ever populate DEFINES in a deterministic fashion. (Note that in Python 3.7 and later, the built-in dict class actually has deterministic ordering, so these changes are technically only necessary until our minimum Python version becomes 3.7.) Differential Revision: https://phabricator.services.mozilla.com/D66089 --HG-- extra : moz-landing-system : lando
-
Narcis Beleuzu authored
Backed out changeset 1f0cfca78242 (bug 1619460) perf regression in automation, req by rstewart. CLOSED TREE --HG-- extra : rebase_source : ef3f1ce03bc9fdedb81d33ede68f9925f447ba32
-
- Mar 09, 2020
-
-
Ricky Stewart authored
Bug 1619460 - ensure subsequent runs of `./mach build-backend` under Python 3 produce consistent results r=dmajor Dictionary iteration under Python 3 is in an inherently unpredictable order, and while we try to keep DEFINES ordered through the use of OrderedDicts, if at any point we populate DEFINES directly or indirectly while iterating through the contents of a non-ordered dictionary, the order of the DEFINES (and therefore the contents of the output Makefile) will be nondeterministic as well. This patch makes a number of changes to ensure that we only ever populate DEFINES in a deterministic fashion. (Note that in Python 3.7 and later, the built-in dict class actually has deterministic ordering, so these changes are technically only necessary until our minimum Python version becomes 3.7.) Differential Revision: https://phabricator.services.mozilla.com/D66089 --HG-- extra : moz-landing-system : lando
-
- Feb 21, 2020
-
-
Mike Shal authored
Bug 1616630 - Use py3_action for GENERATED_FILES that already support it; r=firefox-build-system-reviewers,kvark,rstewart Differential Revision: https://phabricator.services.mozilla.com/D63438 --HG-- extra : moz-landing-system : lando
-
- Feb 20, 2020
-
-
Csoregi Natalia authored
Backed out changeset 15016546c954 (bug 1616630) Backed out changeset dcb7dc51633b (bug 1616630)
-
Mike Shal authored
Bug 1616630 - Use py3_action for GENERATED_FILES that already support it; r=firefox-build-system-reviewers,kvark,rstewart Depends on D63437 Differential Revision: https://phabricator.services.mozilla.com/D63438 --HG-- extra : moz-landing-system : lando
-
- Feb 14, 2020
-
-
Mike Shal authored
Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart GENERATED_FILES now defaults to python3 unless py2=True is specified as an argument. All existing GENERATED_FILES scripts and GeneratedFile templates have the py2=True attribute added, so this patch should effectively be a no-op. Going forward, individual scripts can be converted to python3 and their corresponding py2=True attribute can be deleted. In effect, this patch will be backed out in pieces until all scripts run in python3, at which point the py2 attribute itself can be removed. Differential Revision: https://phabricator.services.mozilla.com/D60919 --HG-- extra : moz-landing-system : lando
-
Cosmin Sabou authored
Backed out 2 changesets (bug 1613263, bug 1611326) for presummably causing l10n langpack bustages. a=backout Backed out changeset 77e54e76848a (bug 1611326) Backed out changeset 36ba18ac3a68 (bug 1613263)
-
- Feb 13, 2020
-
-
Mike Shal authored
Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart GENERATED_FILES now defaults to python3 unless py2=True is specified as an argument. All existing GENERATED_FILES scripts and GeneratedFile templates have the py2=True attribute added, so this patch should effectively be a no-op. Going forward, individual scripts can be converted to python3 and their corresponding py2=True attribute can be deleted. In effect, this patch will be backed out in pieces until all scripts run in python3, at which point the py2 attribute itself can be removed. Differential Revision: https://phabricator.services.mozilla.com/D60919 --HG-- extra : moz-landing-system : lando
-
Brindusan Cristian authored
Backed out changeset 7fefed11f117 (bug 1611326) for build bustages at update-1.xpi.stub. CLOSED TREE
-
Mike Shal authored
Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart GENERATED_FILES now defaults to python3 unless py2=True is specified as an argument. All existing GENERATED_FILES scripts and GeneratedFile templates have the py2=True attribute added, so this patch should effectively be a no-op. Going forward, individual scripts can be converted to python3 and their corresponding py2=True attribute can be deleted. In effect, this patch will be backed out in pieces until all scripts run in python3, at which point the py2 attribute itself can be removed. Differential Revision: https://phabricator.services.mozilla.com/D60919 --HG-- extra : moz-landing-system : lando
-
- Dec 12, 2019
-
-
Tom Ritter authored
Turns out we were using the Linux ones. This uses the Windows ones, and adds _HAS_EXCEPTIONS to the mingw defines so the stl_wrappers behave correctly. Differential Revision: https://phabricator.services.mozilla.com/D54530 --HG-- extra : moz-landing-system : lando
-
Andreea Pavel authored
Backed out changeset 2ac8dd1d709d (bug 1590624) Backed out changeset 8432398c212a (bug 1590624) Backed out changeset 2b28154aacdb (bug 1590624) Backed out changeset d305e4160ee4 (bug 1590624) --HG-- rename : build/build-clang/clang-9-mingw.json => build/build-clang/clang-8-mingw.json rename : taskcluster/scripts/misc/build-clang-mingw.sh => taskcluster/scripts/misc/build-clang-8-mingw.sh
-
Tom Ritter authored
Turns out we were using the Linux ones. This uses the Windows ones, and adds _HAS_EXCEPTIONS to the mingw defines so the stl_wrappers behave correctly. Differential Revision: https://phabricator.services.mozilla.com/D54530 --HG-- extra : moz-landing-system : lando
-
- Oct 07, 2019
-
-
Ricky Stewart authored
Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=firefox-build-system-reviewers,mshal (Same content as bad revision https://phabricator.services.mozilla.com/D48230, but with a very small change to config/external/icu/data/moz.build to fix the build breakage.) Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=833f6a69fcac689488a640b43e8e0bdaa086a56c Differential Revision: https://phabricator.services.mozilla.com/D48409 --HG-- extra : moz-landing-system : lando
-
Daniel Varga authored
Backed out changeset 8d95f2c8867b (bug 1586358) for build bustage with FATAL ERROR PROCESSING MOZBUILD FILE. On a CLOSED TREE --HG-- extra : rebase_source : 325fbad2455afc7f693087e75fa57dba79f4d86b
-
Ricky Stewart authored
Bug 1586358 - Replace existing instances of GENERATED_FILES with references to the GeneratedFile template r=nalexander This patch doesn't remove all references to GENERATED_FILES, but does remove most of them, leaving only those which can't be trivially translated to the new template. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4a25230c3992b9c5519ceb351fb37f6b2bf605e Differential Revision: https://phabricator.services.mozilla.com/D48230 --HG-- extra : moz-landing-system : lando
-
- Feb 14, 2019
-
-
Mike Hommey authored
Consequently, this removes: - MOZ_LIBPRIO, which is now always enabled. - non_msvc_compiler, which is now always true. - The cl.py wrapper, since it's not used anymore. - CL_INCLUDES_PREFIX, which was only used for the cl.py wrapper. - NONASCII, which was only there to ensure CL_INCLUDES_PREFIX still worked in non-ASCII cases. This however keeps a large part of detecting and configuring for MSVC, because we still do need it for at least headers, libraries, and midl. Depends on D19614 Differential Revision: https://phabricator.services.mozilla.com/D19615 --HG-- extra : moz-landing-system : lando
-
- Nov 28, 2018
-
-
arthur.iakab authored
Backed out 13 changesets (bug 1500948, bug 1509362, bug 1509591, bug 1448426, bug 1500949, bug 1487249, bug 1509930, bug 1500950, bug 1500944) for causing crashes and assertion failures on PBackgroundParent.cpp:696 CLOSED TREE Backed out changeset c3fe435e473a (bug 1509362) Backed out changeset 6494840edc17 (bug 1509591) Backed out changeset 123b5d5a3637 (bug 1509591) Backed out changeset bce195f98895 (bug 1509930) Backed out changeset 66db13126408 (bug 1500950) Backed out changeset 3b5fffae2d2b (bug 1500949) Backed out changeset 71c3b3677db8 (bug 1500948) Backed out changeset 784b3b56e2ab (bug 1500944) Backed out changeset 0bad27401ddb (bug 1500944) Backed out changeset e0f95dd96d54 (bug 1448426) Backed out changeset c60fa11538db (bug 1487249) Backed out changeset 0190d4ffa54f (bug 1487249) Backed out changeset 3cd10aba9130 (bug 1487249)
-
- Nov 27, 2018
-
-
Nika Layzell authored
By default, windows.h exposes a large number of problematic define statements which are UpperCamelCase, such as a define from `CreateWindow` to `CreateWindow{A,W}`. As many of these names are generic (e.g. CreateFile, CreateWindow), they can mess up Gecko code that may legitimately have its own methods with the same names. The header also defines some traditional SCREAMING_SNAKE_CASE defines which can mess up our code by conflicting with local values. This patch adds a simple code generator which generates wrappers for these defines, and uses them to wrap the windows.h wrapper using the `stl_wrappers` mechanism, allowing us to use windows.h in more places. Differential Revision: https://phabricator.services.mozilla.com/D10932
-
- Nov 22, 2018
-
-
arthur.iakab authored
Backed out 9 changesets (bug 1500948, bug 1500949, bug 1448426, bug 1487249, bug 1500950, bug 1500944) for causing talos crashes on ts_paint | application crashed [@ MOZ_CrashOOL(char const*, int, char const*)] Backed out changeset 429776feea6b (bug 1500950) Backed out changeset a300e9ae7a01 (bug 1500949) Backed out changeset fed1a518579a (bug 1500948) Backed out changeset a71376319ad7 (bug 1500944) Backed out changeset 9c5c35cb10aa (bug 1500944) Backed out changeset b6c97b4db60a (bug 1448426) Backed out changeset 160a1dbe0be5 (bug 1487249) Backed out changeset 8caf55928df2 (bug 1487249) Backed out changeset 176131b18cb4 (bug 1487249)
-
Nika Layzell authored
By default, windows.h exposes a large number of problematic define statements which are UpperCamelCase, such as a define from `CreateWindow` to `CreateWindow{A,W}`. As many of these names are generic (e.g. CreateFile, CreateWindow), they can mess up Gecko code that may legitimately have its own methods with the same names. The header also defines some traditional SCREAMING_SNAKE_CASE defines which can mess up our code by conflicting with local values. This patch adds a simple code generator which generates wrappers for these defines, and uses them to wrap the windows.h wrapper using the `stl_wrappers` mechanism, allowing us to use windows.h in more places. Differential Revision: https://phabricator.services.mozilla.com/D10932
-
- Nov 28, 2018
-
-
Nika Layzell authored
By default, windows.h exposes a large number of problematic define statements which are UpperCamelCase, such as a define from `CreateWindow` to `CreateWindow{A,W}`. As many of these names are generic (e.g. CreateFile, CreateWindow), they can mess up Gecko code that may legitimately have its own methods with the same names. The header also defines some traditional SCREAMING_SNAKE_CASE defines which can mess up our code by conflicting with local values. This patch adds a simple code generator which generates wrappers for these defines, and uses them to wrap the windows.h wrapper using the `stl_wrappers` mechanism, allowing us to use windows.h in more places. Differential Revision: https://phabricator.services.mozilla.com/D10932
-
- Sep 07, 2018
-
-
Kartikaya Gupta authored
-