Skip to content
Snippets Groups Projects
  1. May 29, 2023
  2. May 24, 2023
  3. May 23, 2023
  4. May 10, 2023
  5. Apr 06, 2023
  6. Apr 04, 2023
  7. Apr 01, 2023
  8. Mar 31, 2023
  9. Mar 23, 2023
  10. Mar 15, 2023
  11. Jan 27, 2023
  12. Jan 11, 2023
  13. Dec 07, 2022
  14. Dec 01, 2022
  15. Nov 25, 2022
  16. Nov 22, 2022
  17. Nov 09, 2022
  18. Nov 08, 2022
  19. Aug 09, 2022
    • Nika Layzell's avatar
      Bug 1759555 - Part 2: Partially configure rust-analyzer for ./mach ide vscode, r=glandium,andi · 665766a2
      Nika Layzell authored
      In order to allow rust-analyzer to be able to use the build script in
      the mozbuild crate to discover the configuration information, this patch
      adds new flags to the vscode config to tell rust-analyzer to invoke
      cargo through `./mach cargo check`, and use the correct target directory
      within the objdir rather than `$(topsrcdir)/target`.
      
      Due to the virtual filesystem used by rust-analyzer not including files
      in the object directory, this is not sufficient to get suggestions for
      symbols from the included files, however it will accurately fetch
      diagnostics upon save and run things like proc macros.
      
      A new feature will likely need to be added to rust-analyzer to allow us
      to specify additional paths to add to the source root for packages to
      fix that issue.
      
      Due to this change using `./mach cargo check`, rather than running it
      independently, we don't run into issues caused by running `check`
      against crates in the workspace which aren't being used, making the
      diagnostics more useful.
      
      An additional feature needed to be added to `./mach cargo check` to
      allow specifying `--message-format=json`. I am open to suggestions for a
      more elegant way to communicate this flag into the makefile.
      
      Depends on D153269
      
      Differential Revision: https://phabricator.services.mozilla.com/D153270
      665766a2
    • Nika Layzell's avatar
      Bug 1759555 - Part 1: Avoid using env! for includes in the mozbuild crate, r=glandium · c8e801b4
      Nika Layzell authored
      This switches the code to instead use the generated source file, which is
      discovered based on `OUT_DIR` so is easier for rust-analyzer to understand.
      
      The configuration for rust-analyzer will be updated in the next part to
      make sure that rust-analyzer is able to take advantage of these changes,
      and produce better diagnostics.
      
      Differential Revision: https://phabricator.services.mozilla.com/D153269
      c8e801b4
  20. Apr 20, 2022
  21. Apr 11, 2022
  22. Jan 25, 2022
  23. Jan 11, 2022
Loading