Skip to content
Snippets Groups Projects
  1. Jul 29, 2024
  2. Jul 27, 2024
  3. Jul 26, 2024
  4. Jul 25, 2024
  5. Jul 27, 2024
  6. Jul 16, 2024
  7. Jul 24, 2024
    • Jon Coppeard's avatar
      Bug 1871303 - Ensure there is no more marking at the start of sweeping (ESR115) a=dmeehan · 3e70d88d
      Jon Coppeard authored
      There are two issues here. The first is that there unexpected marking work at
      the start of sweeping after entering from the mark phase without yielding. We
      previously called assertNoMarkingWork() after markUntilBudgetExhausted() in the
      marking phase so something since then must have added it.
      
      As far as I can tell this must be the conditional call to
      collectNurseryFromMajorGC(), where a post barrier for a pointer cleared during
      finalization (e.g. for Maps in mapObject::sweepAfterMinorGC) ends up marking
      something. I'm not sure such barriers are necessary, but for now the safest
      thing to do is to move this nursery collection to the start of the slice so
      that it happens before we drain the mark stack.
      
      The second issue is that we check the budget and conditionally yield if we
      enter from the marking state. The comment above this code states that this is
      not safe since we have not yet started sweeping a sweep group. This check was
      added in bug 1865383 but was not the main part of the fix. I think we should
      remove this.
      
      I wasn't able to come up with a test case to reproduce this.
      
      Differential Revision: https://phabricator.services.mozilla.com/D217551
      3e70d88d
  8. Jul 25, 2024
  9. Jul 24, 2024
  10. Jul 19, 2024
  11. Jul 23, 2024
  12. Jul 22, 2024
  13. Jul 19, 2024
  14. Oct 07, 2023
  15. Jul 18, 2024
  16. Jul 15, 2024
  17. Jul 11, 2024
  18. Jul 09, 2024
  19. Jul 08, 2024
  20. Jul 04, 2024
  21. Jul 03, 2024
  22. Jul 02, 2024
  23. Jun 24, 2024
  24. Jul 01, 2024
  25. Jun 28, 2024
  26. Jul 18, 2023
Loading