- Nov 18, 2023
-
-
Brad Werth authored
Bug 1854820 Part 2: Update an extension window test to check window sizes. r=extension-reviewers,robwu a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D192980
-
Brad Werth authored
Bug 1854820: Make the transition to window normal state work the same on extension windows as it does elsewhere. r=extension-reviewers,robwu a=RyanVM Calling window.restore will return the window to its previous dimensions. Prior to this patch, extension windows transitioning to normal state would add a second step where they would forcibly resize the window to content. The motivating reason for this additional step is some kind of difficulty with macOS windows restoring from other states. Those issues were handled comprehensively in Bug 1631735, and now the extra step is unnecessary and surprising to users. Since the call was being made potentially during a deminimization native transition, the window is at a very small size and expanding it to fit the content is resizing it to a strange small size. Window.restore will do the right thing, so this patch stops calling sizeToContent. Differential Revision: https://phabricator.services.mozilla.com/D189972
-
- Nov 03, 2023
-
-
Yannis Juglaret authored
Bug 1838286 - Fix a race condition with in-process DLL interception. r=win-reviewers,gstoll, a=RyanVM If a thread starts running a detoured function right after we successfully committed our 13-bytes patch, there is a short delay where it can reach the patched_XXX function and try to call stub_XXX while stub_XXX.mOrigFunc is still a null pointer. We fix this specific race condition, which, in the current code base, materializes mostly as crashes in patched_BaseThreadInitThunk when trying to call stub_BaseThreadInitThunk. Differential Revision: https://phabricator.services.mozilla.com/D192668
-
- Dec 08, 2023
-
-
Andrew Osmond authored
Differential Revision: https://phabricator.services.mozilla.com/D195888
-
- Dec 06, 2023
-
-
Yannis Juglaret authored
Bug 17090827 - Block legacy DLL for digital signatures with ID card from Spain. r=win-reviewers,keeler,gstoll a=RyanVM This patch blocks UsrDNIeCertStore.dll which was formerly used for digital signatures in the software packages for spanish ID cards (DNIe). This DLL is old and produces recurrent crashes for users who have it installed. The new software packages distribute and use DNIe_P11_x64.dll instead. Differential Revision: https://phabricator.services.mozilla.com/D195533
-
- Dec 11, 2023
-
-
ffxbld authored
Differential Revision: https://phabricator.services.mozilla.com/D196028
-
James Teh authored
1. Never treat a cell in a nested CachedTableAccessible as a cell in the outer table. This could previously result in trying to use cache data from one CachedTableAccessible when querying another, which could cause crashes. 2. Don't create an HTMLTableRowAccessible when the <tr> has a valid ARIA role other than "row". This could previously result in a situation where <tr role="grid"> was treated as a row by its parent table, but the <tr> was also treated as a separate table. Original Revision: https://phabricator.services.mozilla.com/D192175 Differential Revision: https://phabricator.services.mozilla.com/D196001
-
- Dec 10, 2023
-
-
James Teh authored
Original Revision: https://phabricator.services.mozilla.com/D192916 Differential Revision: https://phabricator.services.mozilla.com/D195992
-
James Teh authored
Bug 1863039: Fail gracefully in nsAccUtils::GetScreenCoordsForWindow if OuterDocOfRemoteBrowser returns null. a=RyanVM Original Revision: https://phabricator.services.mozilla.com/D192812 Differential Revision: https://phabricator.services.mozilla.com/D195993
-
- Nov 20, 2023
-
-
Jonathan Kew authored
Bug 1865482 - Make CSS :lang() matching more correctly follow the BCP4647 Extended Filtering algorithm. r=layout-reviewers,emilio a=RyanVM The matching behavior implemented in bug 1857742 did not quite follow the spec, particularly with regard to language *ranges* (as used in the :lang() pseudo) that are not themselves valid language *tags*. This updates the LangTagCompare function to more correctly follow the BCP4647 "Extended Filtering" algorithm, and adjusts the relevant WPT tests (originally from bug 1857742) to reflect the corrected behavior. Differential Revision: https://phabricator.services.mozilla.com/D194054
-
- Dec 07, 2023
-
-
Jonathan Kew authored
Bug 1857742 - patch 3 - Add some more :lang()-matching reftests. r=layout-reviewers,dholbert a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D195824 Depends on D195823
-
Jonathan Kew authored
Bug 1857742 - patch 2 - Use oxilangtag rather than unic_langid to parse lang tags for nsStyleUtil::LangTagCompare. r=layout-reviewers,dholbert,TYLin a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D195823 Depends on D195822
-
Jonathan Kew authored
Bug 1857742 - patch 1 - Vendor the oxilangtag crate into third_party/rust. r=supply-chain-reviewers,dholbert a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D195822
-
- Dec 08, 2023
-
-
Jens Stutte authored
Bug 1858033 - Refactor Proxy::mXMLHttpRequestPrivate to become a WeakPtr and simplify Teardown/Unpin. a=RyanVM This patch also clarifies that mXMLHttpRequestPrivate is only ever dereferenced on the worker thread and avoids to copy its raw pointer on the main thread by relying always on Proxy to access it. Original Revision: https://phabricator.services.mozilla.com/D194077 Differential Revision: https://phabricator.services.mozilla.com/D195826
-
- Nov 15, 2023
-
-
Morgan Rae Reschenberg authored
I think this crash may occur when the image map is being removed or when the area element is being moved. In any case, I'm reasonably confident that the reason for this crash was a null boundingFrame passed to TransformRect, which should only happen when the image map doesn't exist / has no frame. Also, we really shouldn't be transforming anyway, so I’ve removed the transform call. Differential Revision: https://phabricator.services.mozilla.com/D193460
-
- Oct 23, 2023
-
-
Barret Rennie authored
Bug 1796023 - Compare return value of readlink in nsLocalFileUnix::GetNativeTarget r=xpcom-reviewers,nika a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D190987
-
- Dec 07, 2023
-
-
Karl Tomlinson authored
mDemuxers array elements are also removed when no longer required. Original Revision: https://phabricator.services.mozilla.com/D193616 Differential Revision: https://phabricator.services.mozilla.com/D195746
-
- Nov 15, 2023
-
-
Jonathan Kew authored
Depends on D193661 Differential Revision: https://phabricator.services.mozilla.com/D193662
-
Jonathan Kew authored
Bug 1442018 - nsCellMap needs to try harder to find the appropriate cellmap for a table header/footer that may be a repeat. r=layout-reviewers,emilio a=RyanVM If a repeated header/footer row group gets fragmented, so that it has a next-in-flow, its REPEATABLE flag will be cleared. But in such a case, nsCellMap still needs to find the "original" in order to get the map for the repeated frame. Depends on D193660 Differential Revision: https://phabricator.services.mozilla.com/D193661
-
Jonathan Kew authored
Bug 1442018 - Avoid crashing in BCPaintBorderIterator if mCellMap was not found. r=layout-reviewers,emilio a=RyanVM This does not fix the underlying issue, which is that when the table got fragmented, we failed to maintain the cellmap (attached to the first-in-flow) to keep track of the additional rowgroup frame created to go in the overflowing part of the table. So this is a wallpaper patch just to prevent the crash here (confirmed with testcase 5); it'll still throw NS_ASSERTIONs in a debug build, and in the "bad" case (which depends on details of scaling) some of the borders will be missing from the print preview/output, but that seems preferable to crashing. Differential Revision: https://phabricator.services.mozilla.com/D193660
-
- Dec 06, 2023
-
-
Jan Varga authored
Original Revision: https://phabricator.services.mozilla.com/D193286 Differential Revision: https://phabricator.services.mozilla.com/D195046
-
- Dec 07, 2023
-
-
Issam Mani authored
Original Revision: https://phabricator.services.mozilla.com/D194770 Depends on D195781 Differential Revision: https://phabricator.services.mozilla.com/D195782
-
Issam Mani authored
Original Revision: https://phabricator.services.mozilla.com/D194769 Depends on D195780 Differential Revision: https://phabricator.services.mozilla.com/D195781
-
Issam Mani authored
Bug 1864379 - P1. Don't dispatch LoginManager DOM events for disconnected input elements. a=diannaS Original Revision: https://phabricator.services.mozilla.com/D194768 Differential Revision: https://phabricator.services.mozilla.com/D195780
-
- Nov 02, 2023
-
-
Emilio Cobos Álvarez authored
Bug 1862599 - Don't let certmanager treecol intrinsic sizes affect its minimum size. r=Gijs, a=RyanVM Otherwise the minimum size grows once you shrink a column under the treecol label size. Differential Revision: https://phabricator.services.mozilla.com/D192555
-
- Oct 30, 2023
-
-
Emilio Cobos Álvarez authored
See also bug 1821404. Differential Revision: https://phabricator.services.mozilla.com/D192058
-
- Dec 07, 2023
-
-
Ryan VanderMeulen authored
Backport of upstream PR: https://github.com/mozilla/pdf.js/pull/17106 Differential Revision: https://phabricator.services.mozilla.com/D195741
-
ffxbld authored
Differential Revision: https://phabricator.services.mozilla.com/D195769
-
- Nov 07, 2023
-
-
Henrik Skupin authored
Bug 1851376 - [geckodriver] Set "services.settings.server" to a dummy URL. r=webdriver-reviewers,Sasha a=test-only Differential Revision: https://phabricator.services.mozilla.com/D192831
-
- Dec 01, 2023
-
-
Paul Zuehlcke authored
-
Paul Zuehlcke authored
Differential Revision: https://phabricator.services.mozilla.com/D194802
-
Paul Zuehlcke authored
Differential Revision: https://phabricator.services.mozilla.com/D194801
-
- Nov 10, 2023
-
-
Dennis Jackson authored
Differential Revision: https://phabricator.services.mozilla.com/D193330
-
- Dec 05, 2023
-
-
Andrew Osmond authored
-
- Dec 06, 2023
-
-
Ryan VanderMeulen authored
Bug 1868656 - Don't attempt to download old LLVM ci artifacts when rebuilding rust-dev. r=glandium, a=release
-
- Nov 15, 2023
-
-
Mike Hommey authored
Bug 1864316 - Remove GPG signature check for zlib. r=firefox-build-system-reviewers,ahochheiden a=release
-
- Dec 05, 2023
-
-
Mark Banner authored
Differential Revision: https://phabricator.services.mozilla.com/D195602
-
- Dec 06, 2023
-
-
Ashley Hale authored
Original Revision: https://phabricator.services.mozilla.com/D192039 Differential Revision: https://phabricator.services.mozilla.com/D195330
-
- Dec 05, 2023
-
-
Randell Jesup authored
Differential Revision: https://phabricator.services.mozilla.com/D195601
-
- Dec 04, 2023
-
-
Randell Jesup authored
Differential Revision: https://phabricator.services.mozilla.com/D195493
-