MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and
MOZ_SOURCE_CHANGESET.
But the code takes for granted that it refers to a Hg instance, so it
combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`.
With this commit, we change this logic to combine them to create a URL
that is valid for GitLab.
$MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag.
If that is needed, we could use /-/tree/, instead of /-/commit/.

Kathleen Brade authored 8 years ago and Pier Angelo Vendrame committed 4 months ago

Windows: disable "runas" code path in updater (15201).
Windows: avoid writing to the registry (16236).
Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406,
  16014, 16909, 24476, and 25909.

Also fix bug 27221: purge the startup cache if the Base Browser
version changed (even if the Firefox version and build ID did
not change), e.g., after a minor Base Browser update.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

Bug 26048: potentially confusing "restart to update" message

Within the update doorhanger, remove the misleading message that mentions
that windows will be restored after an update is applied, and replace the
"Restart and Restore" button label with an existing
"Restart to update Tor Browser" string.

Bug 28885: notify users that update is downloading

Add a "Downloading Base Browser update" item which appears in the
hamburger (app) menu while the update service is downloading a MAR
file. Before this change, the browser did not indicate to the user
that an update was in progress, which is especially confusing in
Tor Browser because downloads often take some time. If the user
clicks on the new menu item, the about dialog is opened to allow
the user to see download progress.

As part of this fix, the update service was changed to always show
update-related messages in the hamburger menu, even if the update
was started in the foreground via the about dialog or via the
"Check for Tor Browser Update" toolbar menu item. This change is
consistent with the Tor Browser goal of making sure users are
informed about the update process.

Removed #28885 parts of this patch which have been uplifted to Firefox.

Bug 1832523 - Allow using NSS to sign and verify MAR signatures. r=application-update-reviewers,glandium,bytesized

Allow using NSS for checking MAR signatures also in platforms where
OS-native APIs are used by default, i.e., macOS and Windows.

Differential Revision: https://phabricator.services.mozilla.com/D177743

Original Revision: https://phabricator.services.mozilla.com/D214330

Differential Revision: https://phabricator.services.mozilla.com/D214488

Original Revision: https://phabricator.services.mozilla.com/D199353

Differential Revision: https://phabricator.services.mozilla.com/D202913

Bug 1874627 - regenerate expiring test certificates for 2024 (branch patch), this time with certificates included. r=jschank a=test-only


* the certificates were regenerated using `./mach generate-test-certs`
* the build/pgo/certs/ changes were made using
  `./mach python build/pgo/genpgocert.py`
* the zip files in security/manager/ssl/tests/unit/test_signed_apps/ were
  updated per the directions in the corresponding moz.build file
* security/manager/ssl/tests/unit/test_cert_override_read.js needed manual
  updating

These certificates and other test artifacts will now expire in 2025.

Differential Revision: https://phabricator.services.mozilla.com/D199156

* the certificates were regenerated using `./mach generate-test-certs`
* the build/pgo/certs/ changes were made using
  `./mach python build/pgo/genpgocert.py`
* the zip files in security/manager/ssl/tests/unit/test_signed_apps/ were
  updated per the directions in the corresponding moz.build file
* security/manager/ssl/tests/unit/test_cert_override_read.js needed manual
  updating

These certificates and other test artifacts will now expire in 2025.

Test Plan:
https://treeherder.mozilla.org/jobs?repo=try&revision=04e3780551b5e83a70b51acd84e1b3383a249f14

Differential Revision: https://phabricator.services.mozilla.com/D199156

Original Revision: https://phabricator.services.mozilla.com/D190468

Differential Revision: https://phabricator.services.mozilla.com/D193277

Bug 1847101 - Define WORDS_BIGENDIAN when targeting big endians. r=firefox-build-system-reviewers,ahochheiden, a=RyanVM

Some third party code (cairo, pixman, some media libs) rely on this
define being set. When they are built standalone, they get it from
autoconf, but we don't run their configure scripts, so that's missed.

Differential Revision: https://phabricator.services.mozilla.com/D185351

I'm pretty sure there are other theoretical problems in the code,
notably when a single section is larger than 4GB, but by the time
we reach that limit, bug 1839740 will have been fixed.

Differential Revision: https://phabricator.services.mozilla.com/D182447

Bug 1837086 - Properly pass -pie when linking. r=firefox-build-system-reviewers,sergesanspaille, a=dmeehan

There was a syntax error introduced in bug 1796380 that removed the flag
entirely. In practice, it didn't make a difference for us because clang
now defaults to PIE, but it can make a difference in environments where
the compiler is not using such a default.

However, on both Darwin and WASI, clang complains the flag is unused, so
we have to do something about it.

Differential Revision: https://phabricator.services.mozilla.com/D180279

Bug 1836020 - Patch llvm-strip to strip as much as cctools's strip. r=firefox-build-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D179636

It's only used by glean in code that is not actually used. It allows to
remove the only use of dashmap, which is a rather complex crate.

Differential Revision: https://phabricator.services.mozilla.com/D179747

Bug 1836402 - Disable clap default features in uniffi-bindgen-gecko-js. r=bdk,supply-chain-reviewers

The tool is not directly user visible, and it's not super useful for
features like color to be enabled.

Differential Revision: https://phabricator.services.mozilla.com/D179742

Backed out changeset fb52e6ee18c6 (bug 1714690) for causing bustages at complaining about charmap. CLOSED TREE

Bug 1714690 - Remove usages of "six" in build/RunCbindgen.py. r=firefox-build-system-reviewers,glandium

Differential Revision: https://phabricator.services.mozilla.com/D178515

Bug 1834436 - Upgrade minimum supported GCC version to 8. r=firefox-build-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D178736

Differential Revision: https://phabricator.services.mozilla.com/D179281

Differential Revision: https://phabricator.services.mozilla.com/D179392

Clang 17 made a change that made it an error to undefine _FORTIFY_SOURCE
on mac, because it's defined as a builtin when ASAN is enabled.
Defining it as 0 has the same effect of disabling it, but avoids the
error.

Differential Revision: https://phabricator.services.mozilla.com/D179398

Differential Revision: https://phabricator.services.mozilla.com/D179402

Bug 1835694 - Factor out a helper function for handling heuristic results in MozsearchIndexer. r=asuth DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D179401

Differential Revision: https://phabricator.services.mozilla.com/D178907

Differential Revision: https://phabricator.services.mozilla.com/D179374

Bug 1834955 - Upgrade minimum supported Clang-cl version to 9. r=firefox-build-system-reviewers,sergesanspaille

We have less constraints on the minimum supported clang-cl version, and
it would unlock C++17 inline variables (which had a bug on Windows
targets in clang up-to 8.x).

Differential Revision: https://phabricator.services.mozilla.com/D179037

Bug 1835428 - Do config.sub munging in a more generic way. r=firefox-build-system-reviewers,nalexander

This will allow to add other munging more easily in the future.

Differential Revision: https://phabricator.services.mozilla.com/D179280

Differential Revision: https://phabricator.services.mozilla.com/D179326

Differential Revision: https://phabricator.services.mozilla.com/D179205

Bug 1835189 - Make TARGET_OS in the build system mean the same as target.os in configure. r=firefox-build-system-reviewers,nalexander

The situation is confusing enough.

Eventually, we'll want to have TARGET_FOO mean the same as target.foo,
but let's start with the easy one.

Differential Revision: https://phabricator.services.mozilla.com/D179178

Bug 1835239 - Make the new -Wbuiltin-macro-redefined warning a non-error. r=firefox-build-system-reviewers,sergesanspaille

... until we fix the underlying issues.

Differential Revision: https://phabricator.services.mozilla.com/D179197

Differential Revision: https://phabricator.services.mozilla.com/D178734

It's the default and clang complains the argument is unused.

Differential Revision: https://phabricator.services.mozilla.com/D178733

Bug 1791961 - Re-enable C++20 -Wambiguous-reversed-operator warnings. r=firefox-build-system-reviewers,glandium

clang only reports these warnings when compiling with -std=c++20.

Depends on D179025

Differential Revision: https://phabricator.services.mozilla.com/D179026

Differential Revision: https://phabricator.services.mozilla.com/D179182

clang 17 is making void* deref a non-disablable error, and this tests
relies on the deref "error" being disablable. Arranging things to make
it not deref makes not different from test_ref_9, so remove it.

Differential Revision: https://phabricator.services.mozilla.com/D179031

Differential Revision: https://phabricator.services.mozilla.com/D179063

Bug 1833998 - Switch Firefox builds to macOS 13.3 SDK. r=firefox-build-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D178500

Bug 1834446 - Move otool detection to python configure. r=firefox-build-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D178750

Bug 1834446 - Move install-name-tool detection to python configure. r=firefox-build-system-reviewers,andi

At the same time, fix the sole use of the tool to actually use what's
found by configure, and only enable that configure check when building
Spidermonkey standalone.

And while we're here, add llvm-install-name-tool to the list.

Differential Revision: https://phabricator.services.mozilla.com/D178749