Differential Revision: https://phabricator.services.mozilla.com/D162751

Bug 1779670: Fix the ImageLib Bugzilla Component in moz.yaml files r=gfx-reviewers,jrmuizel DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D151892

Differential Revision: https://phabricator.services.mozilla.com/D151558

Depends on D142123

Differential Revision: https://phabricator.services.mozilla.com/D142124

Differential Revision: https://phabricator.services.mozilla.com/D137696

Depends on D125337

Differential Revision: https://phabricator.services.mozilla.com/D104554

Bug 1724331. Enable libpng defines PNG_WRITE_CUSTOMIZE_COMPRESSION_SUPPORTED and PNG_WRITE_FILTER_SUPPORTED. r=aosmond

Other than compiler a bit more code this should have no functional effect, we're setting the values to their default values we had before.

Differential Revision: https://phabricator.services.mozilla.com/D130021

Bug 1737038. Make sure we pass the correct zlib strategy to zlib from libpng when encoding pngs. r=aosmond

We don't enable PNG_WRITE_FILTER_SUPPORTED that means that do_filter field on the png_struct will always be zero (it's initialized to 0, and any calls to png_set_filter will error out unless the result is setting it to 0 https://searchfox.org/mozilla-central/rev/489e82dcc1e5afbe691ff3b1c982382914637e38/media/libpng/pngwrite.c#1032 ).

Then this code in png_write_IHDR https://searchfox.org/mozilla-central/rev/489e82dcc1e5afbe691ff3b1c982382914637e38/media/libpng/pngwutil.c#829 will execute and set do_filter to PNG_ALL_FILTERS for non-paletted images with >=8 bit depth.

This this code https://searchfox.org/mozilla-central/rev/489e82dcc1e5afbe691ff3b1c982382914637e38/media/libpng/pngwutil.c#339 will execute and set our zlib strategy to PNG_Z_DEFAULT_STRATEGY (as opposed to PNG_Z_DEFAULT_NOFILTER_STRATEGY). PNG_Z_DEFAULT_STRATEGY is also known as Z_FILTERED inside of zlib.

From here https://searchfox.org/mozilla-central/rev/489e82dcc1e5afbe691ff3b1c982382914637e38/modules/zlib/src/zlib.h#589 that means: "Z_FILTERED for data produced by a filter (or predictor) ... Filtered data consists mostly of small values with a somewhat random distribution."

So that is not what we want to our non-filtered image data.

Switching this so that we use PNG_Z_DEFAULT_NOFILTER_STRATEGY improves both the compression and speed. The following is the avg time taken for toDataURL with a canvas containing 3 different images, and dataURL.length.

Z_FILTERED

very simple line art
49.7ms
17618

"very png compressable image from bug 1724331"
60.8ms
192214

a photo
241.3ms
4193966

Z_DEFAULT_STRATEGY

very simple line art
52.2ms
17590

"very png compressable image from bug 1724331"
61.2ms
186182

a photo
213ms
3555170

All images are smaller with Z_DEFAULT_STRATEGY, the photo being 15% smaller. The two compressable images are perhaps very slightly slower, but the large photo is 12% faster.

For bug 1724331 I want to turn on PNG_WRITE_FILTER_SUPPORTED, and this means we avoid this bug because do_filter gets set to PNG_FILTER_NONE which is not equal to PNG_NO_FILTERS (which is a bit confusing). Avoiding his bug means our png encoder produces different output and we have a couple of tests that check against the exact output of the pngencoder that need to be updated.

Differential Revision: https://phabricator.services.mozilla.com/D130019

Bug 1733545 - Remove REQUIRES_UNIFIED_BUILD from third-party directories that don't need it. r=firefox-build-system-reviewers,andi

Differential Revision: https://phabricator.services.mozilla.com/D127229

Bug 1725145 - Preparation for the hybrid build env. r=necko-reviewers,firefox-build-system-reviewers,valentin,glandium

Automatically generated path that adds flag `REQUIRES_UNIFIED_BUILD = True` to `moz.build`
when the module governed by the build config file is not buildable outside on the unified environment.

This needs to be done in order to have a hybrid build system that adds the possibility of combing
unified build components with ones that are built outside of the unified eco system.

Differential Revision: https://phabricator.services.mozilla.com/D122345

Differential Revision: https://phabricator.services.mozilla.com/D15239

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D26575

--HG--
extra : moz-landing-system : lando

libpng has NEON support using intrinsics, not assembler, so we should use it
even if aarch64.

MSVC build still turns off NEON since libpng doesn't support it on stable
version although upstream has it.

Differential Revision: https://phabricator.services.mozilla.com/D15462

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D12901

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D5913

--HG--
extra : moz-landing-system : lando

The media/libpng/moz.build file overrides the C standard used via
-std=c89, per bug 1371266, which conflicts with the use of the
arm_neon.h header: compilation fails on the inline keyword, which didn't
exist in C89. We thus "bump" to the GNU89 standard, which is C89+GNU
extensions, including inline.

--HG--
extra : rebase_source : fe93a13e3bef8888e1874d2e94a6d8ef396aaf83

MozReview-Commit-ID: 7duJk2gSd4m

--HG--
extra : rebase_source : 7312fe276e561e8c034a5f6749774ae812727f9c

Bug 1403346 - Replace all uses of ALLOW_COMPILER_WARNINGS with a template, remove ALLOW_COMPILER_WARNINGS. r=glandium

MozReview-Commit-ID: 1G2o4fy74cf

--HG--
extra : rebase_source : 72613717bc7380d217f64ea6ae1191563bdedf4a

--HG--
extra : rebase_source : 75fe5b8320d52c7316ca547f706b64f30250d28c

--HG--
extra : source : 76404bf85ef79bacff8fd82b364698af17275d6b

--HG--
extra : rebase_source : 0c4a6e639e803bceff110cab600aadb3779a79fe

This refactor is for exposing necessary symbols of libpng for freetype2 in a
general way. Currently the necessary symbols of libpng for freetype2 are
exposed only on Android. And whether these symbols are exposed solely depends
on the target platform checking. A better way to decide whether or not to
expose these symbols would be checking the dependency of freetype2 directly.

MozReview-Commit-ID: C7xWOE0OwIK

--HG--
extra : rebase_source : 6bfeb3fb5840857dc3a71cbdbde570edafa78051

Bug 1315863 - Use PNG_MAXIMUM_INFLATE_WINDOW to ensure maximum compatibility with existing images. r=glennrp

--HG--
extra : rebase_source : 1887acea914d4c63927ecb5de4867f8b7968492d

--HG--
extra : rebase_source : 400ad744e14fbecd9b1aac784124df4c86078dbe

DONTBUILD

--HG--
extra : source : 7785b40af14f91910ad30c731212e5bdbb50bb09

--HG--
extra : rebase_source : c4f10bd0eb20bfe7420016d02d6b2254dcbbccf1