Kathleen Brade authored 5 years ago and Pier Angelo Vendrame committed 1 year ago

When Tor informs the browser that client authentication is needed,
temporarily load about:blank instead of about:neterror and prompt
for the user's key.

If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD
control port command to add the key (via Torbutton's control port
module) and reload the page.

If the user cancels the prompt, display the standard about:neterror
"Unable to connect" page. This requires a small change to
browser/actors/NetErrorChild.jsm to account for the fact that the
docShell no longer has the failedChannel information. The failedChannel
is used to extract TLS-related error info, which is not applicable
in the case of a canceled .onion authentication prompt.

Add a leaveOpen option to PopupNotifications.show so we can display
error messages within the popup notification doorhanger without
closing the prompt.

Add support for onion services strings to the TorStrings module.

Add support for Tor extended SOCKS errors (Tor proposal 304) to the
socket transport and SOCKS layers. Improved display of all of these
errors will be implemented as part of bug 30025.

Also fixes bug 19757:
 Add a "Remember this key" checkbox to the client auth prompt.

 Add an "Onion Services Authentication" section within the
 about:preferences "Privacy & Security section" to allow
 viewing and removal of v3 onion client auth keys that have
 been stored on disk.

Also fixes bug 19251: use enhanced error pages for onion service errors.

This commit was once part of "Bug 4234: Use the Firefox Update Process
for Tor Browser.".
However, some parts of it were not needed for Base Browser and some
derivative browsers.
Therefore, we extracted from that commit the parts for Tor Browser
legacy, and we add them back to the patch set with this commit.

Richard Pospesel authored 3 years ago and Pier Angelo Vendrame committed 1 year ago

- implements new about:torconnect page as tor-launcher replacement
- adds new torconnect component to browser
- tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
- adds warning/error box to about:preferences#tor when not connected to tor

Bug 40773: Update the about:torconnect frontend page to match additional UI flows.

Bug 41608: Add a toolbar status button and a urlbar "Connect" button.

henry authored 1 year ago and Pier Angelo Vendrame committed 1 year ago

Bug 42331: Fix git fetch arguments to fetch the upstream branch.

Kathleen Brade authored 8 years ago and Pier Angelo Vendrame committed 1 year ago

Windows: disable "runas" code path in updater (15201).
Windows: avoid writing to the registry (16236).
Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406,
  16014, 16909, 24476, and 25909.

Also fix bug 27221: purge the startup cache if the Base Browser
version changed (even if the Firefox version and build ID did
not change), e.g., after a minor Base Browser update.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

Bug 26048: potentially confusing "restart to update" message

Within the update doorhanger, remove the misleading message that mentions
that windows will be restored after an update is applied, and replace the
"Restart and Restore" button label with an existing
"Restart to update Tor Browser" string.

Bug 28885: notify users that update is downloading

Add a "Downloading Base Browser update" item which appears in the
hamburger (app) menu while the update service is downloading a MAR
file. Before this change, the browser did not indicate to the user
that an update was in progress, which is especially confusing in
Tor Browser because downloads often take some time. If the user
clicks on the new menu item, the about dialog is opened to allow
the user to see download progress.

As part of this fix, the update service was changed to always show
update-related messages in the hamburger menu, even if the update
was started in the foreground via the about dialog or via the
"Check for Tor Browser Update" toolbar menu item. This change is
consistent with the Tor Browser goal of making sure users are
informed about the update process.

Removed #28885 parts of this patch which have been uplifted to Firefox.

Differential Revision: https://phabricator.services.mozilla.com/D187298

Bug 1772409 - Allow setting xpinstall.whitelist.required via policy. r=settings-reviewers,Gijs a=pascalc

Bug 1845163 - Skip GeckoProfiler.FeatureCombinations and GeckoProfiler.AllThreads on Windows 7. r=canaltinova, a=test-only

Differential Revision: https://phabricator.services.mozilla.com/D184636

When we prepare an untrusted modules ping, we currently let Windows
choose between loading the module as a data file or as an image file.
However our code relies on the module being loaded as an image file,
because we do RVA computations. We must use the proper flag
LOAD_LIBRARY_AS_IMAGE_RESOURCE alone, which guarantees what we want:
loading as an image file, but not for execution.

Differential Revision: https://phabricator.services.mozilla.com/D183076

Bug 1838584 - Implement stripped down destructor for ProfilerParent, if MOZ_GECKO_PROFILER is undefined. r=mstange, a=dmeehan

On platforms such as ppc64, MOZ_GECKO_PROFILER is not defined, leading to a busted build.
The destructor-implementation was hidden behind an MOZ_GECKO_PROFILER-ifdef.

Differential Revision: https://phabricator.services.mozilla.com/D181042

Bug 1836851 - [update-verify] Fix regression in compare-directories, r=releng-reviewers,hneiva, a=release

Differential Revision: https://phabricator.services.mozilla.com/D179997

Differential Revision: https://phabricator.services.mozilla.com/D179371

Differential Revision: https://phabricator.services.mozilla.com/D179456

Bug 1835649 - Avoid serializing the number of operations per sample for profiler counters that don't count operations, r=canaltinova.

Differential Revision: https://phabricator.services.mozilla.com/D179365

Differential Revision: https://phabricator.services.mozilla.com/D179281

This switches two scripts to use the Mozilla Symbols Server for downloading
symbols rather than accessing the AWS S3 bucket directly so they don't stop
working correctly when we move symbols from AWS to GCP.

Differential Revision: https://phabricator.services.mozilla.com/D179452

Differential Revision: https://phabricator.services.mozilla.com/D179456

Differential Revision: https://phabricator.services.mozilla.com/D178532

Differential Revision: https://phabricator.services.mozilla.com/D178907

Backed out changeset 220d89d838fe (bug 1834707) for causing build bustages on Windows 2012. CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D178907

Bug 1831872 - Migrate client.name2 string from sync.properties to Fluent. r=markh,fluent-reviewers,geckoview-reviewers,sync-reviewers,flod,m_kato

As this is the only string in `services/`, let's simplify by moving it under `toolkit/` and removing `services/sync/locales/` as empty.

On advice from markh, the ON_NEW_DEVICE_ID notification is delayed during device registration & updates until the update has been written to storage.

Differential Revision: https://phabricator.services.mozilla.com/D178805

Differential Revision: https://phabricator.services.mozilla.com/D179112

Bug 1677171 - update-verify: silence spurious errors on mac staging releases. r=releng-reviewers,bhearsum

Differential Revision: https://phabricator.services.mozilla.com/D178923

Differential Revision: https://phabricator.services.mozilla.com/D178400

Bug 1834590 - [stylelint] Use "stylelint-rc" from stylelint.yml if it exists. r=linter-reviewers,Standard8

Default to using .stylelintrc.js in $topsrcdir with optional override for
Thunderbird's config file in comm-central.

Differential Revision: https://phabricator.services.mozilla.com/D178835

Bug 1793557 - Convert Extension.jsm strings to Fluent. r=mkmelin,geckoview-reviewers,robwu,flod,owlish

This changes the arguments of `ExtensionData.formatPermissionStrings()`.
The second `bundle` arg is dropped, and a `localization` option is added.
Call sites in m-c are updated, but this will also need a matching update for Thunderbird.
A few Thunderbird test cases will also need to be updated,
as they currently point to a non-existing localization file paths
"messenger/addons.ftl" and "messenger/addonPermissions.ftl".

As discussed at the addon workweek,
the Fluent l10n keys for extension permissions match the pattern:

    webext-perms-description-{name}

where `{name}` is the permission's sanitized name.
A fluent-lint exception is added for the capitalization of these generated names.
To allow for message updates and subsequent l10n identifier updates,
a `PERMISSION_L10N_ID_OVERRIDES` map is provided.

Because Fluent localization keys are not enumerable
and attempting to format a missing key is an error,
the `PERMISSIONS_WITH_MESSAGE` set must be kept in sync with message updates.

Differential Revision: https://phabricator.services.mozilla.com/D158663

Bug 1834499 - fix path globbing for extensions in stylelint linter and fix debugger styles that this starts noticing, r=Standard8,devtools-reviewers

For some reason I didn't fully apply the suggestion in
https://phabricator.services.mozilla.com/D177477#inline-983366
and this is affecting some invocations of stylelint (but not others, for
reasons I don't fully understand). This commit both fixes this oversight and
fixes up some debugger styles that get flagged now that they're linted
appropriately.

Differential Revision: https://phabricator.services.mozilla.com/D178531

Differential Revision: https://phabricator.services.mozilla.com/D178122

Differential Revision: https://phabricator.services.mozilla.com/D178599

Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish

Differential Revision: https://phabricator.services.mozilla.com/D177938

Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu

Differential Revision: https://phabricator.services.mozilla.com/D177027

Differential Revision: https://phabricator.services.mozilla.com/D177026

Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish

Differential Revision: https://phabricator.services.mozilla.com/D177025