Dan Ballard authored 1 year ago and Pier Angelo Vendrame committed 1 year ago

Bug 41526: revert removal of focus to cancle button + add prevention
from keyboard input to trigger multiple buttons as focus switches

Bug 41709: Reimplement the failure logic for
TorProtocolService.sendCommand

sendCommand tries to send a command forever every 250ms in case of
failure. That is bad because some async code branch might be stuck in it
forever.

We should have a number of maximum attempts and increase the delay after
which we try again.

Bug 41600 - Add new strings for the circuit display.

fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

Bug 41600 - Update the SVG fetch update script for fetching bridge
emojis and annotations, which we will also use for the flag emojis in
the tor circuit display.

We also:
+ Placed the bridgemoji files in a sub-directory.
+ Added a generation note to the generated files/directory.
+ Split the bridge emoji list into an external file, which we fetch in
  connectionPane.js so that the generating file is less fragile to
  a change in the javascript.
+ Store the locale emoji annotations using the string hex value as the
  key, rather than the emoji string sequence. This keeps it in line with
  the SVG file names, and removes ambiguity about whether the emoji
  character sequence includes the emoji variant selector U+FE0F or not.

Add cui-widget-panel class to the panel, which gives it the correct font.

Bug 41600 - Add API to domain-isolator to get the stored SOCKS username
and password for a given domain and user context ID.

Also get rid of unused newCircuitForUserContextId.

Also remove the return statement from tor-control-port's watchEvent
since addNotificationCallback does not return a value.

Bug 41600 - Change circuit display tour to use new button and panel.

This also fixes the "See My Path" button, which was broken before.

Bug 41600 - We remove the additions for "controlCenter", i.e. the site
identity panel, since the tor circuit display no longer lies within it,
so our tour no longer uses it.

Bug 41600 - Remove extensions.torbutton.display_circuit since it will no
longer be used.

It also could not work as intended before because after disabling and
re-enabling, all the circuits and browser credentials that were
established whilst it was switched off would have been lost and were not
recovered.

Bug 41600 - Remove old circuit display.

Bug 41711: Wait for the new window when doing new identity

Bug 41533: Fix onion detection on the page info window

Bug 40501: High CPU load after tor exits unexpectedly

When a peers (tor) disconnects, Firefox seems to keep the stream open,
and return 0 on available, rather than throwing.
So, as a matter of fact, we had a while trying to read 0 bytes without
any pause in _readLine, hence the 100% CPU usage.

Bug 41704: Immediately return on remoteSettings.pollChanges

Restore the letterbox warning for 12.0

Firefox strings use { -brand-product-name }.
As a result, it seems that the fork is recommending extensions, whereas
AMO curators are doing that.
So, we replace the strings with custom ones that clarify that Mozilla is
recommending them.

We assign the strings with JS because our translation backend does not
support Fluent attributes, yet, but once it does, we should switch to
them, instead.

Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033

This commit adds all the strings needed by following Base Browser
patches.

Bug 41698: Reword the recommendation badges in about:addons

We need to add a new commit for all base browser strings

Bug 41698

Bug 41701: Reporting an extension does not work

Bug 41689: Move the generic updated URL to the right place

Bug 41689: Do not customize startup.homepage_override_url in Base
Browser.

Bug 41684: Fix Android mozconfigs for local dev builds

The shell script matched x86 with x86_64.
I do not know how to match an entire token in shell scripts, so I
switched to a Python script, instead.

Bug 41684: Fix Android mozconfigs for local dev builds

Bug 41684: Fix Android mozconfigs for local dev builds

Bug 40788: Tor Browser is phoning home

The hijack-list component is the only remaining one calling home.
This is a temporary workaround, to use the remote settings.

We should do something like this commit at a more generic level, for all
RemoteSettings users.

Bug 41683: Disable the network process on Windows

This commit was once part of "Bug 4234: Use the Firefox Update Process
for Tor Browser.".
However, some parts of it were not needed for Base Browser and some
derivative browsers.
Therefore, we extracted from that commit the parts for Tor Browser
legacy, and we add them back to the patch set with this commit.

Bug 41668: Port some updater patches to Base Browser

Remove Tor Browser-only additions to make the updater patches usable
with Base Browser.
This commit should be reverted, and become a commit on its own, to
further adapt the updater to Tor Browser needs.

Bug 41668: Port some updater patches to Base Browser

Changes that will need to remain when actually cherry-picking to
base-browser, because they contain name fixes, for example.
Or, for UpdateService.jsm, they need to stay because they make the patch
more understandable.