Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,274
    • Issues 1,274
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor Browser
  • Issues
  • #16534

Closed
Open
Created Jul 09, 2015 by Jacob Appelbaum@ioerror

Failed to remove debugging options in Firefox

It is possible to set an environment variable, SSLKEYLOGFILE, that when set will export the CLIENT_RANDOM of Firefox's SSL/TLS handshakes to a file. This can include a Windows file share url - meaning that the CLIENT_RANDOM data would then be streamed to the remote server. Furthermore, I think this means that a better attacker can attach to firefox and simply use these functions to extract keying information.

I propose that we disable this functionality and also that we remove the code that makes this possible - or even better - we hook it and panic if someone tries to use it.

Relevant Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=908046 Relevant Google discussion: https://groups.google.com/forum/#!topic/mozilla.dev.tech.crypto/bu3b9x12c1Q

I have tested this against Tor Browser by running this command: SSLKEYLOGFILE=/tmp/tb-keys.log ./start-tor-browser.desktop

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking