Donation banner on about:tor page for 2017 campaign
We want to add a new donation banner to the Tor Browser startup page for our fundraising campaign in 2017. The design is currently under development, and when it is ready, this ticket will be for patching torbutton to add the banner.
Our old banners were legacy/trac#20414 (moved) (2016) and legacy/trac#17565 (moved) (2015). We can hopefully reuse some of the code again.
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Arthur Edelstein added TorBrowserTeam201709R in Legacy / Trac component::applications/tor browser in Legacy / Trac crowdfunding in Legacy / Trac owner::tbb-team in Legacy / Trac parent::23482 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tbb-backported in Legacy / Trac type::defect in Legacy / Trac labels
added TorBrowserTeam201709R in Legacy / Trac component::applications/tor browser in Legacy / Trac crowdfunding in Legacy / Trac owner::tbb-team in Legacy / Trac parent::23482 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tbb-backported in Legacy / Trac type::defect in Legacy / Trac labels
- Author
- Author
- Author
- Author
Here's a patch using the background image and layout concept from Mark Hardin and text from the crowfunding team. Please review. :) https://github.com/arthuredelstein/torbutton/commit/23483
To test the banner, it's necessary to pull down the latest translations, build the torbutton xpi, install it in Tor Browser (release or alpha) and set the pref "extensions.torbutton.testBanner" to true in about:config.
Currently we have translations for [en, es, fr, it, tr] (plus some languages we don't currently release). If more translations have been completed at bundle time, then we will need to add those two-letter codes to the list located here.
I tested this patch on Mac, Linux, and Windows TBB 7.0. I also tested on Mac TBB 7.5. The banner is designed to first appear to users on October 23, 2017.
- Author
BTW, I ended up using design 2 among the two alternatives, because the text positioning in design 1 required too much finesse. Every time I got the text in the right location for one locale, it became badly positioned in another locale.
And I should mention, I wrote positioning code RTL languages. So it should work if we get Arabic, Farsi, or Hebrew translations. There aren't any translations for those locales yet, however, so I tested with dummy text.
- Developer
Trac:
Keywords: TorBrowserTeam201609 deleted, TorBrowserTeam201709R added
Status: new to needs_review - Developer
Looks mostly good. Some nits:
-
bestSize
andbestPadding
are not declared in donation_banner.js. (seems I missed that last year ;) )
+// Increase padding at right to "squeeze" text, until it gets +// squeezed so much that it gets longer vertically.
is not correct as is in the case of RTL bundles the padding to the left increased. Could you reflect that in the comment?
In the commit message: "Bug 23483." -> "Bug 23483:"
Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201709R deleted, TorBrowserTeam201709 added -
- Author
Thanks for the review and good catches. I had used jshint but didn't realize that catching undefined variables was off by default. https://github.com/arthuredelstein/torbutton/commit/23483+1
Trac:
Keywords: TorBrowserTeam201709 deleted, TorBrowserTeam201709R added
Status: needs_revision to needs_review - Developer
Another thing I found:
if (bannerDataJSON.length > 0) {
it's not guaranteed that you have
bannerDataJSON
at all at this stage. Can you add a check for that before you query its length?Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201709R deleted, TorBrowserTeam201709 added - Author
Another good find. Here is the new version: https://github.com/arthuredelstein/torbutton/commit/23483+2
Trac:
Keywords: TorBrowserTeam201709 deleted, TorBrowserTeam201709R added
Status: needs_revision to needs_review - Developer
Alright, looks good now, thanks. This landed on
master
(commit b3ff9863db338b2bd612f109e8bbce4c4af7cbd0).Trac:
Resolution: N/A to fixed
Keywords: N/A deleted, tbb-backport added
Status: needs_review to closed Replying to arthuredelstein:
FWIW there's an error in the French translation: "la puissance de resistance numerique" should be ""la puissance de la resistance numerique.
- Author
Replying to cypherpunks:
Replying to arthuredelstein:
FWIW there's an error in the French translation: "la puissance de resistance numerique" should be ""la puissance de la resistance numerique.
Thanks. Colin, is that something you can edit on Transifex?
Trac:
Cc: gk, ssteele, akrieger@giantrabbit.com to gk, ssteele, akrieger@giantrabbit.com, phoul - Developer
Backported for 7.0.7: commit 2e6d58145ff2de2ac705f2feebe3d594eab382a8 on
maint-1.9.7
.Trac:
Keywords: tbb-backport deleted, tbb-backported added - Developer
Trac:
Resolution: fixed to N/A
Status: closed to reopened - Developer
Trac:
Resolution: N/A to fixed
Status: reopened to closed - Trac closed
closed
- Arthur Edelstein mentioned in issue legacy/trac#23526 (moved)
mentioned in issue legacy/trac#23526 (moved)
- Trac moved from legacy/trac#23483 (moved)
moved from legacy/trac#23483 (moved)
- Trac removed 1 deleted label
removed 1 deleted label