Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Browser Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 836
    • Issues 836
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor BrowserTor Browser
  • Issues
  • #23949
Closed
Open
Issue created Oct 23, 2017 by Arthur Edelstein@arthuredelstein

Bug in donation banner prevents display

I'm sorry to report the donation banner did not display when it was supposed to, at 2017-10-23T00:00:00. I tracked down the problem to a line in the code that was used for testing:

if (Services.prefs.getBoolPref("extensions.torbutton.testBanner", false)) {

Unfortunately, this line throws an exception if the pref does not exist at all. (The exception causes the banner not to be shown, while no other code is affected.) The second argument to getBoolPref is documented as the "default value" in mozilla-central, but not in mozilla-esr52. It seems I read the mozilla-central documentation, not realizing the second argument was added in Firefox 54.

And further, while I tested the banner with the pref set to true and false, it's clear I didn't test the banner thoroughly enough with the pref deleted.

I apologize for this mistake, especially to Georg and Nicolas who already ran extra builds for the banner.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking