I noticed this when trying to download the Signal app from the website. I click on the download link but nothing happened. Worked well on other mobile browsers. The issue might not be related to .apk files only, though. See:
After some investigation, I narrowed this bug down to torbutton. After disabling torbutton in Tor Browser for Android (and restarting), downloading works again. I wonder if this is related to the external app blocker.
After some investigation, I narrowed this bug down to torbutton. After disabling torbutton in Tor Browser for Android (and restarting), downloading works again. I wonder if this is related to the external app blocker.
Yep. After disabling extensions.torbutton.launch_warning, I now receive the download action dialog box again.
I have a patch that changes the default pref value of extensions.torbutton.launch_warning to false. I put this below the main if/else-if branches because I think this is more readable than handling this special case within the if (aValueType === "boolean") { branch.
This will be a little slower at initialization, because every pref is now compared against if ((aPrefName === "extensions.torbutton.launch_warning").
I suppose the real solution should be solving legacy/trac#26529 (moved) because this proves nsIHelperAppWarningDialog does work on Android, but the prompt we use doesn't work. We should modify _showPrompt() so it creates a different prompt on Android.
With this being said, I think developing that will take more time than we have right now - so I'd prefer solving the downloading issue first and then we can correctly solve legacy/trac#26529 (moved) later (but soon).
Taking this for TBA-a2 under the assumption we do the right thing (aka legacy/trac#26529 (moved)) and back this hack out again. This is commit 82729ba49f026a03966adb75b6b7737d71579967 on Torbutton's master now, thanks.
Trac: Status: needs_review to closed Resolution: N/Ato fixed