Tor Browser on Android fails to download files

added TorBrowserTeam201811R in Legacy / Trac component::applications/tor browser in Legacy / Trac owner::tbb-team in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac sponsor::8 in Legacy / Trac status::closed in Legacy / Trac tbb-mobile in Legacy / Trac type::defect in Legacy / Trac labels

After some investigation, I narrowed this bug down to torbutton. After disabling torbutton in Tor Browser for Android (and restarting), downloading works again. I wonder if this is related to the external app blocker.

Replying to sysrqb:

After some investigation, I narrowed this bug down to torbutton. After disabling torbutton in Tor Browser for Android (and restarting), downloading works again. I wonder if this is related to the external app blocker.

Yep. After disabling extensions.torbutton.launch_warning, I now receive the download action dialog box again.

I see two easy options:

Disabled extensions.torbutton.launch_warning when Services.appinfo.OS === "Android"
Check Services.appinfo.OS === "Android" in ExternalAppBlocker:maybeShow() and return false if we're on Android.

The harder solution is solving legacy/trac#26529 (moved) instead.

11-19 16:36:45.216 27651 27669 I Gecko   : [11-19 16:36:45] Torbutton INFO: tor SOCKS: https://updates.signal.org/android/Signal-website-release-4.30.7.apk via
11-19 16:36:45.216 27651 27669 I Gecko   :                        signal.org:b70e33ba585faf3f34b69778f7430d37
11-19 16:37:26.055 27651 27669 I Gecko   : [11-19 16:37:26] Torbutton INFO: Got timer update. Saving changed cookies to jar.
11-19 16:37:26.154 27651 27669 I Gecko   : [11-19 16:37:26] Torbutton DBUG: Cookies saved
11-19 16:37:26.224 27651 27669 I Gecko   : [11-19 16:37:26] Torbutton DBUG: Timer done. Cookies saved
11-19 16:37:37.596 27651 27651 I GeckoTabs: zerdatime 182903089 - page load stop
11-19 16:37:37.616 27651 27651 D GeckoToolbar: onTabChanged: STOP
11-19 16:37:37.636 27651 27669 I Gecko   : [11-19 16:37:37] Torbutton INFO: Component Load 0: New ExternalAppBlocker.
11-19 16:37:37.661 27651 27651 D GeckoBrowserApp: BrowserApp.onTabChanged: 0: STOP

I have a patch that changes the default pref value of extensions.torbutton.launch_warning to false. I put this below the main if/else-if branches because I think this is more readable than handling this special case within the if (aValueType === "boolean") { branch.

This will be a little slower at initialization, because every pref is now compared against if ((aPrefName === "extensions.torbutton.launch_warning").

https://oniongit.eu/sysrqb/torbutton.git, branch 27701_1.

Trac:
Status: new to needs_review

I suppose the real solution should be solving legacy/trac#26529 (moved) because this proves nsIHelperAppWarningDialog does work on Android, but the prompt we use doesn't work. We should modify _showPrompt() so it creates a different prompt on Android.

With this being said, I think developing that will take more time than we have right now - so I'd prefer solving the downloading issue first and then we can correctly solve legacy/trac#26529 (moved) later (but soon).

Trac:
Keywords: N/A deleted, TorBrowserTeam201811R added

Taking this for TBA-a2 under the assumption we do the right thing (aka legacy/trac#26529 (moved)) and back this hack out again. This is commit 82729ba49f026a03966adb75b6b7737d71579967 on Torbutton's master now, thanks.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed