Tor Browser launcher scripts override user-supplied LD_LIBRARY_PATH

I don't run PulseAudio, but sometimes I want sound in Tor Browser. To do this, I run Tor Browser under apulse (https://github.com/i-rinat/apulse), which adds /usr/lib64/apulse/ to LD_LIBRARY_PATH to make applications pick up its PulseAudio-to-ALSA shim libraries.

I think this used to work fine, but I haven't used it for a long time; the last time was definitely before the major upgrade to Tor Browser 8. Today, I wanted to use it again in 8.0.1, but I got no sound.

Checking /proc/$PID/environ showed that apulse's path had been overridden; it now contained LD_LIBRARY_PATH=./TorBrowser/Tor/ instead.

This is because the ~/.local/share/torbrowser/tbb/x86_64/tor-browser_en-US/Browser/firefox script overrides LD_LIBRARY_PATH unconditionally:

basedir=$(dirname "$0")

LD_LIBRARY_PATH="$basedir/TorBrowser/Tor/"

I changed that to add to the path instead of overriding it:

LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$basedir/TorBrowser/Tor/"

and now I get sound from Tor Browser.

Trac:
Username: creideiki