Following legacy/trac#32767 (moved), it seems Firefox is throwing an exception. I don't think it's too important.
1581718500372 addons.xpi-utils WARN addMetadata: Add-on disconnect@search.mozilla.org is invalid: Error: File re[/search-extensions/disconnect/](/search-extensions/disconnect/) does not contain a valid manifest(re[/gre/modules/addons/XPIInstall.jsm:671:11)](/gre/modules/addons/XPIInstall.jsm:671:11)) JS Stack trace: loadManifest@XPIInstall.jsm:671:11awaitPromise@XPIProvider.jsm:228:15syncLoadManifest@XPIInstall.jsm:750:24addMetadata@XPIDatabase.jsm:2721:32processFileChanges@XPIDatabase.jsm:3162:26getNewSideloads@XPIProvider.jsm:3005:281581718500362 addons.xpi-utils WARN Not uninstalling invalid item because it is a proxy file
We may not need to do anything about this, but if there is a way we can prevent this error then that'll be even better (reducing noise in logging is helpful).
acat, what do you think? I haven't looked at the code in the stacktrace at all.
Designs
Child items
0
Show closed items
No child items are currently assigned. Use child items to break down this issue into smaller parts.
r=brade,r=mcs
The code looks good and we tested it on macOS.
Kathy and I agree that we should try to handle this via some migration code next time.
One question: would it also work to remove the addonStartup.json.lz4 file? If I remember correctly it is a cache that would get rebuilt based on the installed addons.
Sorry, I trusted my mail classification too much and missed mcs question.
Replying to mcs:
One question: would it also work to remove the addonStartup.json.lz4 file? If I remember correctly it is a cache that would get rebuilt based on the installed addons.
I think not, in the sense that it might break some stuff. For example, if you remove addonStartup.json.lz4 the search builtin extensions will not load at all, which means that the search icons in the urlbar will be broken (similar to legacy/trac#31563 (moved)). Launching the browser with env variable RELOAD_ENGINES=1 makes SearchService.jsm reinstall these search extensions again, so perhaps removing addonStartup.json.lz4 + forcing search extensions reinstall might do the trick.
I'm not completely sure about the details, but I think one of the reasons why addonStartup.json.lz4 is "not just a cache", at least for builtin extensions, is that the BuiltInLocation is not enumerable, which means that in scanForChanges the builtin location is skipped and it cannot notice the fact that the addon disappeared from addonStartup.json.lz4 (because actually it was the only place this was persisted on). I think this would not be an issue if the search engines were temptatively installed every time, like it's done with the themes, but that's not the case (probably to make the browser load faster?).