Spoof Network ID

Mozilla 1561005 added a unique string identifier to nsINetworkLinkService.idl. It's at least partially based off of a hash of the user's IP and MAC address. It's not clear to me what it's used for, but we should probably stub out the implementations.

Relevant ticket:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1561005

Trac:
Parent Ticket: legacy/trac#33534 (moved)

added component::applications/tor browser in Legacy / Trac owner::tbb-team in Legacy / Trac parent::33534 in Legacy / Trac priority::medium in Legacy / Trac resolution::wontfix in Legacy / Trac severity::normal in Legacy / Trac sponsor::58 in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac labels

The network ID is visible at about:networking#networkid. It is also exposed to privileged WebExtensions (see toolkit/components/extensions/parent/ext-networkStatus.js), probably to support the Firefox Private Network (VPN) feature. Because the network ID is not exposed to web content or even regular WebExtensions, maybe we should just leave it as-is.

Additional references:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1550605
• https://github.com/acatarineu/tor-browser/blob/33533%2B5/netwerk/base/nsINetworkLinkService.idl#L49
• https://github.com/acatarineu/tor-browser/blob/33533%2B5/netwerk/system/netlink/NetlinkService.cpp#L1731 (CalculateNetworkID() method).

acat, can you provide another opinion? Should we resolve this ticket as wontfix?

Trac:
Status: assigned to needs_information

I agree that networkID is currently not exposed to (non-privileged) WebExtensions or web content, and I would also say we don't have to spoof it right now. This might change in the future (e.g. the API being available to all WebExtensions), but I hope we'll be able to catch that if it happens.

Trac:
Status: needs_information to closed
Resolution: N/A to wontfix

closed

mentioned in issue legacy/trac#33534 (moved)

moved from legacy/trac#33854 (moved)

added Bug label and removed 1 deleted label

removed 1 deleted label

added 1 deleted label

@acat

we don't have to spoof it right now. This might change in the future [...] but I hope we'll be able to catch that if it happens.

What's the harm in spoofing it right now? Make it identical for every Tor Browser. Is the network ID used for anything more than Firefox Private Network (VPN)? Will Tor Browser ever use Firefox Private Network? If the answers are "no", then what's the harm in spoofing it now to mitigate future changes by Mozilla?

@mcs wrote in comment 2672059 #33854 (comment 2672059) :

It is also exposed to privileged WebExtensions (see toolkit/components/extensions/parent/ext-networkStatus.js), probably to support the Firefox Private Network (VPN) feature.

https://fpn.firefox.com/ "Firefox Private Network browser protection uses a server provided by our partner Cloudflare, who collects a limited amount of data and deletes it permanently after 24 hours.... The Firefox Private Network browser extension creates an encrypted tunnel called a proxy between your browser and a network managed by our trusted partner Cloudflare. While you browse the web, your browsing data flows from Firefox directly through this secure connection.... your web traffic is proxied by Cloudflare before it reaches the web"

https://www.cloudflare.com/mozilla/firefox-private-network-privacy-notice/ https://www.mozilla.org/privacy/firefox-private-network

NOPE. Fuck that anti-feature!

mentioned in issue #40398 (closed)

added BugSmashFund label