Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,004
    • Issues 1,004
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor Browser
  • Issues
  • #40551
Closed
Open
Created Jul 16, 2021 by Matthew Finkel@sysrqbMaintainer

Don't silently log and continue when changing tor's config fails

We only throw an error when the setconf fails. We should not do that, especially when configuring a bridge.

      let errorObject = {}; 
      if (!this._tlps.TorSetConfWithReply(settingsObject, errorObject)) {
        throw new Error(errorObject.details);                                                                                                                                                                                                                         
      }

An an example, when using provide a bridge with foo bar baz we get the following log messages:

Jul 16 15:55:57.000 [warn] Error parsing Bridge address 'bar'
Jul 16 15:55:57.000 [warn] Controller gave us config lines that didn't validate: Bridge line did not parse. See logs for details.
JavaScript error: resource:///modules/TorProtocolService.jsm, line 128: Error: Unacceptable option value: Bridge line did not parse. See logs for details.

But the user has zero notification about this failure.

Edited Aug 20, 2021 by Roger Dingledine
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking