Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Browser Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 680
    • Issues 680
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor BrowserTor Browser
  • Issues
  • #41015
Closed (moved) (moved)
Open
Created Jun 06, 2022 by dragjkngj@dragjkngj

WM_CLASS not set up correctly when running as native Wayland client

Summary

Tor Browser uses --class "Tor Browser" parameter to identify itself from plain Firefox windows, and this parameter doesn't work when running as native Wayland client. The windows class is firefox rather than expected Tor Browser.

Steps to reproduce:

  1. Modify start-tor-browser script or start-tor-browser.deskktop entry to include MOZ_ENABLE_WAYLAND=1 environment variable, in order to prefer Wayland client
  2. Put start-tor-browser.desktop into corresponding directory
  3. Start Tor Browser

What is the current bug behavior?

Tor Browser is started as native Wayland client, but the icon is a generic Wayland icon instead of Tor Browser's own. Furthermore, under certain desktop environments, window grouping and start new instance doesn't work at all, because the running Tor Browser isn't identified / linked to the desktop entry.

What is the expected behavior?

The running Tor Browser should be linked to the desktop entry. Tor Browser should display its own icon, window grouping and start new instance should work. windows class should be Tor Browser.

Environment

  • OS: Fedora Kinoite 36
  • DE: KDE Plasma 5.24.5, Wayland session
  • Software distribution: Downloaded directly from torproject.org (tor-browser-linux64-11.0.13_en-US.tar.xz)

This issue also occurs in unofficial distribution torbrowser-launcher, relevant issue

Relevant logs and/or screenshots

Wayland client

Wayland

X11 client (under Wayland session, through XWayland)

X11

A hotfix was implemented in tor-browser-build!466 (closed)

Edited Jun 06, 2022 by dragjkngj
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking