Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Browser Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 835
    • Issues 835
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor BrowserTor Browser
  • Issues
  • #41035
Closed
Open
Issue created Jun 21, 2022 by Pier Angelo Vendrame@pierovMaintainer

OnionAliasService should use threadsafe ISupports

OnionAliasService was born as a thread safe class (or so it should be: it has only one hashmap, and a mutex that protects the writings to it, but not the reads - it shouldn't be necessary, but I can lock it also when reading, if needed).

However, I should have used NS_DECL_THREADSAFE_ISUPPORTS, but I didn't.

So, reference counting may not be thread-safe, or so Firefox thinks, and crashes when compiled with debug enabled.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking