Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Browser Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 835
    • Issues 835
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor BrowserTor Browser
  • Issues
  • #41039
Closed
Open
Issue created Jun 25, 2022 by Richard Pospesel@richardOwner

Set 'startHidden' flag on tor process in tor-launcher

We have to maintain two different builds of tor.exe on windows, one with the -mwindows compile time flag and one without. This flag prevents a cmd.exe window from opening when the tor.exe process is started by tor-launcher.

In tor-launcher, we could just set the 'startHidden' flag ( https://searchfox.org/mozilla-central/source/xpcom/threads/nsIProcess.idl#82 ) on the tor nsIProcess ( https://gitlab.torproject.org/tpo/applications/tor-launcher/-/blob/master/src/components/tl-process.js#L533 ) and then we can most likely get rid of the -mwindows flag on the tor build.

With the cmd.exe issue fixed in tor-browser/tor-launcher, we will not need to maintain multiple different builds of tor.exe on windows.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking