Skip to content

QR codes in connection settings aren't recognized by some readers in dark theme

Some readers don't recognize QR codes with inverted colors. You may call it a "you" problem, but still.

Here's the responsible code:

Simply hard-coding black and white (or keeping the default ones) regardless of theme wouldn't help because the image is drawn directly on top of dark/light background, depending on color theme, which makes it unreadable if the background is dark. Although we could add a padding element with white background.

Or we could just wait until all readers start recognizing inverted QRs.

Similar issue in another project: https://github.com/bennyguitar/BTCDonationViewController/issues/1#issuecomment-39025558

If you agree that we should hard-code black and white, then I'd like to implement it.

Edited by donuts
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information