Tor binary we build seems to not getting picked up in nightly builds

We build Tor for Android now ourselves thanks to the fix for legacy/trac#28766 (moved). But unfortunately it seems at least as it is not picked up yet, despite legacy/trac#32993 (moved) claiming so. I stumbled across this when testing a fix for legacy/trac#32027 (moved). The branch has all patches for legacy/trac#28704 (moved) and children but it's still shown that we use the Tor we've been bundling so far but not the one we compile.

assigned to @dan

added GeorgKoppen202004 in Legacy / Trac TorBrowserTeam202004 in Legacy / Trac component::applications/tor browser in Legacy / Trac gitlab-tb-tor-android-service in Legacy / Trac owner::gk in Legacy / Trac priority::medium in Legacy / Trac severity::normal in Legacy / Trac status::new in Legacy / Trac tbb-mobile in Legacy / Trac tbb-parity in Legacy / Trac type::defect in Legacy / Trac labels

Trac:
Status: new to assigned
Owner: tbb-team to gk
Cc: sysrqb, gk, sisbell, tbb-team to sysrqb, sisbell, tbb-team
Keywords: N/A deleted, GeorgKoppen202004 added

Okay, I have been looking closer. Looking at the libTor.so we actually ship in nightlies does imply that it contains the tor and OpenSSL version we compile (I ran strings over the .so file), so that's good. What is happening is that the binary version check done in tor-android-service is just returning a hard-coded string TOR_VERSION, which is currently set to 0.4.1.5-rc-openssl1.0.2p.

So, we might actually be good here at least with respect to the actually used Tor/OpenSSL version, but that's hard to say. Either way, we need to come up with a better solution than hard-coding given that we support different Tor versions in parallel now.

Trac:
Description: We build Tor for Android now ourselves thanks to the fix for legacy/trac#28766 (moved). But unfortunately it is not picked up yet, despite legacy/trac#32993 (moved) claiming so. I stumbled across this when testing a fix for legacy/trac#32027 (moved). The branch has all patches for legacy/trac#28704 (moved) and children but it's still shown that we use the Tor we've been bundling so far but not the one we compile.

to

We build Tor for Android now ourselves thanks to the fix for legacy/trac#28766 (moved). But unfortunately it seems at least as it is not picked up yet, despite legacy/trac#32993 (moved) claiming so. I stumbled across this when testing a fix for legacy/trac#32027 (moved). The branch has all patches for legacy/trac#28704 (moved) and children but it's still shown that we use the Tor we've been bundling so far but not the one we compile.
Summary: Tor binary we build is not picked up in nightly builds to Tor binary we build seems to not getting picked up in nightly builds

Trac:
Priority: High to Medium

Hm, there seems to be no easy way to get the version information at that point. :( So, maybe we should just not emit it then or move it to a later point in the start-up process when we do have it available. It would be good to know the respective Tor version used for debugging help, in particular now that we are starting to use different Tor versions.

I wonder why we can't just let tor speak directly as on the other platforms. I think that's the ideal solution here. I'll dig a bit...

Trac:
Parent: legacy/trac#28704 (moved) to N/A

Trac:
Keywords: tbb-rbm deleted, N/A added

Trac:
Status: assigned to new

Trac:
Keywords: N/A deleted, gitlab-tb-tor-android-service added

moved from legacy/trac#33930 (moved)

added Bug label and removed 1 deleted label

added Android Platform Parity labels and removed 1 deleted label

unassigned @gk

added Backlog label

removed Backlog label

added Next + 1 deleted label

assigned to @boklm

removed milestone

assigned to @dan and unassigned @boklm

@dan I suspect this is outdated can you confirm?

changed milestone to %Sponsor 131 - Phase 3 - Major ESR 102 Migration

added Q4 label

added Sponsor 131 label

unassigned @dan

assigned to @richard

assigned to @dan and unassigned @richard

added Backlog label and removed Next label

added Doing label and removed Backlog label

this has been resolved

https://nightlies.tbb.torproject.org/nightly-builds/tor-browser-builds/tbb-nightly.2022.11.05/

all projects have an expert bundle now

@dan I think this issue was created much earlier .

I think that TBA worked even without picking the binaries with Orbot, but I am not sure.

Anyway, I don't have Orbot (well, my test device has a clean LineageOS + only the various Tor Browser I use for testing ) and Tor Browser works anyway, so I'd say it's been resolved, too .

closed