Inform users when Tor Browser sets their language automatically

changed milestone to %Sponsor 131 - Phase 4 - Browser Release Management

added Doing Localization UX Team Sponsor 131 Q4 UX labels

assigned to @duncan

@pierov Could you help me fill in some of the ???? above please? I'm not totally sure what will happen in these scenarios.

When the user changes their system language, Tor Browser will ????

Match the system language, if the user never customized it, but will remain in the language chosen by the user, if they chose one time.

When the user updates from a single-locale to multi-local build, Tor Browser will ????

Switch to the system language (I expect, we should try to grab a single-locale nightly and make it update to multi-locale).

Good to know, thank you!

Switch to the system language (I expect, we should try to grab a single-locale nightly and make it update to multi-locale).

If that's the case, we should maybe find a way to prevent this happening. I imagine it could confuse a lot of existing users who have Tor Browser set to a different language.

Yes. I tend to have some apps in a different language than my system lang.

Good to know, thank you!

Switch to the system language (I expect, we should try to grab a single-locale nightly and make it update to multi-locale).

If that's the case, we should maybe find a way to prevent this happening. I imagine it could confuse a lot of existing users who have Tor Browser set to a different language.

I confirm this is what happened in nightly for me. I had a french single-locale nightly, on a system in english, and after updating it became in english.

This can be confusing, however if you know language can be changed, you can change it back very quickly. Maybe we should mention that in the blog post for the new release?

If that's the case, we should maybe find a way to prevent this happening.

I have an idea to prevent this in stable.

We'll likely do a 11.5.7. We could add a one-time only patch to make intl.locale a user preference, that will be saved to prefs.js.

So, when user will download the multi-lingual 12.0 as an update, it should be localized to the same locale they had previously.

Sounds great!

/cc @richard

We could add a one-time only patch to make intl.locale a user preference, that will be saved to prefs.js

Do you mean make "intl.locale.requested" a sticky preference?

I didn't know about sticky preferences, but they are probably what we need, thanks !

marked this issue as related to #17400 (closed)

Here's one option using the chrome notification banner:

I've deliberately avoided saying "Tor Browser has changed your language to English (en)..." since, hopefully, nothing will have changed for the majority of our users. Stable should also include a "Learn more" link pointing to an article on the support portal explaining why this warning exists.

assigned to @pierov and unassigned @duncan

removed Doing label

added Next label

/cc @henry

marked this issue as related to #41413 (closed)

marked this issue as related to #41414 (closed)

Continuing in #41413 (closed) with the backup plan for 11.5.x, and in #41414 (closed) to create a catch window in 12.0 or in the first versions from the 12.0 series.

Keeping this ticket to add some UX to inform users that they can change their language in the settings, and assigning it back to @duncan for now (until we decide the best UX for that ).

Let's go with the UI above please: #41378 (comment 2845190)

assigned to @duncan and unassigned @pierov

assigned to @pierov and unassigned @duncan

mentioned in merge request tpo/web/blog!123 (merged)

removed Next label

added Doing label

Now, one of the real problems: how do we call the pref to check if we've asked to change language?

intl.shown_language_notification?

I think we should not use the name torbrowser, since this is likely something we'll need for S131.

this is likely something we'll need for S131.

About this (and note also for myself): I'd like to check if we can localize this with Fluent.

Other calls to gNotificationBox.appendNotification already use it, and I think it's just a simple lookup+replacement.

At the moment Fluent is blocked because Weblate doesn't support attributes, but it might work for the usecase of this patch.

I have implemented this as a fixup, so that I can revert it quickly if we decide we don't want to proceed in this way.

So, I've moved the issue back to Next because I'd like to test the Fluent file in Weblate.

If we see it works, we might merge the changes for tor-browser-build#40641 (closed) first.

Otherwise, I can rollback the commit that uses Fluent, but we will have to add the new strings to torbutton/Transifex.

Weblate can translate the files tpo/translation@27af6b74.

So, starting with Fluent already, without adding strings with wrong placeholders .

@duncan: do you think we should show the notification only once and then take for granted the user has seen it, or should we wait for them to explicitly either click on the button, or on the X to dismiss the notification?

Mmm that depends, what does "once" mean? Does it just hang around until the first window it appears in is closed?

Yes, exactly, in all tabs.

But if you close it, also the bar goes.

That's perfect then, thank you! Requiring the user to manually dismiss the banner would be a little heavy handed.

added Next label and removed Doing label

mentioned in issue #32411 (closed)

mentioned in issue #41433 (closed)

removed Next label

added Doing label

marked this issue as related to tor-browser-build#40686 (closed)

mentioned in issue tor-browser-build#40686 (closed)

mentioned in merge request !443 (merged)

mentioned in issue #41454

removed Doing label

closed

marked this issue as related to tor-browser-build#40668 (closed)

mentioned in issue #41525 (closed)

Inform users when Tor Browser sets their language automatically

Designs

Child items ...

Activity