"Onion available" toolbar button accessibility problems
This mostly works fine with a keyboard and a screen reader. There are a few issues:
- The button isn't as prominent when using a screen reader because you're unlikely to navigate to it. It only shows sometimes after the page loads, at which point you're likely inside the web page rather than the url bar. By the time you next go to the url bar, you're probably going to a new site. However, I don't think it should necessarily be a noisy notification, it is just something to note for now. I should also note that I think there is a general issue with how firefox lays out its top toolbar: it is a weird mix of using tab and arrow keys to navigate between them, with no accessible names to tell the user which toolbar group they are in.
- The button name ".onion available" isn't that descriptive of the action it performs. Just like that, from the name I would expect information in a popup or something, rather than loading the onion site. Maybe it could do with a tooltip, like "Switch to using onion address for this site", which would also act as the accessible description.
- The button looses focus when it is hidden, we should move it to somewhere appropriate.
For the "Try Onion Services" notification popup (re-enable with privacy.prioritizeonions.showNotification):
- On Orca, the alert text is read out twice, with "page loaded" read out in between. I think this is a general problem with firefox notifications though.
- Browse navigation doesn't seem to work (with Orca) in the popup.
Edited by henry