TOR_SOCKS_IPC_PATH environment variable not honored

mentioned in commit Poncho/torbrowser-overlay@3a129e46

Interesting, does this feature work in 11.5?

We migrated the tor-launcher source to tor-browser itself so its definitely possible this broke during the migration.

And slightly off-topic, how are you handling pluggable-transports in your gentoo port? IE do you build and deploy them as well, or are a lot of the about:preferences#connection settings just broken/not honored?

There's definitely some spaghetti but TOR_SKIP_LAUNCH is what eventually is returned by enabled in browser/components/torpreferences/content/connectionPane.js: enabled calls TorMonitorService.ownsTorDaemon, which returns TorLauncherUtil.shouldStartAndOwnTor, that checks the environment variable and the preferences.

added Backlog Bug Linux labels

added Q1 label

removed Q1 label

added Q2 label

assigned to @pierov

Interesting, does this feature work in 11.5?

Yes, it was working fine till 12.0a4, in 12.0a5 it was broken.

Reverting torbutton@004b629b and torbutton@f5cbb382 breaks to UI in various ways (missing text), but gets TOR_SOCKS_IPC_PATH working again.

And slightly off-topic, how are you handling pluggable-transports in your gentoo port? IE do you build and deploy them as well, or are a lot of the about:preferences#connection settings just broken/not honored?

about:preferences#connection is just broken. I even used to set the TOR_NO_DISPLAY_NETWORK_SETTINGS option. I don't think it's available anymore though. I do provide a separate build for the snowflake client and proxy

about:preferences#connection is just broken. I even used to set the TOR_NO_DISPLAY_NETWORK_SETTINGS option. I don't think it's available anymore though. I do provide a separate build for the snowflake client and proxy

Is it visible in about:preferences's sidebar? Or are you opening it manually?

I even used to set the TOR_NO_DISPLAY_NETWORK_SETTINGS option. I don't think it's available anymore though.

Yes, I confirm it isn't.

Reverting torbutton@004b629b and torbutton@f5cbb382 breaks to UI in various ways (missing text), but gets TOR_SOCKS_IPC_PATH working again.

Uhm. That's completely unexpected, but there are two possible motivations for which they fix your problem:

there was some unhandled exception that prevented some parts of torbutton to work; we fixed them but the code offending your need is now run
the opposite, i.e., your configuration is missing something after these changes .

Could you please check for errors and or warnings in the Browser console (Ctrl+Shift+J, or start Tor Browser/Firefox with -jsconsole)?

Could you please check for errors and or warnings in the Browser console (Ctrl+Shift+J, or start Tor Browser/Firefox with -jsconsole)?

14:37:30.332 1670855850332	addons.xpi	WARN	Checking /usr/lib64/torbrowser/distribution/extensions for addons
14:37:30.692 SecurityLevel: Listening for messages from NoScript. SecurityLevel.jsm:257
14:37:30.692 SecurityLevel: Initializing security-prefs.js SecurityLevel.jsm:358
14:37:30.693 SecurityLevel: security-prefs.js initialization complete SecurityLevel.jsm:392
14:37:30.695
ReferenceError: FileUtils is not defined
startup-observer.js:121:11
    setProxySettings jar:file:///usr/lib64/torbrowser/omni.ja!/chrome/torbutton/components/startup-observer.js:121
    observe jar:file:///usr/lib64/torbrowser/omni.ja!/chrome/torbutton/components/startup-observer.js:175
14:37:30.695 [12-12 14:37:30] Torbutton NOTE: Early proxy change failed. Will try again at profile load. Error: ReferenceError: FileUtils is not defined
14:37:30.907 TorProtocolService: SOCKS port type: IPC TorProtocolService.jsm:500
14:37:30.907 TorProtocolService: ipcFile: /run/tor/socks TorProtocolService.jsm:502
14:37:30.963 TorProtocolService: TorProtocolService initialized TorProtocolService.jsm:100
14:37:30.970 TorMonitorService: Not starting the event monitor, as we do not own the Tor daemon. TorMonitorService.jsm:96
14:37:30.970 TorMonitorService: TorMonitorService initialized TorMonitorService.jsm:100
14:37:30.976 TorConnect: init() TorConnect.jsm:836:15
14:37:30.976 TorConnect: Entering Initial state TorConnect.jsm:204:13
14:37:30.976 TorConnect: Try transitioning from Initial to Disabled TorConnect.jsm:805:15
14:37:30.976 TorConnect: Exited Initial state TorConnect.jsm:209:15
14:37:30.976 TorConnect: Entering Disabled state TorConnect.jsm:204:13
14:37:31.092 Bootstrapped manifest not allowed to use 'resource' directive. chrome.manifest:2
14:37:31.495
[Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIAppStartup.secondsSinceLastOSRestart]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: resource:///modules/BrowserGlue.jsm :: _collectStartupConditionsTelemetry :: line 1642"  data: no] BrowserGlue.jsm:1642:9
    _collectStartupConditionsTelemetry resource:///modules/BrowserGlue.jsm:1642
    BG__onFirstWindowLoaded resource:///modules/BrowserGlue.jsm:1748
    BG_observe resource:///modules/BrowserGlue.jsm:976
    _delayedStartup chrome://browser/content/browser.js:2178
    _delayedStartup self-hosted:1115
14:37:31.514 SearchSettings: get: No settings file exists, new profile? DOMException: Could not open the file at /home/poncho/.mozilla/torbrowser/ii6jws4v.default/search.json.mozlz4 SearchSettings.jsm:108:18
14:37:31.623 [12-12 14:37:31] Torbutton NOTE: no SOCKS credentials found for current document.
14:37:31.674 [NoScript]:1 Including /bg/LifeCycle.js log.js:32:13
14:37:31.856 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused 2
14:37:31.866 This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”.
default-bookmarks.html
14:37:31.869 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused 2
14:37:31.879 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.882 Error: Could not get children of file(/home/poncho/.mozilla/torbrowser/ii6jws4v.default/thumbnails) because it does not exist PromiseWorker.jsm:106
14:37:31.883 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.885 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.891 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused 2
14:37:31.896 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.898 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.903 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.910 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.916 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused 2
14:37:31.919 [NoScript]:2 Including /legacy/Legacy.js log.js:32:13
14:37:31.921 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.921 [NoScript]:3 Including /legacy/defaults.js log.js:32:13
14:37:31.923 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.927 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.929 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.935 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused
14:37:31.938 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused 2
14:37:31.942 [12-12 14:37:31] Torbutton WARN: Tor test failed. Proxy connection refused

Is it visible in about:preferences's sidebar? Or are you opening it manually?

Neither. It is not visible in the side bar and about:preferences#connection redirects to about:preferences#general

Neither. It is not visible in the side bar and about:preferences#connection redirects to about:preferences#general

Then why are you saying it's broken?

This is the intended behavior .

ReferenceError: FileUtils is not defined startup-observer.js:121:11 setProxySettings jar:file:///usr/lib64/torbrowser/omni.ja!/chrome/torbutton/components/startup-observer.js:121 observe jar:file:///usr/lib64/torbrowser/omni.ja!/chrome/torbutton/components/startup-observer.js:175

Yes, this was the error the first patch you linked solves.

I wonder if it prevents the whole StartupObserver to run as intended.

Then why are you saying it's broken? This is the intended behavior.

Sorry about that. I thought you were expecting the panel to show something

Yes, this was the error the first patch you linked solves.

So torbutton@004b629b removed FileUtils: "resource://gre/modules/FileUtils.jsm" which is still used in https://gitlab.torproject.org/tpo/applications/torbutton/-/blob/main/components/startup-observer.js#L121

        if (!isWindows && environ.exists("TOR_SOCKS_IPC_PATH")) {
          socksPortInfo.ipcFile = new FileUtils.File(
            environ.get("TOR_SOCKS_IPC_PATH")
          );

This fixes my issue:

diff --git a/components/startup-observer.js b/components/startup-observer.js
index 8f9b8cc2..3342c451 100644
--- a/components/startup-observer.js
+++ b/components/startup-observer.js
@@ -26,6 +26,7 @@ const { TorProtocolService } = ChromeUtils.import(
 
 XPCOMUtils.defineLazyModuleGetters(this, {
   ComponentUtils: "resource://gre/modules/ComponentUtils.jsm",
+  FileUtils: "resource://gre/modules/FileUtils.jsm",
 });
 
 // Module specific constants

Oh, it makes sense! Do you want to open a merge request with the fix?

Do you want to open a merge request with the fix?

Done. Thanks for your support.

Thank you very much!

mentioned in merge request torbutton!119 (merged)

marked this issue as related to tor-browser-build#40709 (closed)

marked this issue as related to tor-browser-build#40703 (closed)

assigned to @Poncho and unassigned @pierov

removed Backlog label

closed

mentioned in issue tor-browser-build#40709 (closed)

Sorry about that. I thought you were expecting the panel to show something

TBH I think that we could relax the need for an owned tor daemon, and show it whenever we have a working control connection, even to system tor.

What do you think @richard? Should we open an issue about that (and coordinate with the Tails folks not to break things on their side)?

I'm fairly certain Tails (and other system tor users) does not want Tor Browser to be able to change the Tor Daemon's settings.

added MacOS label

TOR_SOCKS_IPC_PATH environment variable not honored

Designs

Child items ...

Activity