New Identity clears history even if history storage is enabled
If Tor Browser 12 is configured to store browsing history, New Identity now clears this history. This is unexpected, as we have always preserved history for people who enable that in the past. Because we do not render visited styles, history storage does not leak information to websites, so it does not need to be cleared in this case.
See also: team#19
I am wondering if this is a side effect of re-implementing New Identity in the browser, as opposed to Torbutton? If we just naively switched to doing what Firefox does on "Clear all browser state", then we may also not be clearing some additional linkable state, or emitting events for extensions, and properly closing things like keep-alive connections, SSL state, blob urls, etc.
Torbutton's behavior on New Identity was formerly documented here: https://2019.www.torproject.org/projects/torbrowser/design/#new-identity.