Circuit data is cleared for still-open circuits with no browser
Steps to reproduce
- Open torbrowser.
- Wait 5 minutes.
- Open example.org.
- Wait 4 minutes.
- Open a new tab and close the example.org tab.
- Wait 1 minute.
- Right click the new tab and select "Reopen closed tab".
Result
example.org loads with no circuit button in the url bar. Similarly, reloading the page or opening the same domain in a new tab will also have no circuit display.
Expect
example.org to still have a circuit display showing the circuit that would have been shown during step 4 above.
Origin
Regression from !699 (merged)
Basically, the circuit clean up triggered every ten minutes only keeps circuit data for circuits with a corresponding browser instance, even though the tor process itself is still using the circuit for future requests to the example.org domain (for another 5 minutes until it closes).
CC @pierov