Review Mozilla 1746983: Re-enable pingsender2

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1746983

Pingsender is back and this time it means business (we should see if we need to amend our disable ping sender commit)

added 13.0 stable Code Audit Linkability FF115-esr labels

assigned to @pierov

marked this issue as related to tor-browser-spec#40056 (closed)

we should see if we need to amend our disable ping sender commit

Maybe, but probably not because of pingsender .

The patch modifies runPingSender in toolkit/components/telemetry/app/TelemetrySend.jsm (now TelemetrySend.sys.mjs). However, we modify it to immediately throw when called.

We don't have any if on it, so I added an eslint-disable-next-line no-unreachable, but maybe we might want to add an if (AppConstants.BASE_BROWSER_VERSION) or something like that, if we don't like that linter suppression.

I don't really care but better code is more good so go for it.

I don't really care

Okay, then I'd stay with the status quo instead .

The reason for which I didn't do it from the beginning is that I don't like adding the dependency on our custom AppConstants, in case we update them again and we lose parts.
Also, an advantage of the current patch is that anyone could take it and apply to their patchset, without doing anything else.

Telling the linter not to care was enough not to have our code automatically changed.

wfm!

added Needs Review label

removed Needs Review label

added Next label

closed

removed Next label

mentioned in issue tor-browser-spec#40056 (closed)

marked this issue as related to tor-browser-build#40965 (closed)

marked this issue as related to tor-browser-build#40966 (closed)