Review Mozilla 1812518: Allow a custom View for 3rd party downloads

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1812518

Unclear what 3rd party downloads or how they are meant to work, but we def don't want files downloaded via tor browser android to be re-routed outside the browser and not through tor.

added 13.0 stable Code Audit Proxy Bypass FF115-esr labels

assigned to @dan

marked this issue as related to tor-browser-spec#40058 (closed)

added Next label

added Task label

added Desktop label

added Android label and removed Desktop label

So the wording throughout this feature is a bit vauge and inconsistent sometimes just reffering to allowing styling of the downloads by the client, but the meat seems to be

* @property customFirstPartyDownloadDialog An optional delegate for showing a dialog for a download
 * that will be processed by the current application.
 * @property customThirdPartyDownloadDialog An optional delegate for showing a dialog for a download
 * that can be processed by multiple installed applications including the current one.

and that yes, this feature appears to allow handing a download off to a 3rd party app, that we def want to block.

Will look into a MR to disable this

added Doing label

removed Next label

Ok on further investigations

https://gitlab.torproject.org/tpo/applications/firefox-android/-/blob/firefox-android-115.2.1-13.0-1/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt?ref_type=heads#L526

we disable shouldForwardToThirdParties in "Modify UI/UX" commit, which covers some of this, but I'm not sure all

The rest is just using the customFirstPartyDownloadDialog that was added in firefox-android@98909260 and is just a new enhanced in app download modal

closed

mentioned in issue tor-browser-spec#40058 (closed)

marked this issue as related to tor-browser-build#40965 (closed)