Skip to content

Crash in firefox-android originating in backported FullScreenNotificationDialog patch

We've an uptick in crashes reported with the 13.0.8 release. Unclear if this is going to be a major problem or an annoyance, but the reported crash rate in 13.0.8 is significantly higher than the overall background crash rate of previous releases.

Stack trace from Google Play:

Exception java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
  at androidx.fragment.app.FragmentManager.enqueueAction (FragmentManager.java:38)
  at androidx.fragment.app.BackStackRecord.commitInternal (BackStackRecord.java:54)
  at androidx.fragment.app.BackStackRecord.commit (BackStackRecord.java:2)
  at androidx.fragment.app.DialogFragment.dismissInternal (DialogFragment.java:110)
  at mozilla.components.feature.prompts.dialog.FullScreenNotificationDialog$onStart$1$2.invokeSuspend (FullScreenNotificationDialog.kt:39)
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:9)
  at kotlinx.coroutines.DispatchedTaskKt.resume (DispatchedTask.kt:48)
  at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume (CancellableContinuationImpl.kt:129)
  at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl (CancellableContinuationImpl.kt:38)
  at kotlinx.coroutines.CancellableContinuationImpl.resumeUndispatched (CancellableContinuationImpl.kt:24)
  at kotlinx.coroutines.android.HandlerContext$scheduleResumeAfterDelay$$inlined$Runnable$1.run (Runnable.kt:7)
  at android.os.Handler.handleCallback (Handler.java:942)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:226)
  at android.os.Looper.loop (Looper.java:313)
  at android.app.ActivityThread.main (ActivityThread.java:8762)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:604)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1067)

Something is throwing a java.lang.IllegalStateException

The originating code was added in firefox-android!52 (merged)

/cc @ma1 @dan @clairehurst

EDIT: this brings the 'user perceived crash rate' up from 0.2% to 0.8% so while this seems bad in a relative sense (4x more crashes) in the absolute sense I think we can ignore this until the new year.

Edited by morgan
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information