Offline state is unreachable in about:torconnect (first bootstrap attempt)
I think this is a regression from #41114 (closed) #40598 (closed).
!938 (merged) !248 (merged) switched the order of the signals: now TorConnectTopics.StateChange
is released before TorConnectTopics.BootstrapError
(renamed to TorConnectTopics.Error
). But TorConnectParent
only sets the internet status and error messages in response to the latter. So when we reach update_Error
in aboutTorConnect.js the internet status is not set.
Note, it is actually still possible to reach the offline page:
- Try bootstrapping and let it fail (to connect assist).
- Return to normal bootstrapping, and wait for the error. This second time around if you still have an internet error you will get the offline page since the "offline" status is already set from the previous "TorConnectTopics.Error" signal.
Edited by henry