Remove the firefox-view button from UI, even when always-on private-browsing mode is disabled

We used to disable firefoxview button with a preference, but since bugzilla bug 1817794 the preference is obsolete.

The button hasn't re-appeared though. I think it may be hidden in private browsing mode (PBM).

So there might be nothing to do other than removing the browser.tabs.firefox-view preference. But we should probably review it.

added 14.0 stable FF128-esr labels

marked this issue as related to #41876 (closed)

mentioned in issue #42616 (closed)

changed title from Review firefoxview for 128 to Remove obsolete firefox view preference (and review?) for 128

changed the description

marked this issue as related to #42037 (closed)

added Backlog label

added All Platforms label

added Task label

marked this issue as related to #42356 (closed)

removed 14.0 stable label

added 14.0 stable label

marked this issue as related to #42751 (closed)

mentioned in issue #42751 (closed)

removed Backlog label

added Next label

firefox-view seems dependent on another feature we don't enable (sync probably?). In Firefox you can enable the button programmatically and it will work as expected, in Tor Browser the button can be enabled but is not interactable.

assigned to @morgan

changed title from Remove obsolete firefox view preference (and review?) for 128 to Remove obsolete firefox-view preference

removed Next label

added Doing label

changed title from Remove obsolete firefox-view preference to Remove the firefox-view button from UI, even when always-on private-browsing mode is disabled

Removing/disabling the pref does not change the behaviour.

However, if one disables always-on private browsing mode, the firefox-view button comes back (and it is available in the customisable toolbar page). The button itself is not functional.

I think we need to write a patch to basically get us back the old behaviour, otherwise users which disable always-on private browsing mode will have this vestigal button appear in the tab-bar.

assigned to @henry and unassigned @morgan

removed Doing label

added Next label

removed Next label

added Doing label

mentioned in merge request !1210 (merged)

marked this issue as related to tor-browser-build#41239 (closed)

marked this issue as related to tor-browser-build#41238 (closed)

removed All Platforms label

added Desktop label

Thanks @henry!

closed