Skip to content

firefox-android 128.1 rebase TODOs and patchset health work

Capturing rebase tasks from !1064 (closed) as identified by @pierov

  1. torbrowser_strings.xml and YEC

The rest of the strings basically revert Bug 42074: [android] 2023 year end campaign for tor browser HomeFragment. I think we could avoid having them in the MR in the first place.

(no big deal if you want to keep hashes as they are now for 128.0, we can do it in 128.1.0esr).

  1. HomeActivity.kt nit newline deleted in "Add standalone Tor Bootstrap" early commit and readded later

  2. don't add TorNetworkSettingsFragment.kt in the first place, deleted in "Add standalone Tor Bootstrap"

  3. HomeActivity.kt / Disable mozilla onboarding

this commit is mostly deleting code we added prior, delete it there and simplify it down to one commented out chunk 😄

  1. GeckoEngine.kt

deleting

            this.prioritizeOnions = it.prioritizeOnions

and other "prioritizeOnion" code in "Add Tor integration and UI" should be removed from patch its added in

  1. 'Settings.kt'

more "prioritizeOnion" code deleted in "Add Tor integration and UI" that should be removed from adding commit

open var prioritizeOnions: Boolean by UnsupportedSetting()

  1. "Delete unused media" and "Remove ability to submit site support requests" have a lot of deletes

a) pull deletes out of "Remove ability to submit site support requests" and consolidate b) where deleting previously added, remove from source

  1. identify various .gitignore additions and consolidate

  2. tor_bootstrap_background_gradient.xml in "Add standalone Tor Bootstrap"

changes colors, just move changes to when they were added

  1. confirm and redelete:
  • mobile/android/fenix/app/src/main/res/drawable/tor_onboarding_donate_gradient.xml
  • mobile/android/fenix/app/src/main/res/drawable/tor_onboarding_donate_rounded_corners.xml
  1. SupportUtils.kt

dont change WHATS_NEW_URL to "https://www.torproject.org/releases/" and then delete it in a later commit. Just delete

Edited by Dan Ballard
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information