Skip to content

Remove hard-coded CSS `line-height`

Setting a line-height can cause problems in some locales. E.g.

Screenshot of burmese text wrapping in about:tbupdate

Screenshot of burmese text wrapping in about:tor

Currently used in:

  • "about:tbupdate". OK to use for the lang="en-US" content, but not the rest.
  • "about:tor". Used for the title and the message text. I think we can just unset these since they are only used in wrapping context, which is expected to be rare.
  • "about:rulesets". Used for a icon positioning hack. Otherwise used for en-US only content, which is ok.
  • Tor circuit. Sets line-height: 2 to align content, which is probably big enough for all locales, but I might be able to replace this with something cleaner.
  • Connection preferences. A few places where line-height: 1, which can probably be removed following #42705 (closed). Otherwise used for the bridge text input, which only expects en-US script.
  • "about:torconnect". Only used for android display, which is on the way out anyway.

/cc @donuts