Bug 42725: Fix all lints for tor-browser-128.0esr-14.0-1

Merge Info

Related Issues

• #42725 (closed)
• mullvad-browser#xxxxx
• tor-browser-build#xxxxx

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports

Issue Tracking

• [?] Link resolved issues with appropriate Release Prep issue for changelog generation

Change Description

Ok so, this is mostly blocked until !1051 (merged) is merged... But I thought I'd go ahead and open it to start getting feedback.

I tried to make the least changes and still address the lints -- without flat out disabling the linter everywhere 😅 There are some decisions that might seem weird because of it though, such as just increasing the complexity value where that was an issues and adding some very useless docstrings. For the complexity ones I stand by my decision, the complex functions are coming overly complex from upstream and they seem to plan to fix that so we can fix it when they do... The documentation ones, maybe we can let it fail until the authors fix it? That would be highly annoying for everyone, but 🤷 annoyance is sometimes a positive thing? Anyways, let me know.

How Tested

We won't be able to verify this until !1051 (merged) is merged and this is rebased on top of it.

Related to #42725 (closed)