Skip to content

Suggestion: Consider adding component as a column to generated audit CSV

Merge Info

Related Issues

  • tor-browser#xxxxx
  • mullvad-browser#xxxxx
  • tor-browser-build#xxxxx

Backporting

Timeline

  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Localization: typos and other localization changes that should be also in the release branch
  • Other: please explain

Merging

  • Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
  • Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
    • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

Review

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macOS : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : dan, ma1, pierov, richard
    • security : jwilde, ma1
    • signing : boklm, richard
    • updater : pierov
    • windows : jwilde, richard
    • misc/other : pierov, richard

Change Description

I realize this is a bit too little too late, but I only realized this might be nice when I started doing the audit.

The main changes here are:

  • Add the Bugzilla component as a column to the audit CSV

The component is sometimes required context alongside the bug title to understand what is going on, so it's nice for it to be in the CSV.

  • Order by component then by id

I noticed there is some very intense context switching when auditing, because each bug is from a different part of the application. Ordering by components addresses this. Ordering by id is still nice because the ids are monotonically increasing so that is analogous to ordering by creation date -- also this was originally ordered by id.


We can maybe add the columns to the current audit CSV if we like. Since people are already using the sheets it would be bad to re-order rows, but maybe we can just add the column in the current order for now -- not really sure if it would help much but 🤷

/cc @boklm @clairehurst @dan @henry @jwilde @ma1 @pierov

How Tested

You can check out how this looks here: https://docs.google.com/spreadsheets/d/1fXXckVHs3nprjaGuUyOfQawG34_BdVC_0_bGTVDzpug/edit?usp=sharing in the 118 -- order by component and id sheets.

Edited by morgan

Merge request reports