Focus the "Got it" button when opening the downloads panel

Merge Info

Related Issues

• #42642 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : jwilde, ma1
  • signing : boklm, richard
  • updater : pierov
  • windows : jwilde, richard
  • misc/other : pierov, richard

Change Description

@morgan I would like to be able to test this in next week's alpha or nightly build, and then backport the fix if it works. I'll test that this works ok with NVDA on windows as well.

When the downloads panel is opened we now focus the "Got it" button, rather than the download list item. This ensures that the alert is read on Orca, moreover it should ensure that it is read before the rest of the panel content.

When I originally implemented this alert I avoided focusing the "Got it" button because I thought the alert could be more passive, and I didn't want to push the user too hard to feel like they need to click it. But I think this turned out to be too fragile.

How Tested

With the screen reader on, open the download panel and the "Be careful opening downloads" alert should be read back. Pressing "Got it" will move the focus to the download list.

You can re-show the warning by toggling the browser.download.showTorWarning preference in "about:config".

I also reset the browser.download.panel.shown preference, which will make the download panel open and focus automatically at the next download.