Bug 43016: Redisable Nimbus

Merge Info

Related Issues

• #43016 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : jwilde, ma1
  • signing : boklm, richard
  • updater : pierov
  • windows : jwilde, richard
  • misc/other : pierov, richard

Change Description

Nimbus integration was reworked by moz and our patch to disable it failed to carry over to the update. This finishes backing out the old patch in Analytics.kt (see in this squashed 115 branch dan/firefox-android@6c3e2137)

and ports it over to it's new home. Also add some extra disabling stuff like a null message disk store, cus esh

How Tested

Ran and no crashes and no apparent errors in adb console

requested review from @pierov

assigned to @dan

changed the description

@morgan thanks for the catch on this ticket to review, also this is a good case for why we want defense in depth with regards to analytics, both disableing at the root, but also disabeling all the uses we can find

Lgtm, but I'm by no means expert about this.

I couldn't find more uncommented recordEvent calls. They aren't that many, so I wonder if there are other functions to check.

Very nice to see the null implementations. Wonder if one day they'll be enough to make the patchset lighter .

@clairehurst do you want to have another pass or can we merge it already?

approved this merge request

resolved all threads

added 5 commits

• 25bf3460...50ad336a - 4 commits from branch tpo/applications:tor-browser-128.2.0esr-14.0-1
• 7c54df4a - fixup! Bug 40185: [android] Use NimbusDisabled

Compare with previous version

marked this merge request as draft from dan/tor-browser@7c54df4a

marked this merge request as ready

enabled an automatic merge when the pipeline for 7c54df4a succeeds

merged

marked the checklist item Link resolved issues with appropriate Release Prep issue for changelog generation as completed