Bug 30543: Backport screen orientation fixes (MozBugs 1607032 and 1918202)

Merge Info

Related Issues

• #30543 (closed)
• mullvad-browser#xxxxx
• tor-browser-build#xxxxx
• Bugs 1607032 and 1899736

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : jwilde, ma1
  • signing : boklm, richard
  • updater : pierov
  • windows : jwilde, richard
  • misc/other : pierov, richard

Change Description

Cherry-picked a couple of commits from upstream for better compatibility with screen rotations and RFP.

The commits (524e3bb0df01aa860150ae7cf469f2d76a3f8327, 58b66d38ca9c07e0ce3282b6eff7ba3ce5828e42) didn't apply cleanly because of 7aa1a5202434d89993a3e3f9d9a0bf76f75ea8b7 (basically, the cherry-picked commits add at the end of RFPService, but the other commit introduces another couple of methods there, so the conflicts were actually very easy to solve).

How Tested

Check orientation on TZP. Resize the window to be in portrait.

Now it always match CSS/matchMedia orientation, whereas before it always stayed on "landscape-primary | 0 | landscape-primary".