Bug 43102: Android notifications tell to make Firefox your default browser

Merge Info

Related Issues

• #43102 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : jwilde, ma1
  • signing : boklm, richard
  • updater : pierov
  • windows : jwilde, richard
  • misc/other : pierov, richard

Change Description

Commented out lines responsible for this behavior.

How Tested

Notice after building with these changes there is no longer any reference (outside of other languages and MessageCard.kt compose preview functions) to nimbus_notification_default_browser_text ("Make Firefox your default browser"), nimbus_notification_default_browser_title ("Firefox is fast and private"), default_browser_experiment_card_title ("Switch your default browser"), default_browser_experiment_card_text ("Set links from websites, emails, and messages to open automatically in Firefox.")

I wasn't able to reproduce it without these changes (relaunched a "release" build several times, as well as 14.0a4). Kinda hard to test directly, from the file it seems that you need either have 4 launches of the app or wait three days after install and maybe also be on release (not sure about this one since it was found on the alpha version https://forum.torproject.org/t/new-alpha-release-tor-browser-14-0a3/14326/5)