Skip to content

Bug 43121: Do not run pipelines for tags

brizental requested to merge brizental/tor-browser:43121-no-tags into tor-browser-128.4.0esr-14.5-1

Merge Info

Related Issues

Backporting

Timeline

  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

Merging

  • Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
  • Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
    • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Change Description

Pipelines cannot run for tags 1. because it's unnecessary 2. because the pipelines require a branch to fetch from, which doesn't exist in tag contexts.

This is extra bad, because when no branches exist in the context the pipeline tries to do a full fetch of the remote repository and given the amount of parallel jobs we can run at a time -- especially when tagging -- this breaks Gitalb.

To be extra sure, I also added a check at the beggining of each job if there is a branch defined and if not the pipeline should exit early.

How Tested

Untested. We need to create a tag and see if nothing happens.

Merge request reports