Drop profile access errors

Merge Info

Related Issues

• #42739 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : jwilde, ma1
  • signing : boklm, richard
  • updater : pierov
  • windows : jwilde, richard
  • misc/other : pierov, richard

Change Description

The "Bug 42739: Use brand name for profile error messages." commit is for both base-browser and tor-browser, so that mullvad benefits. The other two commits are for the tor-browser branch only.

1. We revert/drop "Improve profile access error messages."
2. We remove the corresponding strings.
3. We add a new commit "Bug 42739: Use brand name for profile error messages." to replace "Firefox" in the remaining error messages from mozilla-central's profileSelection.properties. We probably want this for mullvad-browser as well.

How Tested

1. Run make run twice simultaneously. Should get "Tor Browser is already running, but is not responding. To use Tor Browser, you must first close the existing Tor Browser process, restart your device, or use a different profile."
2. chmod 000 .binaries/dev/Browser/TorBrowser/Data/Browser/ and make run. Should get "Your Tor Browser profile cannot be loaded. It may be missing or inaccessible."
3. Visit "about:support" and click "Refresh Tor Browser...". Existing profile will be backed up in "Old Tor Browser Data" in .binaries/dev/Browser.